Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

devpoll test failures on Solaris #81433

Closed
kulikjak mannequin opened this issue Jun 12, 2019 · 3 comments
Closed

devpoll test failures on Solaris #81433

kulikjak mannequin opened this issue Jun 12, 2019 · 3 comments
Labels
3.8 only security fixes extension-modules C modules in the Modules dir

Comments

@kulikjak
Copy link
Mannequin

kulikjak mannequin commented Jun 12, 2019

BPO 37252
Nosy @benjaminp, @matrixise, @kulikjak
PRs
  • bpo-37252: Fix devpoll tests #14017
  • [3.8] closes bpo-37252: Fix devpoll tests. (GH-14017) #15948
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2019-09-11.13:42:08.549>
created_at = <Date 2019-06-12.14:20:14.678>
labels = ['extension-modules', '3.8']
title = 'devpoll test failures on Solaris'
updated_at = <Date 2019-09-11.14:37:41.241>
user = 'https://github.com/kulikjak'

    bugs.python.org fields:

    activity = <Date 2019-09-11.14:37:41.241>
actor = 'matrixise'
assignee = 'none'
closed = True
closed_date = <Date 2019-09-11.13:42:08.549>
closer = 'benjamin.peterson'
components = ['Extension Modules']
creation = <Date 2019-06-12.14:20:14.678>
creator = 'kulikjak'
dependencies = []
files = []
hgrepos = []
issue_num = 37252
keywords = ['patch']
message_count = 3.0
messages = ['345365', '351876', '351908']
nosy_count = 3.0
nosy_names = ['benjamin.peterson', 'matrixise', 'kulikjak']
pr_nums = ['14017', '15948']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue37252'
versions = ['Python 3.8']
    @kulikjak
    Copy link
    Mannequin Author

    kulikjak mannequin commented Jun 12, 2019

    test_devpoll currently ends with two failures with Python 3.8 on Solaris.

    First one is wrong number of arguments to devpoll.register function (which thrown the same error as expected in 3.7 but now acts differently).

    Second one is that register and modify no longer throw OverflowError when negative number is given as second argument, but rather a ValueError. I am not sure whether this is just a small semantics change or some bigger problem (documentation doesn't mention what error should be thrown).

    So I fixed it in attached pull request by changing the expected thrown error but there might be other problem as well.

    @kulikjak kulikjak mannequin added 3.8 only security fixes extension-modules C modules in the Modules dir labels Jun 12, 2019
    @benjaminp
    Copy link
    Contributor

    New changeset 95da826 by Benjamin Peterson (Jakub Kulík) in branch 'master':
    closes bpo-37252: Fix devpoll tests. (GH-14017)
    95da826

    @matrixise
    Copy link
    Member

    New changeset b4808c1 by Stéphane Wirtel (Miss Islington (bot)) in branch '3.8':
    closes bpo-37252: Fix devpoll tests. (GH-14017) (GH-15948)
    b4808c1

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.8 only security fixes extension-modules C modules in the Modules dir
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @matrixise @benjaminp