Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize calling special methods #81412

Closed
jdemeyer opened this issue Jun 11, 2019 · 3 comments
Closed

Optimize calling special methods #81412

jdemeyer opened this issue Jun 11, 2019 · 3 comments
Labels
3.9 only security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) performance Performance or resource usage

Comments

@jdemeyer
Copy link
Contributor

BPO 37231
Nosy @methane, @jdemeyer
PRs
  • bpo-37231: optimize calls of special methods #13973
  • bpo-37231: remove _PyObject_FastCall_Prepend which is no longer used #14153
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2019-07-01.15:27:25.489>
    created_at = <Date 2019-06-11.13:07:40.804>
    labels = ['interpreter-core', '3.9', 'performance']
    title = 'Optimize calling special methods'
    updated_at = <Date 2019-07-01.15:27:25.489>
    user = 'https://github.com/jdemeyer'

    bugs.python.org fields:

    activity = <Date 2019-07-01.15:27:25.489>
    actor = 'jdemeyer'
    assignee = 'none'
    closed = True
    closed_date = <Date 2019-07-01.15:27:25.489>
    closer = 'jdemeyer'
    components = ['Interpreter Core']
    creation = <Date 2019-06-11.13:07:40.804>
    creator = 'jdemeyer'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 37231
    keywords = ['patch']
    message_count = 3.0
    messages = ['345231', '345482', '345847']
    nosy_count = 2.0
    nosy_names = ['methane', 'jdemeyer']
    pr_nums = ['13973', '14153']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'performance'
    url = 'https://bugs.python.org/issue37231'
    versions = ['Python 3.9']

    @jdemeyer
    Copy link
    Contributor Author

    Change call_method() and related functions in Objects/typeobject.c to allow profiting from the PY_VECTORCALL_ARGUMENTS_OFFSET optimization: instead of passing "self" as separate argument, put it inside the args vector.

    @jdemeyer jdemeyer added 3.9 only security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) performance Performance or resource usage labels Jun 11, 2019
    @methane
    Copy link
    Member

    methane commented Jun 13, 2019

    New changeset b4b814b by Inada Naoki (Jeroen Demeyer) in branch 'master':
    bpo-37231: optimize calls of special methods (GH-13973)
    b4b814b

    @methane
    Copy link
    Member

    methane commented Jun 17, 2019

    New changeset 0456df4 by Inada Naoki (Jeroen Demeyer) in branch 'master':
    bpo-37231: remove _PyObject_FastCall_Prepend (GH-14153)
    0456df4

    @jdemeyer jdemeyer closed this as completed Jul 1, 2019
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.9 only security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) performance Performance or resource usage
    Projects
    None yet
    Development

    No branches or pull requests

    2 participants