Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

math.comb is leaking references #81306

Closed
pablogsal opened this issue Jun 1, 2019 · 4 comments
Closed

math.comb is leaking references #81306

pablogsal opened this issue Jun 1, 2019 · 4 comments
Labels
3.8 only security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) tests Tests in the Lib/test dir

Comments

@pablogsal
Copy link
Member

BPO 37125
Nosy @rhettinger, @mdickinson, @serhiy-storchaka, @pablogsal

Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2019-06-01.20:08:35.448>
created_at = <Date 2019-06-01.16:31:17.453>
labels = ['interpreter-core', '3.8', 'tests']
title = 'math.comb is leaking references'
updated_at = <Date 2019-06-01.20:26:09.625>
user = 'https://github.com/pablogsal'

bugs.python.org fields:

activity = <Date 2019-06-01.20:26:09.625>
actor = 'rhettinger'
assignee = 'none'
closed = True
closed_date = <Date 2019-06-01.20:08:35.448>
closer = 'pablogsal'
components = ['Interpreter Core', 'Tests']
creation = <Date 2019-06-01.16:31:17.453>
creator = 'pablogsal'
dependencies = []
files = []
hgrepos = []
issue_num = 37125
keywords = []
message_count = 4.0
messages = ['344185', '344187', '344214', '344220']
nosy_count = 4.0
nosy_names = ['rhettinger', 'mark.dickinson', 'serhiy.storchaka', 'pablogsal']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue37125'
versions = ['Python 3.8']
@pablogsal
Copy link
Member Author

./python Lib/test/bisect_cmd.py test_math -R 2:2

...

WARNING: Running tests with --huntrleaks/-R and less than 3 warmup repetitions can give false positives!
Run tests sequentially
0:00:00 load avg: 1.32 [1/1] test_math
beginning 4 repetitions
1234
....
test_math leaked [12352, 12352] references, sum=24704
test_math leaked [1, 1] memory blocks, sum=2
test_math failed

== Tests result: FAILURE ==

1 test failed:
test_math

Total duration: 663 ms
Tests result: FAILURE
ran 1 tests/2
exit 2
Tests failed: continuing with this subtest

Tests (1):

  • test.test_math.IsCloseTests.testComb

Bisection completed in 13 iterations and 0:00:11

@pablogsal pablogsal added 3.8 only security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) tests Tests in the Lib/test dir labels Jun 1, 2019
@pablogsal
Copy link
Member Author

It seems that #13725 fixes the leak:

❯ ./python -m test test_math -R :
Run tests sequentially
0:00:00 load avg: 1.55 [1/1] test_math
beginning 9 repetitions
123456789
.........

== Tests result: SUCCESS ==

1 test OK.

Total duration: 26 sec 283 ms
Tests result: SUCCESS

@pablogsal
Copy link
Member Author

Fixed by #13725

@rhettinger
Copy link
Contributor

Please file this in the tracker issue so that the discussions don't sprawl. Thx.

@ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3.8 only security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rhettinger @pablogsal