Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement PEP 591: add Final qualifier and @final decorator to typing #81226

Closed
ilevkivskyi opened this issue May 25, 2019 · 2 comments
Closed

Implement PEP 591: add Final qualifier and @final decorator to typing #81226

ilevkivskyi opened this issue May 25, 2019 · 2 comments
Assignees
@ilevkivskyi
Labels
3.8 only security fixes stdlib Python modules in the Lib dir type-feature A feature request or enhancement

Comments

@ilevkivskyi
Copy link
Member

BPO 37045
Nosy @gvanrossum, @ilevkivskyi, @msullivan
PRs
  • bpo-37045: PEP 591: Add final qualifiers to typing module #13571
  • bpo-37045: Add one more test for typing.Final #13588
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/ilevkivskyi'
closed_at = <Date 2019-05-26.08:43:55.247>
created_at = <Date 2019-05-25.18:29:03.772>
labels = ['3.8', 'type-feature', 'library']
title = 'Implement PEP 591: add Final qualifier and @final decorator to typing'
updated_at = <Date 2019-05-26.21:27:38.087>
user = 'https://github.com/ilevkivskyi'

    bugs.python.org fields:

    activity = <Date 2019-05-26.21:27:38.087>
actor = 'levkivskyi'
assignee = 'levkivskyi'
closed = True
closed_date = <Date 2019-05-26.08:43:55.247>
closer = 'levkivskyi'
components = ['Library (Lib)']
creation = <Date 2019-05-25.18:29:03.772>
creator = 'levkivskyi'
dependencies = []
files = []
hgrepos = []
issue_num = 37045
keywords = ['patch']
message_count = 2.0
messages = ['343501', '343538']
nosy_count = 3.0
nosy_names = ['gvanrossum', 'levkivskyi', 'msullivan']
pr_nums = ['13571', '13588']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue37045'
versions = ['Python 3.8']
    @ilevkivskyi
    Copy link
    Member Author

    The actual implementation is performed by type checkers like mypy. We just need to add the names to the typing module.

    @ilevkivskyi ilevkivskyi added the 3.8 only security fixes label May 25, 2019
    @ilevkivskyi ilevkivskyi self-assigned this May 25, 2019
    @ilevkivskyi ilevkivskyi added stdlib Python modules in the Lib dir type-feature A feature request or enhancement labels May 25, 2019
    @ilevkivskyi
    Copy link
    Member Author

    New changeset f367242 by Ivan Levkivskyi in branch 'master':
    bpo-37045: PEP-591: Add final qualifiers to typing module (GH-13571)
    f367242

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @ilevkivskyi ilevkivskyi

    Labels
    3.8 only security fixes stdlib Python modules in the Lib dir type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    1 participant
    @ilevkivskyi