Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

typing.__all__ has drifted from actual contents #81164

Closed
asottile mannequin opened this issue May 21, 2019 · 7 comments
Closed

typing.__all__ has drifted from actual contents #81164

asottile mannequin opened this issue May 21, 2019 · 7 comments
Labels
3.8 only security fixes stdlib Python modules in the Lib dir

Comments

@asottile
Copy link
Mannequin

asottile mannequin commented May 21, 2019

BPO 36983
Nosy @gvanrossum, @ilevkivskyi, @asottile, @miss-islington
PRs
  • bpo-36983: Fix typing.__all__ and add test for exported names #13456
  • [3.7] bpo-36983: Fix typing.__all__ and add test for exported names (GH-13456) #13662
  • [3.6] bpo-36983: Fix typing.__all__ and add test for exported names (GH-13456) #13663
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2019-05-30.04:06:33.475>
created_at = <Date 2019-05-21.03:40:16.328>
labels = ['3.8', 'library']
title = 'typing.__all__ has drifted from actual contents'
updated_at = <Date 2019-05-30.04:06:33.474>
user = 'https://github.com/asottile'

    bugs.python.org fields:

    activity = <Date 2019-05-30.04:06:33.474>
actor = 'gvanrossum'
assignee = 'none'
closed = True
closed_date = <Date 2019-05-30.04:06:33.475>
closer = 'gvanrossum'
components = ['Library (Lib)']
creation = <Date 2019-05-21.03:40:16.328>
creator = 'Anthony Sottile'
dependencies = []
files = []
hgrepos = []
issue_num = 36983
keywords = ['patch']
message_count = 7.0
messages = ['342975', '342976', '343905', '343906', '343911', '343946', '343947']
nosy_count = 4.0
nosy_names = ['gvanrossum', 'levkivskyi', 'Anthony Sottile', 'miss-islington']
pr_nums = ['13456', '13662', '13663']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue36983'
versions = ['Python 3.8']
    @asottile
    Copy link
    Mannequin Author

    asottile mannequin commented May 21, 2019

    notably it is missing ForwardRef, OrderedDict, ChainMap in python3.8

    it is missing others in other versions

    I'm going to attempt to write a test which should classify things that should belong there

    @asottile asottile mannequin added 3.8 only security fixes stdlib Python modules in the Lib dir labels May 21, 2019
    @asottile
    Copy link
    Mannequin Author

    asottile mannequin commented May 21, 2019

    using the same heuristic as the test uses, here's what's been missing from __all__ historically

    (note: I manually skipped Final for 3.5.0-3)

    ===================================(3, 5, 0)===================================
    +FrozenSet
    +SupportsBytes
    +SupportsComplex
    ===================================(3, 5, 1)===================================
    +FrozenSet
    +SupportsBytes
    +SupportsComplex
    ===================================(3, 5, 2)===================================
    +FrozenSet
    +SupportsBytes
    +SupportsComplex
    ===================================(3, 5, 3)===================================
    +AsyncIterable
    +AsyncIterator
    +Awaitable
    +Coroutine
    +SupportsBytes
    +SupportsComplex
    ===================================(3, 5, 4)===================================
    +AsyncContextManager
    +AsyncIterable
    +AsyncIterator
    +Awaitable
    +ChainMap
    +Coroutine
    +NoReturn
    ===================================(3, 5, 5)===================================
    +AsyncContextManager
    +AsyncIterable
    +AsyncIterator
    +Awaitable
    +ChainMap
    +Coroutine
    +NoReturn
    ===================================(3, 5, 6)===================================
    +AsyncContextManager
    +AsyncIterable
    +AsyncIterator
    +Awaitable
    +ChainMap
    +Coroutine
    +NoReturn
    ===================================(3, 5, 7)===================================
    +AsyncContextManager
    +AsyncIterable
    +AsyncIterator
    +Awaitable
    +ChainMap
    +Coroutine
    +NoReturn
    ===================================(3, 6, 0)===================================
    +AsyncIterable
    +AsyncIterator
    +Awaitable
    +Collection
    +ContextManager
    +Coroutine
    +SupportsBytes
    +SupportsComplex
    ===================================(3, 6, 1)===================================
    +AsyncGenerator
    +AsyncIterable
    +AsyncIterator
    +Awaitable
    +ChainMap
    +Collection
    +ContextManager
    +Coroutine
    +SupportsBytes
    +SupportsComplex
    ===================================(3, 6, 2)===================================
    +AsyncContextManager
    +AsyncGenerator
    +AsyncIterable
    +AsyncIterator
    +Awaitable
    +ChainMap
    +Collection
    +Coroutine
    +NoReturn
    ===================================(3, 6, 3)===================================
    +AsyncContextManager
    +AsyncGenerator
    +AsyncIterable
    +AsyncIterator
    +Awaitable
    +ChainMap
    +Collection
    +Coroutine
    +NoReturn
    ===================================(3, 6, 4)===================================
    +AsyncContextManager
    +AsyncGenerator
    +AsyncIterable
    +AsyncIterator
    +Awaitable
    +ChainMap
    +Collection
    +Coroutine
    +NoReturn
    ===================================(3, 6, 5)===================================
    +AsyncContextManager
    +AsyncGenerator
    +AsyncIterable
    +AsyncIterator
    +Awaitable
    +ChainMap
    +Collection
    +Coroutine
    +NoReturn
    ===================================(3, 6, 6)===================================
    +AsyncContextManager
    +AsyncGenerator
    +AsyncIterable
    +AsyncIterator
    +Awaitable
    +ChainMap
    +Collection
    +Coroutine
    +NoReturn
    ===================================(3, 6, 7)===================================
    +AsyncContextManager
    +AsyncGenerator
    +AsyncIterable
    +AsyncIterator
    +Awaitable
    +ChainMap
    +Collection
    +Coroutine
    +NoReturn
    ===================================(3, 6, 8)===================================
    +AsyncContextManager
    +AsyncGenerator
    +AsyncIterable
    +AsyncIterator
    +Awaitable
    +ChainMap
    +Collection
    +Coroutine
    +NoReturn
    ===================================(3, 7, 0)===================================
    +ChainMap
    +ForwardRef
    ===================================(3, 7, 1)===================================
    +ChainMap
    +ForwardRef
    ===================================(3, 7, 2)===================================
    +ChainMap
    +ForwardRef
    +OrderedDict
    ===================================(3, 7, 3)===================================
    +ChainMap
    +ForwardRef
    +OrderedDict

    @miss-islington
    Copy link
    Contributor

    New changeset d30da5d by Miss Islington (bot) (Anthony Sottile) in branch 'master':
    bpo-36983: Fix typing.__all__ and add test for exported names (GH-13456)
    d30da5d

    @gvanrossum
    Copy link
    Member

    It looks like the backports need to be done manually. Hopefully you'll feel up to that, otherwise we can close without doing the backports.

    @asottile
    Copy link
    Mannequin Author

    asottile mannequin commented May 29, 2019

    yep, happy to do that -- I know I'll need to do 3.7, but should I also do 3.6? 3.5?

    @miss-islington
    Copy link
    Contributor

    New changeset 3a98bbf by Miss Islington (bot) (Anthony Sottile) in branch '3.7':
    [3.7] bpo-36983: Fix typing.__all__ and add test for exported names (GH-13456) (GH-13662)
    3a98bbf

    @gvanrossum
    Copy link
    Member

    Thanks! No 3.6 backport is needed after all.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.8 only security fixes stdlib Python modules in the Lib dir
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @gvanrossum @miss-islington