Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NameError in urllib.request.URLopener.retrieve #81129

Closed
tirkarthi opened this issue May 17, 2019 · 10 comments
Closed

NameError in urllib.request.URLopener.retrieve #81129

tirkarthi opened this issue May 17, 2019 · 10 comments
Labels
3.8 only security fixes stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error

Comments

@tirkarthi
Copy link
Member

BPO 36948
Nosy @db3l, @berkerpeksag, @csabella, @tirkarthi
PRs
  • bpo-36948: Fix NameError in urllib.request.URLopener.retrieve #13389
  • [3.7] bpo-36948: Fix NameError in urllib.request.URLopener.retrieve (GH-13389) #13422
  • bpo-36948: Fix test_urlopener_retrieve_file on Windows #13476
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2019-05-21.23:01:02.528>
created_at = <Date 2019-05-17.16:09:52.421>
labels = ['3.8', 'type-bug', 'library']
title = 'NameError in urllib.request.URLopener.retrieve'
updated_at = <Date 2019-05-22.02:19:02.045>
user = 'https://github.com/tirkarthi'

    bugs.python.org fields:

    activity = <Date 2019-05-22.02:19:02.045>
actor = 'xtreak'
assignee = 'none'
closed = True
closed_date = <Date 2019-05-21.23:01:02.528>
closer = 'berker.peksag'
components = ['Library (Lib)']
creation = <Date 2019-05-17.16:09:52.421>
creator = 'xtreak'
dependencies = []
files = []
hgrepos = []
issue_num = 36948
keywords = ['patch']
message_count = 10.0
messages = ['342733', '342850', '342851', '343103', '343108', '343110', '343114', '343124', '343125', '343139']
nosy_count = 4.0
nosy_names = ['db3l', 'berker.peksag', 'cheryl.sabella', 'xtreak']
pr_nums = ['13389', '13422', '13476']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue36948'
versions = ['Python 3.8']
    @tirkarthi
    Copy link
    Member Author

    In bpo-27485 the deprecated functions were replaced with underscore prefixed ones due to which imports where modified. Some of the places where not changed causing NameError in using urllib.request.URLopener.retrieve for local files and non-local files which is deprecated. I found these undefined names while running flake8 on Lib folder. I will raise a PR with tests for the same.

    Sample Error :

    ./python.exe
Python 3.8.0a4+ (heads/master:870b035bc6, May 17 2019, 16:28:23)
[Clang 7.0.2 (clang-700.1.81)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> from urllib.request import URLopener
>>> URLopener().retrieve('file:///tmp/a.txt')
sys:1: DeprecationWarning: URLopener style of invoking requests is deprecated. Use newer urlopen functions/methods
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/Users/karthikeyansingaravelan/stuff/python/cpython/Lib/urllib/request.py", line 1786, in retrieve
    return url2pathname(splithost(url1)[1]), hdrs
NameError: name 'splithost' is not defined

    @tirkarthi tirkarthi added 3.8 only security fixes stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error labels May 17, 2019
    @berkerpeksag
    Copy link
    Member

    New changeset c661b30 by Berker Peksag (Xtreak) in branch 'master':
    bpo-36948: Fix NameError in urllib.request.URLopener.retrieve (GH-13389)
    c661b30

    @berkerpeksag
    Copy link
    Member

    Thanks! Apparently, backport to 3.7 isn't needed, so I just closed PR 13422.

    @db3l
    Copy link
    Contributor

    db3l commented May 21, 2019

    Since this patch was introduced to the 3.x branch my Windows 7 and 10 buildbots have been failing in test_urlopener_retrieve_file. See https://buildbot.python.org/all/#/builders/3/builds/2661 for the first such failure on the Win10 worker.

    The problem appears to be related to those workers having an explicit TEMP folder that happens to use a lowercase drive letter, causing the test assertion to fail due to differing case in the drive letter.

    While I could work around this by changing my builder TEMP definition, the test seems fragile on case-insensitive filesystems, so perhaps it should be comparing a normalized path instead?

    @berkerpeksag berkerpeksag reopened this May 21, 2019
    @berkerpeksag
    Copy link
    Member

    Thank you for the heads up, David. Could you please take a look at PR 13476?

    @db3l
    Copy link
    Contributor

    db3l commented May 21, 2019

    Yes, PR 13476 tested locally on the Win10 builder resolves the error.

    @db3l
    Copy link
    Contributor

    db3l commented May 21, 2019

    Oh, and just for historical purposes, it looks like the root cause was that the nturl2path.pathnametourl forces an uppercase drive letter. So that's where the inconsistency in the test got introduced.

    @berkerpeksag
    Copy link
    Member

    New changeset 2725cb0 by Berker Peksag in branch 'master':
    bpo-36948: Fix test_urlopener_retrieve_file on Windows (GH-13476)
    2725cb0

    @berkerpeksag
    Copy link
    Member

    Thanks!

    @tirkarthi
    Copy link
    Member Author

    Thank you David and Berker.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.8 only security fixes stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    3 participants
    @berkerpeksag @tirkarthi @db3l