Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

time.clock() marked for removal in 3.8 – still there. #81076

Closed
Carreau mannequin opened this issue May 12, 2019 · 11 comments
Closed

time.clock() marked for removal in 3.8 – still there. #81076

Carreau mannequin opened this issue May 12, 2019 · 11 comments
Labels
3.8 only security fixes stdlib Python modules in the Lib dir

Comments

@Carreau
Copy link
Mannequin

Carreau mannequin commented May 12, 2019

BPO 36895
Nosy @gpshead, @vstinner, @Carreau, @tirkarthi
PRs
  • bpo-36895: remove time.clock() as per removal notice. #13270
  • bpo-36895: Undocument removed time.clock #13286
  • [3.7] bpo-36895: document time.clock() has been removed in 3.8 #13287
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2019-05-27.23:41:17.224>
created_at = <Date 2019-05-12.21:21:34.514>
labels = ['3.8', 'library']
title = 'time.clock() marked for removal in 3.8 \xe2\x80\x93\xc2\xa0still there.'
updated_at = <Date 2019-05-27.23:41:17.224>
user = 'https://github.com/Carreau'

    bugs.python.org fields:

    activity = <Date 2019-05-27.23:41:17.224>
actor = 'vstinner'
assignee = 'none'
closed = True
closed_date = <Date 2019-05-27.23:41:17.224>
closer = 'vstinner'
components = ['Library (Lib)']
creation = <Date 2019-05-12.21:21:34.514>
creator = 'mbussonn'
dependencies = []
files = []
hgrepos = []
issue_num = 36895
keywords = ['patch']
message_count = 11.0
messages = ['342267', '342268', '342277', '342278', '342282', '342294', '342298', '342345', '342354', '342375', '343707']
nosy_count = 4.0
nosy_names = ['gregory.p.smith', 'vstinner', 'mbussonn', 'xtreak']
pr_nums = ['13270', '13286', '13287']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue36895'
versions = ['Python 3.8']
    @Carreau
    Copy link
    Mannequin Author

    Carreau mannequin commented May 12, 2019

    Deprecation message in timemodule.c says:

    "time.clock has been deprecated in Python 3.3 and will be removed from Python 3.8: use time.perf_counter or time.process_time instead"

    Should be bumped to 3.9 – or time.clock should be removed.

    Deprecation was added by Victor Stinner.

    @Carreau Carreau mannequin added 3.8 only security fixes stdlib Python modules in the Lib dir labels May 12, 2019
    @Carreau
    Copy link
    Mannequin Author

    Carreau mannequin commented May 12, 2019

    Vstiner, added you as you added the deprecation notice. I'm happy to take care of the removal and/or update the deprecation warning to 3.9.

    @gpshead
    Copy link
    Member

    gpshead commented May 13, 2019

    New changeset e250061 by Gregory P. Smith (Matthias Bussonnier) in branch 'master':
    bpo-36895: remove time.clock() as per removal notice. (GH-13270)
    e250061

    @gpshead
    Copy link
    Member

    gpshead commented May 13, 2019

    I saw the PR before the bug comment. merged. if we find a _good_ reason to delay this removal a cycle during the 3.8 betas we can bring it back.

    thanks for staying on top of the removal plan!

    @gpshead gpshead closed this as completed May 13, 2019
    @Carreau
    Copy link
    Mannequin Author

    Carreau mannequin commented May 13, 2019

    If we find a _good_ reason to delay this removal a cycle during the 3.8 betas we can bring it back.
    thanks for staying on top of the removal plan!

    Thanks to you for the quick integration; I'm happy if we need to bring it back, but at least having it removed during betas/alphas will nudge people toward updating their code.

    @vstinner
    Copy link
    Member

    I would prefer to remove time.clock() documentation if the function is removed.

    Would you mind to update Python 3.7 documentation to mention that the function is removed from Python 3.8?
    https://docs.python.org/3.7/library/time.html#time.clock

    In short, use ".. deprecated-removed:: 3.3 3.8 " in Python 3.7 doc.

    @vstinner vstinner reopened this May 13, 2019
    @tirkarthi
    Copy link
    Member

    Should this section also be updated about time.clock removal?

    https://docs.python.org/3.8/whatsnew/3.8.html#api-and-feature-removals

    @Carreau
    Copy link
    Mannequin Author

    Carreau mannequin commented May 13, 2019

    Done:

    • 1 PR against master to remove the documentation and update api-and-feature-removals
    • and one against 3.7 to add the deprecated-removed.

    @vstinner
    Copy link
    Member

    New changeset 24482bd by Victor Stinner (Matthias Bussonnier) in branch '3.7':
    [3.7] bpo-36895: document time.clock() has been removed in 3.8 (GH-13287)
    24482bd

    @vstinner
    Copy link
    Member

    New changeset b6a09ae by Victor Stinner (Matthias Bussonnier) in branch 'master':
    bpo-36895: Undocument removed time.clock (GH-13286)
    b6a09ae

    @vstinner
    Copy link
    Member

    time.clock() marked for removal in 3.8 – still there.

    Nope, it's now gone :-) I close the issue.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.8 only security fixes stdlib Python modules in the Lib dir
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    3 participants
    @gpshead @vstinner @tirkarthi