Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modules/faulthandler.c does not compile on HP-UX due to bpo-35214/1584a0081500d35dc93ff88e5836df35faf3e3e2 #80915

Closed
michael-o mannequin opened this issue Apr 26, 2019 · 8 comments
Labels
3.8 only security fixes build The build process and cross-build

Comments

@michael-o
Copy link
Mannequin

michael-o mannequin commented Apr 26, 2019

BPO 36734
Nosy @gpshead, @vstinner, @miss-islington, @michael-o
PRs
  • bpo-36734: Fix compilation of faulthandler.c on HP-UX #12970
  • [3.7] bpo-36734: Fix compilation of faulthandler.c on HP-UX (GH-12970) #13027
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2019-04-30.22:00:06.947>
    created_at = <Date 2019-04-26.11:29:08.393>
    labels = ['build', '3.8']
    title = 'Modules/faulthandler.c does not compile on HP-UX due to bpo-35214/1584a0081500d35dc93ff88e5836df35faf3e3e2'
    updated_at = <Date 2019-04-30.22:00:06.946>
    user = 'https://github.com/michael-o'

    bugs.python.org fields:

    activity = <Date 2019-04-30.22:00:06.946>
    actor = 'vstinner'
    assignee = 'none'
    closed = True
    closed_date = <Date 2019-04-30.22:00:06.947>
    closer = 'vstinner'
    components = ['Build']
    creation = <Date 2019-04-26.11:29:08.393>
    creator = 'michael-o'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 36734
    keywords = ['patch']
    message_count = 8.0
    messages = ['340913', '340922', '341142', '341143', '341144', '341147', '341164', '341165']
    nosy_count = 4.0
    nosy_names = ['gregory.p.smith', 'vstinner', 'miss-islington', 'michael-o']
    pr_nums = ['12970', '13027']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'compile error'
    url = 'https://bugs.python.org/issue36734'
    versions = ['Python 3.8']

    @michael-o
    Copy link
    Mannequin Author

    michael-o mannequin commented Apr 26, 2019

    /opt/aCC/bin/aCC -Ae -O -I./Include/internal -I. -I./Include -I/opt/ports/include -I/opt/ports/include -DPy_BUILD_CORE_BUILTIN -c ./Modules/faulthandler.c -o Modules/faulthandler.o
    "./Modules/faulthandler.c", line 1373: error bpo-2029: expected an expression
    stack_t current_stack = {};

    The fix is trivial:

    stack_t current_stack = {0};

    Can also provide a PR for that.

    @michael-o michael-o mannequin added 3.8 only security fixes build The build process and cross-build labels Apr 26, 2019
    @vstinner
    Copy link
    Member

    Michael Osipov: Can you please try if attached PR 12970 fix the compilation on HP-UX?

    @michael-o
    Copy link
    Mannequin Author

    michael-o mannequin commented Apr 30, 2019

    The memset() works as expected and compiles for me.

    @vstinner
    Copy link
    Member

    New changeset b84cb70 by Victor Stinner in branch 'master':
    bpo-36734: Fix compilation of faulthandler.c on HP-UX (GH-12970)
    b84cb70

    @vstinner
    Copy link
    Member

    Thanks for testing, I merged my PR. Does Python 3.7 have the same issue?

    @michael-o
    Copy link
    Mannequin Author

    michael-o mannequin commented Apr 30, 2019

    I do not know because I haven't really tested that branch. My HP-UX PRs (https://github.com/python/cpython/pulls/michael-o) are still open and apply to master currently. We (you and me) agreed some time ago, that we go master first.

    @miss-islington
    Copy link
    Contributor

    New changeset 5f5b187 by Miss Islington (bot) in branch '3.7':
    bpo-36734: Fix compilation of faulthandler.c on HP-UX (GH-12970)
    5f5b187

    @vstinner
    Copy link
    Member

    Python 3.7 was also affected: I fixed it as well. Thanks for your bug report.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.8 only security fixes build The build process and cross-build
    Projects
    None yet
    Development

    No branches or pull requests

    2 participants