Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

regrtest --findleaks should fail if an uncollectable object is found #80900

Closed
vstinner opened this issue Apr 25, 2019 · 10 comments
Closed

regrtest --findleaks should fail if an uncollectable object is found #80900

vstinner opened this issue Apr 25, 2019 · 10 comments
Labels
3.8 only security fixes tests Tests in the Lib/test dir

Comments

@vstinner
Copy link
Member

BPO 36719
Nosy @vstinner, @miss-islington
PRs
  • bpo-36719: regrtest findleaks fail on uncollectable object #12951
  • bpo-36719: Fix regrtest re-run #12964
  • bpo-36719: regrtest closes explicitly WindowsLoadTracker #12965
  • [3.7] bpo-36719: sync regrtest with master branch #12967
  • bpo-36719: regrtest -jN no longer stops on crash #13231
  • [3.7] bpo-36719: regrtest -jN no longer stops on crash (GH-13231) #13291
  • bpo-36719: Fix regrtest MultiprocessThread #13301
  • [3.7] bpo-36719: Fix regrtest MultiprocessThread (GH-13301) #13303
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2019-04-27.07:45:19.624>
created_at = <Date 2019-04-25.14:49:40.612>
labels = ['3.8', 'tests']
title = 'regrtest --findleaks should fail if an uncollectable object is found'
updated_at = <Date 2019-05-14.12:12:52.411>
user = 'https://github.com/vstinner'

    bugs.python.org fields:

    activity = <Date 2019-05-14.12:12:52.411>
actor = 'vstinner'
assignee = 'none'
closed = True
closed_date = <Date 2019-04-27.07:45:19.624>
closer = 'vstinner'
components = ['Tests']
creation = <Date 2019-04-25.14:49:40.612>
creator = 'vstinner'
dependencies = []
files = []
hgrepos = []
issue_num = 36719
keywords = ['patch']
message_count = 10.0
messages = ['340843', '340886', '340887', '340893', '340897', '340899', '342364', '342369', '342414', '342454']
nosy_count = 2.0
nosy_names = ['vstinner', 'miss-islington']
pr_nums = ['12951', '12964', '12965', '12967', '13231', '13291', '13301', '13303']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue36719'
versions = ['Python 3.8']
    @vstinner
    Copy link
    Member Author

    regrtest (python3 -m test) has a --findleaks option to log warning if the garbage collector finds uncollectable objects. Problem: regrtest only logs a warning, but exit with a success in that case.

    Attached PR makes regrtest fail in that case and adds an unit test for --findleaks.

    @vstinner vstinner added 3.8 only security fixes tests Tests in the Lib/test dir labels Apr 25, 2019
    @vstinner
    Copy link
    Member Author

    New changeset 75120d2 by Victor Stinner in branch 'master':
    bpo-36719: regrtest always detect uncollectable objects (GH-12951)
    75120d2

    @vstinner
    Copy link
    Member Author

    Oops, I used the wrong bpo number in my PR 12960 and PR 12961:

    New changeset 4d29983 by Victor Stinner in branch 'master':
    bpo-36725: regrtest: add TestResult type (GH-12960)
    4d29983

    New changeset 3cde440 by Victor Stinner in branch 'master':
    bpo-36725: Refactor regrtest multiprocessing code (GH-12961)
    3cde440

    @vstinner
    Copy link
    Member Author

    New changeset 837acc1 by Victor Stinner in branch 'master':
    bpo-36719: Fix regrtest re-run (GH-12964)
    837acc1

    @vstinner
    Copy link
    Member Author

    New changeset 00db7c7 by Victor Stinner in branch 'master':
    bpo-36719: regrtest closes explicitly WindowsLoadTracker (GH-12965)
    00db7c7

    @vstinner
    Copy link
    Member Author

    New changeset 1069d38 by Victor Stinner in branch '3.7':
    [3.7] bpo-36719: sync regrtest with master branch (GH-12967)
    1069d38

    @vstinner
    Copy link
    Member Author

    New changeset b0917df by Victor Stinner in branch 'master':
    bpo-36719: regrtest -jN no longer stops on crash (GH-13231)
    b0917df

    @miss-islington
    Copy link
    Contributor

    New changeset 19464bc by Miss Islington (bot) in branch '3.7':
    bpo-36719: regrtest -jN no longer stops on crash (GH-13231)
    19464bc

    @vstinner
    Copy link
    Member Author

    New changeset c923c34 by Victor Stinner in branch 'master':
    bpo-36719: Fix regrtest MultiprocessThread (GH-13301)
    c923c34

    @vstinner
    Copy link
    Member Author

    New changeset d8e123a by Victor Stinner (Miss Islington (bot)) in branch '3.7':
    bpo-36719: Fix regrtest MultiprocessThread (GH-13301) (GH-13303)
    d8e123a

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.8 only security fixes tests Tests in the Lib/test dir
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @vstinner @miss-islington