Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows Store app install registry keys have incorrect paths #80830

Closed
HuguesValois mannequin opened this issue Apr 17, 2019 · 6 comments
Closed

Windows Store app install registry keys have incorrect paths #80830

HuguesValois mannequin opened this issue Apr 17, 2019 · 6 comments
Assignees
Labels
3.7 (EOL) end of life 3.8 only security fixes 3.9 only security fixes OS-windows topic-installation type-bug An unexpected behavior, bug, or error

Comments

@HuguesValois
Copy link
Mannequin

HuguesValois mannequin commented Apr 17, 2019

BPO 36649
Nosy @pfmoore, @tjguk, @zware, @zooba, @miss-islington
PRs
  • bpo-36649: Remove trailing spaces for registry keys when installed via the Store #12865
  • [3.7] bpo-36649: Remove trailing spaces for registry keys when installed via the Store (GH-12865) #12867
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/zooba'
    closed_at = <Date 2019-04-18.15:39:11.906>
    created_at = <Date 2019-04-17.18:30:48.336>
    labels = ['type-bug', 'expert-installation', '3.9', '3.8', '3.7', 'OS-windows']
    title = 'Windows Store app install registry keys have incorrect paths'
    updated_at = <Date 2019-04-18.15:39:11.905>
    user = 'https://bugs.python.org/HuguesValois'

    bugs.python.org fields:

    activity = <Date 2019-04-18.15:39:11.905>
    actor = 'steve.dower'
    assignee = 'steve.dower'
    closed = True
    closed_date = <Date 2019-04-18.15:39:11.906>
    closer = 'steve.dower'
    components = ['Installation', 'Windows']
    creation = <Date 2019-04-17.18:30:48.336>
    creator = 'Hugues Valois'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 36649
    keywords = ['patch']
    message_count = 6.0
    messages = ['340426', '340427', '340435', '340441', '340449', '340450']
    nosy_count = 6.0
    nosy_names = ['paul.moore', 'tim.golden', 'zach.ware', 'steve.dower', 'miss-islington', 'Hugues Valois']
    pr_nums = ['12865', '12867']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'behavior'
    url = 'https://bugs.python.org/issue36649'
    versions = ['Python 3.7', 'Python 3.8', 'Python 3.9']

    @HuguesValois
    Copy link
    Mannequin Author

    HuguesValois mannequin commented Apr 17, 2019

    When reading registry values under HKCU\SOFTWARE\Python\PythonCore\3.7 that were written by the Windows Store app install, all file and folder paths are incorrect.

    Notice the extra [ ] as well as the missing backslash before python.exe and pythonw.exe

    Paths read from registry are:

    C:\Program Files\WindowsApps\PythonSoftwareFoundation.Python.3.7_3.7.1008.0_x64__qbz5n2kfra8p0[                    ]
    
    C:\Program Files\WindowsApps\PythonSoftwareFoundation.Python.3.7_3.7.1008.0_x64__qbz5n2kfra8p0python.exe[                    ]
    
    C:\Program Files\WindowsApps\PythonSoftwareFoundation.Python.3.7_3.7.1008.0_x64__qbz5n2kfra8p0pythonw.exe[                    ]
    
    

    Paths on disk are:

    C:\Program Files\WindowsApps\PythonSoftwareFoundation.Python.3.7_3.7.1008.0_x64__qbz5n2kfra8p0
    
    C:\Program Files\WindowsApps\PythonSoftwareFoundation.Python.3.7_3.7.1008.0_x64__qbz5n2kfra8p0\python.exe
    
    C:\Program Files\WindowsApps\PythonSoftwareFoundation.Python.3.7_3.7.1008.0_x64__qbz5n2kfra8p0\pythonw.exe
    

    @HuguesValois HuguesValois mannequin added 3.7 (EOL) end of life topic-installation OS-windows type-bug An unexpected behavior, bug, or error labels Apr 17, 2019
    @zooba
    Copy link
    Member

    zooba commented Apr 17, 2019

    Can you get me the *exact* Windows version number you're using?

    I added those to work around a bug where keys were being incorrectly trimmed, and that format seemed to evaluate to nothing correctly, but perhaps that bug has been fixed in the OS?

    @zooba zooba added 3.8 only security fixes 3.9 only security fixes labels Apr 17, 2019
    @zooba zooba self-assigned this Apr 17, 2019
    @HuguesValois
    Copy link
    Mannequin Author

    HuguesValois mannequin commented Apr 17, 2019

    C:\Users\huvalo>ver

    Microsoft Windows [Version 10.0.17763.437]

    @HuguesValois HuguesValois mannequin removed 3.8 only security fixes 3.9 only security fixes labels Apr 17, 2019
    @zooba
    Copy link
    Member

    zooba commented Apr 17, 2019

    Great, thanks.

    I have a fix in PR, but I'm going to do a "real" build to check. My machine is running a beta build, unfortunately, so I can't validate it against the older version. Might ping you for some help with that.

    @zooba zooba added 3.8 only security fixes 3.9 only security fixes labels Apr 17, 2019
    @zooba
    Copy link
    Member

    zooba commented Apr 17, 2019

    New changeset 4c3efd9 by Steve Dower in branch 'master':
    bpo-36649: Remove trailing spaces for registry keys when installed via the Store (GH-12865)
    4c3efd9

    @miss-islington
    Copy link
    Contributor

    New changeset 0d4f16d by Miss Islington (bot) in branch '3.7':
    bpo-36649: Remove trailing spaces for registry keys when installed via the Store (GH-12865)
    0d4f16d

    @zooba zooba closed this as completed Apr 18, 2019
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.7 (EOL) end of life 3.8 only security fixes 3.9 only security fixes OS-windows topic-installation type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Development

    No branches or pull requests

    2 participants