New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reference leaks in test_distutils #47910
Comments
Even after adding the current patch in http://bugs.python.org/issue3651 The current list is: test_unittest leaked [124, 124] references, sum=248 |
As of r66047, I get the following results (without "-uall", though): test_unittest leaked [124, 124] references, sum=248 24 tests skipped: |
|
Could you open a separate issue for the latter? Adding a DECREF in Oh, and I realize that memoryobject doesn't have tp_traverse and tp_clear, which |
bpo-3712 tracks the memoryview issues. |
the leaks in test_pickle and test_pickletools are corrected by the |
Amaury, I believe the first part of encode-leak.patch is wrong, you |
Oops, you are right of course. |
With the two patches applied, we are now at: test_unittest leaked [124, 124] references, sum=248 24 tests skipped: |
Did you look at the patch for bpo-3667 ? it should at least correct |
Ok, after the two patches plus the patch in bpo-3667, I get the following: test_asyncore leaked [84, -84] references, sum=0 |
The patch for _pickle has been committed in r66227. |
Numbers for the current py3k branch (without encode-leak2.patch): test_distutils leaked [141, 142] references, sum=283 |
The only one that is probably an issue based on Antoine's info is: test_unicode leaked [1, 1] references, sum=2 I've seen test_urllib2_localnet leak 3 before. I don't know that it's |
FWIW, applying encode-leak2.patch removes the leak in test_unicode. |
Antoine, it seem that with encode-leak2.patch, the error path after I rewrote the whole paragraph to make it more straightforward:
I find the code much easier to check in this form, but of course this is |
Le vendredi 05 septembre 2008 à 13:08 +0000, Amaury Forgeot d'Arc a
Hmm, you are right.
I'll take a look! |
Amaury, your patch is much clearer indeed and it fixes the leak. |
encode-leak3.patch applied in r66234. |
Current status: test_distutils leaked [141, 142] references, sum=283 The distutils leak should be investigated, but the overall situation is |
test_distutils is also leaking the the trunk: test_distutils leaked [144, 144, 144, 144] references, sum=576 |
test_distutils will be difficult; the leak is around the "import xx" in And Python/import.c says: This dictionary keeps growing with random filenames in the temp |
If it's just that (one leaked string per each extension module import), |
It's not only the name, but a copy of the whole module dict just after Actually I found a (hackish) way to clean the 'extension' dict, but this |
Ow.
I'd prefer not. If we hide this leak, we'll end up forgetting about its |
With the new module structure in 3.0, it should be possible to add a |
This issue has been fixed. |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
bugs.python.org fields:
The text was updated successfully, but these errors were encountered: