Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use _PyTime_GetPerfCounter() in lsprof #80756

Closed
methane opened this issue Apr 9, 2019 · 2 comments
Closed

Use _PyTime_GetPerfCounter() in lsprof #80756

methane opened this issue Apr 9, 2019 · 2 comments
Labels
3.8 only security fixes stdlib Python modules in the Lib dir

Comments

@methane
Copy link
Member

methane commented Apr 9, 2019

BPO 36575
Nosy @vstinner, @methane
PRs
  • bpo-36575: lsprof: Use _PyTime_GetPerfCounter() #8378
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2019-04-11.10:12:13.367>
created_at = <Date 2019-04-09.13:35:46.376>
labels = ['3.8', 'library']
title = 'Use _PyTime_GetPerfCounter() in lsprof'
updated_at = <Date 2019-04-11.10:12:13.366>
user = 'https://github.com/methane'

    bugs.python.org fields:

    activity = <Date 2019-04-11.10:12:13.366>
actor = 'methane'
assignee = 'none'
closed = True
closed_date = <Date 2019-04-11.10:12:13.367>
closer = 'methane'
components = ['Library (Lib)']
creation = <Date 2019-04-09.13:35:46.376>
creator = 'methane'
dependencies = []
files = []
hgrepos = []
issue_num = 36575
keywords = ['patch']
message_count = 2.0
messages = ['339747', '339953']
nosy_count = 2.0
nosy_names = ['vstinner', 'methane']
pr_nums = ['8378']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue36575'
versions = ['Python 3.8']
    @methane
    Copy link
    Member Author

    methane commented Apr 9, 2019

    Current lsprof uses gettimeofday on non-Windows.
    _PyTime_GetPerfCounter() is better time for profiling.

    @methane methane added 3.8 only security fixes stdlib Python modules in the Lib dir labels Apr 9, 2019
    @methane
    Copy link
    Member Author

    methane commented Apr 11, 2019

    New changeset 536a35b by Inada Naoki in branch 'master':
    bpo-36575: lsprof: Use _PyTime_GetPerfCounter() (GH-8378)
    536a35b

    @methane methane closed this as completed Apr 11, 2019
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.8 only security fixes stdlib Python modules in the Lib dir
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    1 participant
    @methane