Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "regen-*" equivalent projects for Windows builds #80681

Closed
tonybaloney mannequin opened this issue Apr 2, 2019 · 5 comments
Closed

Add "regen-*" equivalent projects for Windows builds #80681

tonybaloney mannequin opened this issue Apr 2, 2019 · 5 comments
Assignees
@tonybaloney
Labels
3.9 only security fixes build The build process and cross-build

Comments

@tonybaloney
Copy link
Mannequin

tonybaloney mannequin commented Apr 2, 2019

BPO 36500
Nosy @brettcannon, @zooba, @tonybaloney, @pablogsal, @tonybaloney
PRs
  • bpo-36500: Enable Windows users to regen grammar, opcodes, tokens and symbols from Visual Studio #12654
  • bpo-36500: Simplify PCbuild/build.bat and prevent path separator changing in comments #17644
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/tonybaloney'
closed_at = <Date 2019-12-17.22:14:36.854>
created_at = <Date 2019-04-02.00:13:34.351>
labels = ['build', '3.9']
title = 'Add "regen-*" equivalent projects for Windows builds'
updated_at = <Date 2019-12-17.22:14:36.852>
user = 'https://github.com/tonybaloney'

    bugs.python.org fields:

    activity = <Date 2019-12-17.22:14:36.852>
actor = 'steve.dower'
assignee = 'anthonypjshaw'
closed = True
closed_date = <Date 2019-12-17.22:14:36.854>
closer = 'steve.dower'
components = ['Build']
creation = <Date 2019-04-02.00:13:34.351>
creator = 'anthony shaw'
dependencies = []
files = []
hgrepos = []
issue_num = 36500
keywords = ['patch']
message_count = 5.0
messages = ['339309', '339310', '358580', '358586', '358592']
nosy_count = 5.0
nosy_names = ['brett.cannon', 'steve.dower', 'anthonypjshaw', 'pablogsal', 'anthony shaw']
pr_nums = ['12654', '17644']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue36500'
versions = ['Python 3.9']
    @tonybaloney
    Copy link
    Mannequin Author

    tonybaloney mannequin commented Apr 2, 2019

    Now that pgen is written in Python, it'd be useful for Windows users to be able to rebuild grammar and tokens into the parser table.

    The current hook (make regen-grammar) is built into the Makefile.

    Add support for VS2017+ vcxproj files to call the script directly

    @tonybaloney tonybaloney mannequin added 3.8 only security fixes build The build process and cross-build labels Apr 2, 2019
    @tonybaloney
    Copy link
    Mannequin Author

    tonybaloney mannequin commented Apr 2, 2019

    Project now also does:
    regen-symbol (regenerate Lib/symbol.py)
    and regen-keyword (regenerate Lib/keyword.py)

    @tonybaloney tonybaloney mannequin self-assigned this May 9, 2019
    @zooba
    Copy link
    Member

    zooba commented Dec 17, 2019

    New changeset 9e36589 by Steve Dower (Anthony Shaw) in branch 'master':
    bpo-36500: Add --regen option to PCbuild/build.bat so Windows users can regen grammar, opcodes, tokens and symbols (GH-12654)
    9e36589

    @zooba
    Copy link
    Member

    zooba commented Dec 17, 2019

    Adding just a couple of minor touch-ups in PR 17644, but otherwise thanks Anthony!

    @zooba
    Copy link
    Member

    zooba commented Dec 17, 2019

    New changeset a9d0a6a by Steve Dower in branch 'master':
    bpo-36500: Simplify PCbuild/build.bat and prevent path separator changing in comments (GH-17644)
    a9d0a6a

    @zooba zooba added 3.9 only security fixes and removed 3.8 only security fixes labels Dec 17, 2019
    @zooba zooba closed this as completed Dec 17, 2019
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @tonybaloney tonybaloney

    Labels
    3.9 only security fixes build The build process and cross-build
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    1 participant
    @zooba