Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

urlparse - relative url parsing and joins to be RFC3986 compliance #47897

Open
orsenthil opened this issue Aug 22, 2008 · 6 comments
Open

urlparse - relative url parsing and joins to be RFC3986 compliance #47897

orsenthil opened this issue Aug 22, 2008 · 6 comments
Assignees
@orsenthil
Labels
stdlib Python modules in the Lib dir type-feature A feature request or enhancement

Comments

@orsenthil
Copy link
Member

BPO 3647
Nosy @gpshead, @orsenthil, @vadmium
Files
  • urlparse_rfc3986-py26.diff
  • urlparse_rfc3986-py3k.diff
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/orsenthil'
closed_at = None
created_at = <Date 2008-08-22.12:54:33.965>
labels = ['type-feature', 'library']
title = 'urlparse - relative url parsing and joins to be RFC3986 compliance'
updated_at = <Date 2015-02-09.00:10:27.387>
user = 'https://github.com/orsenthil'

    bugs.python.org fields:

    activity = <Date 2015-02-09.00:10:27.387>
actor = 'martin.panter'
assignee = 'orsenthil'
closed = False
closed_date = None
closer = None
components = ['Library (Lib)']
creation = <Date 2008-08-22.12:54:33.965>
creator = 'orsenthil'
dependencies = []
files = ['11208', '11209']
hgrepos = []
issue_num = 3647
keywords = ['patch']
message_count = 6.0
messages = ['71743', '72067', '74851', '74852', '74856', '109962']
nosy_count = 4.0
nosy_names = ['gregory.p.smith', 'jjlee', 'orsenthil', 'martin.panter']
pr_nums = []
priority = 'normal'
resolution = None
stage = None
status = 'open'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue3647'
versions = ['Python 3.4', 'Python 3.5']
    @orsenthil
    Copy link
    Member Author

    Attaching two patches to make the current urlparse library, especially
    the relative url parsing and urljoin to be RFC3986 compliance.
    I have included all the tests prescribed in RFC3986 and verified them
    to pass with the patches.

    Our parsing functionality of netloc (to
    username,password,hostname,port) is same as what RFC3986 specifies. It
    uses the term 'authority' instead of 'netloc'. I did not feel the need
    for name change. If required, it can done.

    @orsenthil orsenthil added the stdlib Python modules in the Lib dir label Aug 22, 2008
    @gpshead
    Copy link
    Member

    gpshead commented Aug 28, 2008

    given where we are in the release process at the moment I doubt this can
    go into 2.6/3.0. Bring it up on python-dev if you have compelling
    reasons why it should.

    Otherwise, looks good for trunk 2.7/3.1 immediately after the releases
    are branched.

    @gpshead gpshead self-assigned this Aug 28, 2008
    @gpshead gpshead added the type-feature A feature request or enhancement label Aug 28, 2008
    @jjlee
    Copy link
    Mannequin

    jjlee mannequin commented Oct 16, 2008

    There are a bunch of other candidate implementations of this RFC kicking
    around, I think.

    Also, I believe there was agreement on python-dev that a new module
    should be added rather than changing the behaviour of module urlparse.

    @jjlee
    Copy link
    Mannequin

    jjlee mannequin commented Oct 16, 2008

    Here they are:

    http://bugs.python.org/issue1500504
    http://bugs.python.org/issue1462525
    http://bugs.python.org/issue1591035

    @jjlee
    Copy link
    Mannequin

    jjlee mannequin commented Oct 16, 2008

    Hmm, I see you've already commented on some of those, Senthil. Perhaps
    you could add a comment to this bug explaining how your patch relates to
    the others. Should it replace them? (why?) Should one of those patches
    be applied also?

    Also, my comment about there being agreement on python-dev is probably a
    misrepresentation. This is what I remembered, I think:

    http://article.gmane.org/gmane.comp.python.devel/73314/

    which seems to say that a new API should be added, but not that urlparse
    shouldn't be changed to be more compliant with RFC 3986.

    @orsenthil
    Copy link
    Member Author

    Several changes were already made to urlparse to make it more rfc3986 compliant. Let me recollect what else these patches offer.

    @orsenthil orsenthil assigned orsenthil and unassigned gpshead Jul 11, 2010
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @orsenthil orsenthil

    Labels
    stdlib Python modules in the Lib dir type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @gpshead @orsenthil