Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IDLE autocomplete: refactor and polish code and tests #80600

Closed
terryjreedy opened this issue Mar 24, 2019 · 5 comments
Closed

IDLE autocomplete: refactor and polish code and tests #80600

terryjreedy opened this issue Mar 24, 2019 · 5 comments
Assignees
@terryjreedy
Labels
3.7 (EOL) end of life 3.8 only security fixes 3.9 only security fixes topic-IDLE type-feature A feature request or enhancement

Comments

@terryjreedy
Copy link
Member

BPO 36419
Nosy @terryjreedy, @miss-islington
PRs
  • bpo-36419: IDLE - Refactor autocompete and improve testing. #15121
  • [3.8] bpo-36419: IDLE - Refactor autocompete and improve testing. (GH-15121) #15123
  • [3.7] bpo-36419: IDLE - Refactor autocompete and improve testing. (GH-15121) #15124
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/terryjreedy'
closed_at = <Date 2019-08-05.01:09:57.898>
created_at = <Date 2019-03-24.23:11:25.859>
labels = ['3.8', 'expert-IDLE', 'type-feature', '3.7', '3.9']
title = 'IDLE autocomplete: refactor and polish code and tests'
updated_at = <Date 2019-08-05.01:09:57.893>
user = 'https://github.com/terryjreedy'

    bugs.python.org fields:

    activity = <Date 2019-08-05.01:09:57.893>
actor = 'terry.reedy'
assignee = 'terry.reedy'
closed = True
closed_date = <Date 2019-08-05.01:09:57.898>
closer = 'terry.reedy'
components = ['IDLE']
creation = <Date 2019-03-24.23:11:25.859>
creator = 'terry.reedy'
dependencies = []
files = []
hgrepos = []
issue_num = 36419
keywords = ['patch']
message_count = 5.0
messages = ['338766', '349008', '349009', '349010', '349015']
nosy_count = 2.0
nosy_names = ['terry.reedy', 'miss-islington']
pr_nums = ['15121', '15123', '15124']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue36419'
versions = ['Python 3.7', 'Python 3.8', 'Python 3.9']
    @terryjreedy
    Copy link
    Member Author

    Followup to bpo-30348.

    1. Merge try_open_completions_event and _open_completions_later. The latter is only used in the former. Adjust tests to match.
    2. The following in test_open_completions tests >>> "something<tab>
    self.text.insert('1.0', '"t')
    self.assertTrue(self.autocomplete.open_completions(False, True, True))
This passes with unittest (py -m test.test_idle) but fails with regrtest (py -m test -ugui test_idle), with "None is not true".  There are multiple 'return None's in open_completions.  Determine which with debug prints and try to pass with regrtest.  Success does not depend on the inserted text matching any file in the current working directory.
    1. Increase coverage. Multiple conditionals are only triggered 1 way.

    @terryjreedy terryjreedy added 3.7 (EOL) end of life 3.8 only security fixes labels Mar 24, 2019
    @terryjreedy terryjreedy self-assigned this Mar 24, 2019
    @terryjreedy terryjreedy added topic-IDLE type-feature A feature request or enhancement labels Mar 24, 2019
    @terryjreedy
    Copy link
    Member Author

    New changeset 1213123 by Terry Jan Reedy in branch 'master':
    bpo-36419: IDLE - Refactor autocompete and improve testing. (bpo-15121)
    1213123

    @miss-islington
    Copy link
    Contributor

    New changeset 5349f8c by Miss Islington (bot) in branch '3.8':
    bpo-36419: IDLE - Refactor autocompete and improve testing. (GH-15121)
    5349f8c

    @miss-islington
    Copy link
    Contributor

    New changeset 4969192 by Miss Islington (bot) in branch '3.7':
    bpo-36419: IDLE - Refactor autocompete and improve testing. (GH-15121)
    4969192

    @terryjreedy
    Copy link
    Member Author

    All three goals done. Most or all of the 7% not covered is the part of the file I did not touch.

    @terryjreedy terryjreedy added the 3.9 only security fixes label Aug 5, 2019
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @terryjreedy terryjreedy

    Labels
    3.7 (EOL) end of life 3.8 only security fixes 3.9 only security fixes topic-IDLE type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @terryjreedy @miss-islington