Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plistlib old API should be removed #80590

Closed
Bigfootjon mannequin opened this issue Mar 23, 2019 · 5 comments
Closed

plistlib old API should be removed #80590

Bigfootjon mannequin opened this issue Mar 23, 2019 · 5 comments
Labels
3.9 only security fixes OS-mac stdlib Python modules in the Lib dir

Comments

@Bigfootjon
Copy link
Mannequin

Bigfootjon mannequin commented Mar 23, 2019

BPO 36409
Nosy @ronaldoussoren, @ned-deily, @serhiy-storchaka, @bigfootjon
PRs
  • bpo-36409: Remove old plistlib API deprecated in 3.4 #12515
  • bpo-36409: Remove old plistlib API deprecated in 3.4 #15615
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2019-09-05.13:37:57.279>
created_at = <Date 2019-03-23.16:11:49.750>
labels = ['OS-mac', 'library', '3.9']
title = 'plistlib old API should be removed'
updated_at = <Date 2019-09-05.13:37:57.279>
user = 'https://github.com/Bigfootjon'

    bugs.python.org fields:

    activity = <Date 2019-09-05.13:37:57.279>
actor = 'bigfootjon'
assignee = 'none'
closed = True
closed_date = <Date 2019-09-05.13:37:57.279>
closer = 'bigfootjon'
components = ['Library (Lib)', 'macOS']
creation = <Date 2019-03-23.16:11:49.750>
creator = 'bigfootjon'
dependencies = []
files = []
hgrepos = []
issue_num = 36409
keywords = ['patch']
message_count = 5.0
messages = ['338683', '338793', '338882', '338890', '351191']
nosy_count = 4.0
nosy_names = ['ronaldoussoren', 'ned.deily', 'serhiy.storchaka', 'bigfootjon']
pr_nums = ['12515', '15615']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue36409'
versions = ['Python 3.9']
    @Bigfootjon
    Copy link
    Mannequin Author

    Bigfootjon mannequin commented Mar 23, 2019

    Per the documentation and in-line code warnings, the old API for plistlib was deprecated in version 3.4. My understanding is that deprecated functionality is to be removed in the next major version, so this code is long overdue for removal.

    @Bigfootjon Bigfootjon mannequin added 3.8 only security fixes stdlib Python modules in the Lib dir labels Mar 23, 2019
    @serhiy-storchaka
    Copy link
    Member

    It was preserved for compatibility with Python 2.7. From PEP-4:

    "In order to facilitate writing code that works in both Python 2 & 3 simultaneously, any module that exists in both Python 3.5 and Python 2.7 will not be removed from the standard library until Python 2.7 is no longer supported as specified by PEP-373."

    3.9 will be the first Python 3 release after the EOL of 2.7.

    @Bigfootjon
    Copy link
    Mannequin Author

    Bigfootjon mannequin commented Mar 26, 2019

    Ah, I misinterpreted PEP-4. I thought it only applied to modules as a whole (e.g. plistlib) rather than individual functionality within that module. I'll close my PR and wait until 3.9 is accepting patches

    @Bigfootjon Bigfootjon mannequin added 3.9 only security fixes and removed 3.8 only security fixes labels Mar 26, 2019
    @serhiy-storchaka
    Copy link
    Member

    Yes, this is mainly about modules, but in general we try to be more careful with removing features that do not have alternatives in 2.7. In this particular case, the benefit from removing the deprecated functions in 3.8 instead of 3.9 is small, but this will make harder writing 2+3 compatible code.

    In any case this is on to the module maintainer, Ronald.

    @ronaldoussoren
    Copy link
    Contributor

    New changeset ce81a92 by Ronald Oussoren (Jon Janzen) in branch 'master':
    bpo-36409: Remove old plistlib API deprecated in 3.4 (GH-15615)
    ce81a92

    @Bigfootjon Bigfootjon mannequin closed this as completed Sep 5, 2019
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.9 only security fixes OS-mac stdlib Python modules in the Lib dir
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    3 participants
    @ronaldoussoren @serhiy-storchaka @tirkarthi