Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate "#" argument format without PY_SSIZE_T_CLEAN #80562

Closed
methane opened this issue Mar 20, 2019 · 3 comments
Closed

Deprecate "#" argument format without PY_SSIZE_T_CLEAN #80562

methane opened this issue Mar 20, 2019 · 3 comments
Labels
3.8 only security fixes extension-modules C modules in the Modules dir

Comments

@methane
Copy link
Member

methane commented Mar 20, 2019

BPO 36381
Nosy @vstinner, @methane, @serhiy-storchaka
PRs
  • bpo-36381: warn when no PY_SSIZE_T_CLEAN #12473
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2019-03-23.12:05:28.410>
created_at = <Date 2019-03-20.12:58:55.958>
labels = ['extension-modules', '3.8']
title = 'Deprecate "#" argument format without PY_SSIZE_T_CLEAN'
updated_at = <Date 2019-03-23.12:05:28.409>
user = 'https://github.com/methane'

    bugs.python.org fields:

    activity = <Date 2019-03-23.12:05:28.409>
actor = 'methane'
assignee = 'none'
closed = True
closed_date = <Date 2019-03-23.12:05:28.410>
closer = 'methane'
components = ['Extension Modules']
creation = <Date 2019-03-20.12:58:55.958>
creator = 'methane'
dependencies = []
files = []
hgrepos = []
issue_num = 36381
keywords = ['patch']
message_count = 3.0
messages = ['338466', '338474', '338672']
nosy_count = 3.0
nosy_names = ['vstinner', 'methane', 'serhiy.storchaka']
pr_nums = ['12473']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue36381'
versions = ['Python 3.8']
    @methane
    Copy link
    Member Author

    methane commented Mar 20, 2019

    Raise warning for # use without PY_SSIZE_T_CLEAN.

    • 3.8: PendingDeprecationWarning
    • 3.9: DeprecationWarning
    • 3.10 (or 4.0): Remove PY_SSIZE_T_CLEAN and use Py_ssize_t always

    @methane methane added 3.8 only security fixes extension-modules C modules in the Modules dir labels Mar 20, 2019
    @vstinner
    Copy link
    Member

    • 3.8: PendingDeprecationWarning

    ... Or maybe use directly DeprecationWarning? :-)
    https://discuss.python.org/t/pendingdeprecationwarning-is-really-useful/1038

    @vstinner vstinner changed the title Preapre for mandatory PY_SSIZE_T_CLEAN Deprecate "#" argument format without PY_SSIZE_T_CLEAN Mar 20, 2019
    @methane
    Copy link
    Member Author

    methane commented Mar 23, 2019

    New changeset d3c72a2 by Inada Naoki in branch 'master':
    bpo-36381: warn when no PY_SSIZE_T_CLEAN defined (GH-12473)
    d3c72a2

    @methane methane closed this as completed Mar 23, 2019
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.8 only security fixes extension-modules C modules in the Modules dir
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @vstinner @methane