Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modules/getpath.c should not use hardcoded buffer sizes (MAXPATHLEN) #80533

Closed
vstinner opened this issue Mar 18, 2019 · 5 comments
Closed

Modules/getpath.c should not use hardcoded buffer sizes (MAXPATHLEN) #80533

vstinner opened this issue Mar 18, 2019 · 5 comments
Labels
3.8 only security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs)

Comments

@vstinner
Copy link
Member

BPO 36352
Nosy @vstinner
PRs
  • bpo-36352: Add error handling to getpath.c #12421
  • bpo-36352: Avoid hardcoded MAXPATHLEN size in getpath.c #12423
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2019-03-19.01:59:28.486>
created_at = <Date 2019-03-18.16:46:40.595>
labels = ['interpreter-core', '3.8']
title = 'Modules/getpath.c should not use hardcoded buffer sizes (MAXPATHLEN)'
updated_at = <Date 2019-03-19.01:59:28.486>
user = 'https://github.com/vstinner'

    bugs.python.org fields:

    activity = <Date 2019-03-19.01:59:28.486>
actor = 'vstinner'
assignee = 'none'
closed = True
closed_date = <Date 2019-03-19.01:59:28.486>
closer = 'vstinner'
components = ['Interpreter Core']
creation = <Date 2019-03-18.16:46:40.595>
creator = 'vstinner'
dependencies = []
files = []
hgrepos = []
issue_num = 36352
keywords = ['patch']
message_count = 5.0
messages = ['338255', '338256', '338295', '338309', '338310']
nosy_count = 1.0
nosy_names = ['vstinner']
pr_nums = ['12421', '12423']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue36352'
versions = ['Python 3.8']
    @vstinner
    Copy link
    Member Author

    I'm working on a change to avoid hardcoded buffer sizes (MAXPATHLEN) in Modules/getpath.c. This issue is a place holder to discuss it.

    @vstinner vstinner added 3.8 only security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) labels Mar 18, 2019
    @vstinner
    Copy link
    Member Author

    New changeset 1be0d11 by Victor Stinner in branch 'master':
    bpo-36352: Clarify fileutils.h documentation (GH-12406)
    1be0d11

    @vstinner
    Copy link
    Member Author

    New changeset 7b14f0c by Victor Stinner in branch 'master':
    bpo-36352: Add error handling to getpath.c (GH-12421)
    7b14f0c

    @vstinner
    Copy link
    Member Author

    New changeset faddaed by Victor Stinner in branch 'master':
    bpo-36352: Avoid hardcoded MAXPATHLEN size in getpath.c (GH-12423)
    faddaed

    @vstinner
    Copy link
    Member Author

    These changes are intrusive. I don't think that it's worth it to backport them to 3.7 (or 2.7). Just don't play with paths close to MAXPATHLEN bytes on Python 2.7 or 3.7 :-) I close the issue.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.8 only security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs)
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    1 participant
    @vstinner