Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_os: add tests for invalid uid type #80415

Closed
vstinner opened this issue Mar 8, 2019 · 6 comments
Closed

test_os: add tests for invalid uid type #80415

vstinner opened this issue Mar 8, 2019 · 6 comments
Labels
3.7 (EOL) end of life 3.8 only security fixes tests Tests in the Lib/test dir

Comments

@vstinner
Copy link
Member

vstinner commented Mar 8, 2019

BPO 36234
Nosy @vstinner, @miss-islington
PRs
  • bpo-36234: Add more tests to PosixUidGidTests #12234
  • [2.7] bpo-36234: test_os: check TypeError for invalid uid type #12235
  • [3.7] bpo-36234: Add more tests to PosixUidGidTests (GH-12234) #12274
    		•
    Files
  • 00157-uid-gid-overflows.patch
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2019-03-11.13:20:42.358>
created_at = <Date 2019-03-08.10:12:26.788>
labels = ['3.8', '3.7', 'tests']
title = 'test_os: add tests for invalid uid type'
updated_at = <Date 2019-03-11.13:20:42.358>
user = 'https://github.com/vstinner'

    bugs.python.org fields:

    activity = <Date 2019-03-11.13:20:42.358>
actor = 'vstinner'
assignee = 'none'
closed = True
closed_date = <Date 2019-03-11.13:20:42.358>
closer = 'vstinner'
components = ['Tests']
creation = <Date 2019-03-08.10:12:26.788>
creator = 'vstinner'
dependencies = []
files = ['48194']
hgrepos = []
issue_num = 36234
keywords = ['patch']
message_count = 6.0
messages = ['337464', '337465', '337663', '337664', '337665', '337666']
nosy_count = 2.0
nosy_names = ['vstinner', 'miss-islington']
pr_nums = ['12234', '12235', '12274']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue36234'
versions = ['Python 2.7', 'Python 3.7', 'Python 3.8']
    @vstinner
    Copy link
    Member Author

    vstinner commented Mar 8, 2019

    The Fedora package of python contains a downstream patch to add more tests for invalid uid types:
    https://src.fedoraproject.org/rpms/python2/blob/master/f/00157-uid-gid-overflows.patch

    I propose to make this patch upstream. More tests never hurts :-)

    uid/gid overflow has been fixed bpo-4591.

    The patch comes from:
    https://bugzilla.redhat.com/show_bug.cgi?id=697470

    Attached PRs add more tests.

    @vstinner vstinner added 3.7 (EOL) end of life 3.8 only security fixes tests Tests in the Lib/test dir labels Mar 8, 2019
    @vstinner
    Copy link
    Member Author

    vstinner commented Mar 8, 2019

    See _Py_Uid_Converter() and _Py_Gid_Converter() of Modules/posixmodule.c.

    @vstinner
    Copy link
    Member Author

    New changeset 876e82b by Victor Stinner in branch 'master':
    bpo-36234: Add more tests to PosixUidGidTests (GH-12234)
    876e82b

    @vstinner
    Copy link
    Member Author

    New changeset 701af60 by Victor Stinner in branch '2.7':
    bpo-36234: test_os: check TypeError for invalid uid type (GH-12235)
    701af60

    @miss-islington
    Copy link
    Contributor

    New changeset 24872e1 by Miss Islington (bot) in branch '3.7':
    bpo-36234: Add more tests to PosixUidGidTests (GH-12234)
    24872e1

    @vstinner
    Copy link
    Member Author

    Thanks David Malcolm :-)

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.7 (EOL) end of life 3.8 only security fixes tests Tests in the Lib/test dir
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @vstinner @miss-islington