Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_smtplib is flaky #47870

Closed
benjaminp opened this issue Aug 20, 2008 · 7 comments
Closed

test_smtplib is flaky #47870

benjaminp opened this issue Aug 20, 2008 · 7 comments
Labels
tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error

Comments

@benjaminp
Copy link
Contributor

BPO 3620
Nosy @pitrou, @giampaolo, @matejcik, @benjaminp, @bitdancer

Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2019-05-14.15:14:16.629>
created_at = <Date 2008-08-20.15:09:28.199>
labels = ['type-bug', 'tests']
title = 'test_smtplib is flaky'
updated_at = <Date 2019-05-14.15:14:16.628>
user = 'https://github.com/benjaminp'

bugs.python.org fields:

activity = <Date 2019-05-14.15:14:16.628>
actor = 'SilentGhost'
assignee = 'none'
closed = True
closed_date = <Date 2019-05-14.15:14:16.629>
closer = 'SilentGhost'
components = ['Tests']
creation = <Date 2008-08-20.15:09:28.199>
creator = 'benjamin.peterson'
dependencies = []
files = []
hgrepos = []
issue_num = 3620
keywords = ['buildbot']
message_count = 7.0
messages = ['71549', '71641', '104903', '104910', '105163', '120839', '221708']
nosy_count = 5.0
nosy_names = ['pitrou', 'giampaolo.rodola', 'matejcik', 'benjamin.peterson', 'r.david.murray']
pr_nums = []
priority = 'normal'
resolution = 'out of date'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue3620'
versions = ['Python 3.4', 'Python 3.5']

@benjaminp
Copy link
Contributor Author

This is from the sparc Unbuntu 3.0 bot. I'm having trouble reproducing
it, though.

test test_smtplib produced unexpected output:


*** line 2 of actual output doesn't appear in expected output after line 1:
+ error: uncaptured python exception, closing channel
<test.test_smtplib.SimSMTPChannel 127.0.0.1:38832 at 0x268d0a8> (<class
'socket.error'>:[Errno 9] Bad file descriptor
[/home/pybot/buildarea/3.0.klose-ubuntu-sparc/build/Lib/asyncore.py|readwrite|100]
[/home/pybot/buildarea/3.0.klose-ubuntu-sparc/build/Lib/asyncore.py|handle_write_event|426])


@benjaminp benjaminp added the tests Tests in the Lib/test dir label Aug 20, 2008
@pitrou
Copy link
Member

pitrou commented Aug 21, 2008

The failure happens even when test_smtplib runs before both
test_asyncore and test_asynchat (*). So the latter can't be the culprit.

(*)
http://www.python.org/dev/buildbot/3.0.stable/sparc%20Debian%203.0/builds/419/step-test/0

@pitrou pitrou changed the title test_asyncore is not cleanup after its self? test_smtplib is flaky Aug 21, 2008
@giampaolo
Copy link
Contributor

Adding this:

    def handle_error(self):
        raise

...to SimSMTPChannel class would help to provide a clearer error message to understand where exactly EBADF comes from, altough I think this was an old asyncore bug which have already been fixed.
Is this still reproducible on Python 3.2?

@bitdancer
Copy link
Member

If it would provide clearer error message in cases of failure, it sounds like a reasonable thing to add whether or not the failure in this issue is still happening.

@giampaolo
Copy link
Contributor

Done in r80882 for ftplib and smtplib modules.

@BreamoreBoy BreamoreBoy mannequin added the type-bug An unexpected behavior, bug, or error label Jul 13, 2010
@bitdancer
Copy link
Member

Looking back over the logs (via bbreport) I don't see any failures of test_smtplib that match the report in this issue. There were three in the last while, two of which look like network issues on the same machine (and thus probably not a test problem per se) and one of which (solaris) had multiple errors but succeeded when rerun immediately.

While there maybe a remaining flakiness issue with test_smtplib, it doesn't seem to be the error described here, and I don't think it rates critical.

@BreamoreBoy
Copy link
Mannequin

BreamoreBoy mannequin commented Jun 27, 2014

Can this be closed as "out of date"?

@SilentGhost SilentGhost mannequin closed this as completed May 14, 2019
@ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error
Projects
None yet
Development

No branches or pull requests

4 participants