Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.7] Coverity scan: Modules/linuxaudiodev.c , fd handle is not closed. #80367

Closed
stratakis mannequin opened this issue Mar 4, 2019 · 3 comments
Closed

[2.7] Coverity scan: Modules/linuxaudiodev.c , fd handle is not closed. #80367

stratakis mannequin opened this issue Mar 4, 2019 · 3 comments
Labels
extension-modules C modules in the Modules dir

Comments

@stratakis
Copy link
Mannequin

stratakis mannequin commented Mar 4, 2019

BPO 36186
Nosy @vstinner, @stratakis
PRs
  • [2.7] bpo-36186: Fix leak of handle in linuxaudiodev #12163
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2019-03-06.14:34:00.864>
created_at = <Date 2019-03-04.15:37:06.396>
labels = ['extension-modules']
title = '[2.7] Coverity scan: Modules/linuxaudiodev.c , fd handle is not closed.'
updated_at = <Date 2019-03-06.14:34:00.863>
user = 'https://github.com/stratakis'

    bugs.python.org fields:

    activity = <Date 2019-03-06.14:34:00.863>
actor = 'vstinner'
assignee = 'none'
closed = True
closed_date = <Date 2019-03-06.14:34:00.864>
closer = 'vstinner'
components = ['Extension Modules']
creation = <Date 2019-03-04.15:37:06.396>
creator = 'cstratak'
dependencies = []
files = []
hgrepos = []
issue_num = 36186
keywords = ['patch']
message_count = 3.0
messages = ['337131', '337302', '337304']
nosy_count = 2.0
nosy_names = ['vstinner', 'cstratak']
pr_nums = ['12163']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue36186'
versions = ['Python 2.7']
    @stratakis
    Copy link
    Mannequin Author

    stratakis mannequin commented Mar 4, 2019

    There are two places [0][1] in the code where NULL is returned but the fd handle is not closed.

    [0] https://github.com/python/cpython/blob/2.7/Modules/linuxaudiodev.c#L129
    [1] https://github.com/python/cpython/blob/2.7/Modules/linuxaudiodev.c#L133

    @stratakis stratakis mannequin added the extension-modules C modules in the Modules dir label Mar 4, 2019
    @vstinner
    Copy link
    Member

    vstinner commented Mar 6, 2019

    New changeset b2aefd7 by Victor Stinner (stratakis) in branch '2.7':
    [2.7] bpo-36186: Fix linuxaudiodev.linux_audio_device() error handling (GH-12163)
    b2aefd7

    @vstinner
    Copy link
    Member

    vstinner commented Mar 6, 2019

    Thanks Charalampos Stratakis!

    @vstinner vstinner closed this as completed Mar 6, 2019
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    extension-modules C modules in the Modules dir
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    1 participant
    @vstinner