Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

An incorrect check in _msi.c's msidb_getsummaryinformation() #80321

Closed
ZackerySpytz mannequin opened this issue Feb 27, 2019 · 5 comments
Closed

An incorrect check in _msi.c's msidb_getsummaryinformation() #80321

ZackerySpytz mannequin opened this issue Feb 27, 2019 · 5 comments
Labels
3.7 (EOL) end of life 3.8 only security fixes OS-windows type-bug An unexpected behavior, bug, or error

Comments

@ZackerySpytz
Copy link
Mannequin

ZackerySpytz mannequin commented Feb 27, 2019

BPO 36140
Nosy @pfmoore, @tjguk, @zware, @zooba, @ZackerySpytz, @miss-islington
PRs
  • bpo-36140: Fix an incorrect check in msidb_getsummaryinformation() #12074
  • [3.7] bpo-36140: Fix an incorrect check in msidb_getsummaryinformation() (GH-12074) #12221
  • [2.7] bpo-36140: Fix an incorrect check in msidb_getsummaryinformation() (GH-12074) #12222
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2019-03-07.19:31:09.109>
created_at = <Date 2019-02-27.18:38:06.060>
labels = ['3.8', 'type-bug', '3.7', 'OS-windows']
title = "An incorrect check in _msi.c's msidb_getsummaryinformation()"
updated_at = <Date 2019-03-07.19:31:09.108>
user = 'https://github.com/ZackerySpytz'

    bugs.python.org fields:

    activity = <Date 2019-03-07.19:31:09.108>
actor = 'steve.dower'
assignee = 'none'
closed = True
closed_date = <Date 2019-03-07.19:31:09.109>
closer = 'steve.dower'
components = ['Windows']
creation = <Date 2019-02-27.18:38:06.060>
creator = 'ZackerySpytz'
dependencies = []
files = []
hgrepos = []
issue_num = 36140
keywords = ['patch']
message_count = 5.0
messages = ['336776', '337419', '337420', '337423', '337425']
nosy_count = 6.0
nosy_names = ['paul.moore', 'tim.golden', 'zach.ware', 'steve.dower', 'ZackerySpytz', 'miss-islington']
pr_nums = ['12074', '12221', '12222']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue36140'
versions = ['Python 2.7', 'Python 3.7', 'Python 3.8']
    @ZackerySpytz
    Copy link
    Mannequin Author

    ZackerySpytz mannequin commented Feb 27, 2019

    msidb_getsummaryinformation() checks the wrong variable after calling PyObject_NEW().

    @ZackerySpytz ZackerySpytz mannequin added 3.7 (EOL) end of life 3.8 only security fixes OS-windows type-bug An unexpected behavior, bug, or error labels Feb 27, 2019
    @zooba
    Copy link
    Member

    zooba commented Mar 7, 2019

    New changeset bf94cc7 by Steve Dower (Zackery Spytz) in branch 'master':
    bpo-36140: Fix an incorrect check in msidb_getsummaryinformation() (GH-12074)
    bf94cc7

    @zooba
    Copy link
    Member

    zooba commented Mar 7, 2019

    Thanks for the patch! Once the backports merge, I (or someone else) will close the issue.

    @miss-islington
    Copy link
    Contributor

    New changeset 6ba95c3 by Miss Islington (bot) in branch '3.7':
    bpo-36140: Fix an incorrect check in msidb_getsummaryinformation() (GH-12074)
    6ba95c3

    @miss-islington
    Copy link
    Contributor

    New changeset b19943e by Miss Islington (bot) in branch '2.7':
    bpo-36140: Fix an incorrect check in msidb_getsummaryinformation() (GH-12074)
    b19943e

    @zooba zooba closed this as completed Mar 7, 2019
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.7 (EOL) end of life 3.8 only security fixes OS-windows type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @zooba @miss-islington