Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IDLE: Refactor class variables to instance variables in colorizer #80277

Closed
csabella opened this issue Feb 23, 2019 · 3 comments
Closed

IDLE: Refactor class variables to instance variables in colorizer #80277

csabella opened this issue Feb 23, 2019 · 3 comments
Assignees
@terryjreedy
Labels
3.7 (EOL) end of life 3.8 only security fixes topic-IDLE type-feature A feature request or enhancement

Comments

@csabella
Copy link
Contributor

BPO 36096
Nosy @terryjreedy, @csabella
PRs
  • bpo-36096: IDLE: Refactor class variables in colorizer #12002
  • [3.7] bpo-36096: IDLE: Refactor class variables in colorizer (GH-12002) #12069
  • [3.7] bpo-36096: IDLE: Refactor class variables in colorizer (GH-12002) #12075
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/terryjreedy'
closed_at = <Date 2019-02-27.19:24:28.031>
created_at = <Date 2019-02-23.22:53:18.964>
labels = ['3.8', 'expert-IDLE', 'type-feature', '3.7']
title = 'IDLE: Refactor class variables to instance variables in colorizer'
updated_at = <Date 2019-02-27.19:24:28.031>
user = 'https://github.com/csabella'

    bugs.python.org fields:

    activity = <Date 2019-02-27.19:24:28.031>
actor = 'terry.reedy'
assignee = 'terry.reedy'
closed = True
closed_date = <Date 2019-02-27.19:24:28.031>
closer = 'terry.reedy'
components = ['IDLE']
creation = <Date 2019-02-23.22:53:18.964>
creator = 'cheryl.sabella'
dependencies = []
files = []
hgrepos = []
issue_num = 36096
keywords = ['patch']
message_count = 3.0
messages = ['336415', '336757', '336777']
nosy_count = 2.0
nosy_names = ['terry.reedy', 'cheryl.sabella']
pr_nums = ['12002', '12069', '12075']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue36096'
versions = ['Python 3.7', 'Python 3.8']
    @csabella
    Copy link
    Contributor Author

    From Terry's comment on PR11472 for bpo-35689:

    I don't like the use of class variables to initialize volatile instance state variables. I think it confuses the code a bit. Better, I think, to put them in an init_state method called from __init__. (I am not sure if method could be used in tests.) Since the tests do not access the class vars directly on the class, they should not be affected. I am leaving this minor refactoring for another issue after merging the tests. Then we can modify the class docstring.

    @csabella csabella added 3.7 (EOL) end of life 3.8 only security fixes labels Feb 23, 2019
    @csabella csabella added topic-IDLE type-feature A feature request or enhancement labels Feb 23, 2019
    @csabella
    Copy link
    Contributor Author

    New changeset ed1deb0 by Cheryl Sabella in branch 'master':
    bpo-36096: IDLE: Refactor class variables in colorizer (GH-12002)
    ed1deb0

    @terryjreedy
    Copy link
    Member

    New changeset 488aaba by Terry Jan Reedy (Miss Islington (bot)) in branch '3.7':
    bpo-36096: IDLE: Refactor class variables in colorizer (GH-12002) (GH-12075)
    488aaba

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @terryjreedy terryjreedy

    Labels
    3.7 (EOL) end of life 3.8 only security fixes topic-IDLE type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @terryjreedy @csabella