Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clean up async generator from types module #80272

Closed
scotchka mannequin opened this issue Feb 23, 2019 · 5 comments
Closed

clean up async generator from types module #80272

scotchka mannequin opened this issue Feb 23, 2019 · 5 comments
Labels
3.8 only security fixes stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error

Comments

@scotchka
Copy link
Mannequin

scotchka mannequin commented Feb 23, 2019

BPO 36091
Nosy @serhiy-storchaka, @1st1, @miss-islington, @scotchka
PRs
  • bpo-36091: remove reference to async generator in Lib/types.py #11996
  • [3.7] bpo-36091: Remove reference to async generator in Lib/types.py. (GH-11996) #12146
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2019-03-03.16:39:21.402>
created_at = <Date 2019-02-23.06:07:17.382>
labels = ['3.8', 'type-bug', 'library']
title = 'clean up async generator from types module'
updated_at = <Date 2019-03-03.16:39:21.402>
user = 'https://github.com/scotchka'

    bugs.python.org fields:

    activity = <Date 2019-03-03.16:39:21.402>
actor = 'scotchka'
assignee = 'none'
closed = True
closed_date = <Date 2019-03-03.16:39:21.402>
closer = 'scotchka'
components = ['Library (Lib)']
creation = <Date 2019-02-23.06:07:17.382>
creator = 'scotchka'
dependencies = []
files = []
hgrepos = []
issue_num = 36091
keywords = ['patch']
message_count = 5.0
messages = ['336368', '336373', '336409', '337032', '337033']
nosy_count = 4.0
nosy_names = ['serhiy.storchaka', 'yselivanov', 'miss-islington', 'scotchka']
pr_nums = ['11996', '12146']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue36091'
versions = ['Python 3.8']
    @scotchka
    Copy link
    Mannequin Author

    scotchka mannequin commented Feb 23, 2019

    the following script:

    import sys, types

def tr(frame, event, arg):
    print(frame, event, arg)
    return tr

sys.settrace(tr)

    gives the output:

    <frame object at 0x106c5cd48> call None
<frame object at 0x106c5cd48> exception (<class 'GeneratorExit'>, GeneratorExit(), <traceback object at 0x106cc1f88>)
<frame object at 0x106c5cd48> return None

    This is due to Lib/types.py creating an async generator for the sole purpose of getting its type. I'll remove that reference after use to prevent the above message, which is probably benign but perhaps unnerving.

    @scotchka scotchka mannequin added 3.8 only security fixes stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error labels Feb 23, 2019
    @serhiy-storchaka
    Copy link
    Member

    I am sure this change already was discussed in other issue, but I can not find that issue and I am not sure that there is a PR.

    @scotchka
    Copy link
    Mannequin Author

    scotchka mannequin commented Feb 23, 2019

    As it happens @cheryl.sabella has created a very useful data set of which files are impacted by open PRs: https://github.com/csabella/pulls

    and as of 2019-02-18, the only open PR that relates to Lib/types.py is
    #5068 on an unrelated matter

    @serhiy-storchaka
    Copy link
    Member

    New changeset 0a6a412 by Serhiy Storchaka (Henry Chen) in branch 'master':
    bpo-36091: Remove reference to async generator in Lib/types.py. (GH-11996)
    0a6a412

    @miss-islington
    Copy link
    Contributor

    New changeset cd04164 by Miss Islington (bot) in branch '3.7':
    bpo-36091: Remove reference to async generator in Lib/types.py. (GH-11996)
    cd04164

    @scotchka scotchka mannequin closed this as completed Mar 3, 2019
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.8 only security fixes stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @serhiy-storchaka @miss-islington