Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Windows projects to build with platform ARM32 #80157

Closed
paulmon mannequin opened this issue Feb 12, 2019 · 3 comments
Closed

Enable Windows projects to build with platform ARM32 #80157

paulmon mannequin opened this issue Feb 12, 2019 · 3 comments
Labels
3.8 only security fixes build The build process and cross-build OS-windows type-feature A feature request or enhancement

Comments

@paulmon
Copy link
Mannequin

paulmon mannequin commented Feb 12, 2019

BPO 35976
Nosy @pfmoore, @tjguk, @zware, @zooba, @paulmon
PRs
  • bpo-35976: Enable Windows projects to build with platform ARM32 #11825
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2019-02-14.16:52:09.981>
created_at = <Date 2019-02-12.04:02:51.232>
labels = ['type-feature', '3.8', 'OS-windows', 'build']
title = 'Enable Windows projects to build with platform ARM32'
updated_at = <Date 2019-02-14.16:52:09.980>
user = 'https://github.com/paulmon'

    bugs.python.org fields:

    activity = <Date 2019-02-14.16:52:09.980>
actor = 'steve.dower'
assignee = 'none'
closed = True
closed_date = <Date 2019-02-14.16:52:09.981>
closer = 'steve.dower'
components = ['Build', 'Windows']
creation = <Date 2019-02-12.04:02:51.232>
creator = 'Paul Monson'
dependencies = []
files = []
hgrepos = []
issue_num = 35976
keywords = ['patch']
message_count = 3.0
messages = ['335325', '335538', '335545']
nosy_count = 5.0
nosy_names = ['paul.moore', 'tim.golden', 'zach.ware', 'steve.dower', 'Paul Monson']
pr_nums = ['11825']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue35976'
versions = ['Python 3.8']
    @paulmon paulmon mannequin added 3.8 only security fixes build The build process and cross-build OS-windows type-feature A feature request or enhancement labels Feb 12, 2019
    @zooba
    Copy link
    Member

    zooba commented Feb 12, 2019

    Just updating the title to reflect what the patch actually does in isolation - you probably should update the PR and NEWS items to match.

    It's fine (probably preferred) to mention in the issue and PR text that it's been split out from another PR. But we have to account for the (very small) chance that this part is merged and the rest is not - in that case, having a standalone description of the change is much more helpful.

    @zooba zooba changed the title PCBuild file changes for arm32 should be separated from code changes for review Enable Windows projects to build with platform ARM32 Feb 12, 2019
    @zooba
    Copy link
    Member

    zooba commented Feb 14, 2019

    New changeset 8a1657b by Steve Dower (Paul Monson) in branch 'master':
    bpo-35976: Enable Windows projects to build with platform ARM32 (GH-11825)
    8a1657b

    @zooba
    Copy link
    Member

    zooba commented Feb 14, 2019

    Thanks, Paul! Hopefully when you rebase the main change on top of this it will be easier to see the actual impact.

    @zooba zooba closed this as completed Feb 14, 2019
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.8 only security fixes build The build process and cross-build OS-windows type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    1 participant
    @zooba