Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update libffi_msvc to current version of libffi #80128

Closed
paulmon mannequin opened this issue Feb 8, 2019 · 8 comments
Closed

Update libffi_msvc to current version of libffi #80128

paulmon mannequin opened this issue Feb 8, 2019 · 8 comments
Labels
3.8 only security fixes OS-windows topic-ctypes type-feature A feature request or enhancement

Comments

@paulmon
Copy link
Mannequin

paulmon mannequin commented Feb 8, 2019

BPO 35947
Nosy @pfmoore, @vstinner, @tjguk, @encukou, @zware, @serhiy-storchaka, @zooba, @paulmon
PRs
  • bpo-35947: Update windows to the current version of libffi #11797
  • bpo-35947: Update windows to the current version of libffi #11797
  • bpo-35947: Update windows to the current version of libffi #11797
  • bpo-35947: Update windows to the current version of libffi #11797
  • bpo-35947: Fix a compiler warning in _ctypes.c's StructUnionType_paramfunc() #12629
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2019-05-03.16:02:20.777>
created_at = <Date 2019-02-08.22:40:46.419>
labels = ['ctypes', 'type-feature', '3.8', 'OS-windows']
title = 'Update libffi_msvc to current version of libffi'
updated_at = <Date 2019-06-03.09:22:13.353>
user = 'https://github.com/paulmon'

    bugs.python.org fields:

    activity = <Date 2019-06-03.09:22:13.353>
actor = 'petr.viktorin'
assignee = 'none'
closed = True
closed_date = <Date 2019-05-03.16:02:20.777>
closer = 'Paul Monson'
components = ['Windows', 'ctypes']
creation = <Date 2019-02-08.22:40:46.419>
creator = 'Paul Monson'
dependencies = []
files = []
hgrepos = []
issue_num = 35947
keywords = ['patch', 'patch', 'patch', 'patch']
message_count = 8.0
messages = ['335115', '339161', '339264', '342167', '342169', '342210', '342743', '344395']
nosy_count = 9.0
nosy_names = ['paul.moore', 'vstinner', 'tim.golden', 'petr.viktorin', 'SilentGhost', 'zach.ware', 'serhiy.storchaka', 'steve.dower', 'Paul Monson']
pr_nums = ['11797', '11797', '11797', '11797', '12629']
priority = 'normal'
resolution = None
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue35947'
versions = ['Python 3.8']
    @paulmon
    Copy link
    Mannequin Author

    paulmon mannequin commented Feb 8, 2019

    libffi needs to be updated to the current version for Windows builds to make it easier to add ARM support

    @paulmon paulmon mannequin added 3.8 only security fixes OS-windows topic-ctypes type-feature A feature request or enhancement labels Feb 8, 2019
    @zooba
    Copy link
    Member

    zooba commented Mar 29, 2019

    New changeset 32119e1 by Steve Dower (Paul Monson) in branch 'master':
    bpo-35947: Update Windows to the current version of libffi (GH-11797)
    32119e1

    @serhiy-storchaka
    Copy link
    Member

    New changeset 48600c7 by Serhiy Storchaka (Zackery Spytz) in branch 'master':
    bpo-35947: Fix a compiler warning in _ctypes.c's StructUnionType_paramfunc(). (GH-12629)
    48600c7

    @paulmon paulmon mannequin closed this as completed May 3, 2019
    @vstinner
    Copy link
    Member

    Would it be possible to add a What's New in Python 3.8 entry about this change? IMHO it is big and important enough to be mentioned ;-) I also wanted libffi_msvc/ to be removed. Thanks!

    @SilentGhost
    Copy link
    Mannequin

    SilentGhost mannequin commented May 11, 2019

    I also wanted libffi_msvc/ to be removed.

    An empty directory is not really tracked by git, you should be able to just remove it manually without any problems, alternatively you could try

    git clean -fd # on a clean tree

    add -n for dry run.

    @vstinner
    Copy link
    Member

    I am talking about the commit whixh removed the directory. I am happy that
    someone succeeded to write it ;-)

    @paulmon
    Copy link
    Mannequin Author

    paulmon mannequin commented May 17, 2019

    Would you like me to submit a PR to the What's New doc?

    @encukou
    Copy link
    Member

    encukou commented Jun 3, 2019

    Possible regression caused by this change: https://bugs.python.org/issue37140

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.8 only security fixes OS-windows topic-ctypes type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    4 participants
    @vstinner @encukou @zooba @serhiy-storchaka