Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the BuiltinImporter in importlib to use loader._ORIGIN instead of a hardcoded value #80104

Closed
nnja opened this issue Feb 6, 2019 · 4 comments
Closed

Update the BuiltinImporter in importlib to use loader._ORIGIN instead of a hardcoded value #80104

nnja opened this issue Feb 6, 2019 · 4 comments
Assignees
@corona10
Labels
3.9 only security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) type-feature A feature request or enhancement

Comments

@nnja
Copy link
Contributor

nnja commented Feb 6, 2019

BPO 35923
Nosy @warsaw, @brettcannon, @ncoghlan, @ericsnowcurrently, @nnja, @corona10
PRs
  • bpo-35923: Update the BuiltinImporter to use loader._ORIGIN #15651
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/corona10'
closed_at = <Date 2019-09-11.16:34:20.654>
created_at = <Date 2019-02-06.22:00:01.315>
labels = ['interpreter-core', 'type-feature', '3.9']
title = 'Update the BuiltinImporter in importlib to use loader._ORIGIN instead of a hardcoded value'
updated_at = <Date 2019-09-11.16:34:20.653>
user = 'https://github.com/nnja'

    bugs.python.org fields:

    activity = <Date 2019-09-11.16:34:20.653>
actor = 'corona10'
assignee = 'corona10'
closed = True
closed_date = <Date 2019-09-11.16:34:20.654>
closer = 'corona10'
components = ['Interpreter Core']
creation = <Date 2019-02-06.22:00:01.315>
creator = 'nnja'
dependencies = []
files = []
hgrepos = []
issue_num = 35923
keywords = ['patch']
message_count = 4.0
messages = ['334989', '334997', '335004', '351961']
nosy_count = 6.0
nosy_names = ['barry', 'brett.cannon', 'ncoghlan', 'eric.snow', 'nnja', 'corona10']
pr_nums = ['15651']
priority = 'low'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue35923'
versions = ['Python 3.9']
    @nnja
    Copy link
    Contributor Author

    nnja commented Feb 6, 2019

    Update the BuiltinImporter in importllib to set the origin from the shared loader._ORIGIN attribute instead of using the hard-coded value of 'built-in' in order to match the functionality of FrozenImporter.

    The FrozenImporter was updated to use this attribute in PR #55941 (#11732)

    @nnja nnja self-assigned this Feb 6, 2019
    @nnja nnja added 3.7 (EOL) end of life 3.8 only security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) type-feature A feature request or enhancement labels Feb 6, 2019
    @corona10
    Copy link
    Member

    corona10 commented Feb 7, 2019

    @nnja

    Hi, Can I work on this issue if no one works on it?

    @nnja
    Copy link
    Contributor Author

    nnja commented Feb 7, 2019

    Hey Dong-hee, Unfortunately, I already started the work on this which is why I assigned the ticket to myself when I opened it. This work came up as a continuation of another ticket I worked on - bpo-35321 / #55941. I wanted to keep them as separate issues.

    I'm sorry, I hope you find another ticket to work on soon.

    @corona10 corona10 added the 3.9 only security fixes label Sep 2, 2019
    @brettcannon
    Copy link
    Member

    New changeset 145cf1f by Brett Cannon (Dong-hee Na) in branch 'master':
    bpo-35923: Update the BuiltinImporter to use loader._ORIGIN instead of a hard-coded value (GH-15651)
    145cf1f

    @corona10 corona10 removed 3.7 (EOL) end of life 3.8 only security fixes labels Sep 11, 2019
    @corona10 corona10 assigned corona10 and unassigned nnja Sep 11, 2019
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @corona10 corona10

    Labels
    3.9 only security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    3 participants
    @brettcannon @nnja @corona10