Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

multiprocessing's SyncManager.dict.has_key() method is broken #80099

Closed
giampaolo opened this issue Feb 6, 2019 · 6 comments
Closed

multiprocessing's SyncManager.dict.has_key() method is broken #80099

giampaolo opened this issue Feb 6, 2019 · 6 comments
Labels
3.7 (EOL) end of life 3.8 only security fixes

Comments

@giampaolo
Copy link
Contributor

BPO 35918
Nosy @pitrou, @giampaolo, @applio, @remilapeyre
PRs
  • bpo-35918: Remove broken has_key method and add test #11819
  • bpo-35918: Remove broken has_key method and add test #11819
  • bpo-35918: Remove broken has_key method and add test #11819
  • [3.7] bpo-35918: Remove broken has_key method and add test (GH-11819) #11824
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2019-02-12.17:36:02.616>
created_at = <Date 2019-02-06.17:22:15.128>
labels = ['3.7', '3.8']
title = "multiprocessing's SyncManager.dict.has_key() method is broken"
updated_at = <Date 2019-02-12.17:36:02.615>
user = 'https://github.com/giampaolo'

    bugs.python.org fields:

    activity = <Date 2019-02-12.17:36:02.615>
actor = 'josh.r'
assignee = 'none'
closed = True
closed_date = <Date 2019-02-12.17:36:02.616>
closer = 'josh.r'
components = []
creation = <Date 2019-02-06.17:22:15.128>
creator = 'giampaolo.rodola'
dependencies = []
files = []
hgrepos = []
issue_num = 35918
keywords = ['patch', 'patch', 'patch']
message_count = 6.0
messages = ['334959', '335222', '335230', '335232', '335279', '335280']
nosy_count = 6.0
nosy_names = ['pitrou', 'giampaolo.rodola', 'jnoller', 'sbt', 'davin', 'remi.lapeyre']
pr_nums = ['11819', '11819', '11819', '11824']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue35918'
versions = ['Python 3.6', 'Python 3.7', 'Python 3.8']
    @giampaolo
    Copy link
    Contributor Author

    Related to BPO-35917:

    $ ./python 
Python 3.8.0a1+ (heads/master:cd90f6a369, Feb  6 2019, 17:16:10) 
[GCC 7.3.0] on linux
>>> import multiprocessing.managers
>>> m = multiprocessing.managers.SyncManager()
>>> m.start()
>>> d = m.dict()
>>> 'has_key' in dir(d)
True
>>> d.has_key(1)
Traceback (most recent call last):
  File "/home/giampaolo/cpython/Lib/multiprocessing/managers.py", line 271, in serve_client
    fallback_func = self.fallback_mapping[methodname]
KeyError: 'has_key'

    @giampaolo giampaolo added 3.7 (EOL) end of life 3.8 only security fixes labels Feb 6, 2019
    @remilapeyre
    Copy link
    Mannequin

    remilapeyre mannequin commented Feb 11, 2019

    Hi @giampaolo.rodola, I will post a PR for this issue.

    @remilapeyre
    Copy link
    Mannequin

    remilapeyre mannequin commented Feb 11, 2019

    has_key method has been removed in Python3 so I think we can remove it from the DictProxy as well as nobody should be relying on it anymore.

    @pitrou
    Copy link
    Member

    pitrou commented Feb 11, 2019

    That sounds fine to me.

    @giampaolo
    Copy link
    Contributor Author

    New changeset a31f4cc by Giampaolo Rodola (Rémi Lapeyre) in branch 'master':
    bpo-35918: Remove broken has_key method and add test (bpo-11819)
    a31f4cc

    @giampaolo
    Copy link
    Contributor Author

    New changeset 58f05ce by Giampaolo Rodola (Miss Islington (bot)) in branch '3.7':
    bpo-35918: Remove broken has_key method and add test (GH-11819) (bpo-11824)
    58f05ce

    @MojoVampire MojoVampire mannequin closed this as completed Feb 12, 2019
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.7 (EOL) end of life 3.8 only security fixes
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @giampaolo @pitrou