Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

elementtree tests do not include bytes handling #47841

Closed
pitrou opened this issue Aug 18, 2008 · 4 comments
Closed

elementtree tests do not include bytes handling #47841

pitrou opened this issue Aug 18, 2008 · 4 comments
Labels
tests Tests in the Lib/test dir topic-XML type-bug An unexpected behavior, bug, or error

Comments

@pitrou
Copy link
Member

pitrou commented Aug 18, 2008

BPO 3591
Nosy @amauryfa, @pitrou, @serhiy-storchaka

Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2013-08-03.22:19:11.714>
created_at = <Date 2008-08-18.16:57:48.001>
labels = ['expert-XML', 'type-bug', 'tests']
title = 'elementtree tests do not include bytes handling'
updated_at = <Date 2013-08-03.22:19:11.713>
user = 'https://github.com/pitrou'

bugs.python.org fields:

activity = <Date 2013-08-03.22:19:11.713>
actor = 'eli.bendersky'
assignee = 'none'
closed = True
closed_date = <Date 2013-08-03.22:19:11.714>
closer = 'eli.bendersky'
components = ['Tests', 'XML']
creation = <Date 2008-08-18.16:57:48.001>
creator = 'pitrou'
dependencies = []
files = []
hgrepos = []
issue_num = 3591
keywords = []
message_count = 4.0
messages = ['71351', '109653', '111160', '194059']
nosy_count = 7.0
nosy_names = ['effbot', 'amaury.forgeotdarc', 'pitrou', 'eli.bendersky', 'santoso.wijaya', 'BreamoreBoy', 'serhiy.storchaka']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue3591'
versions = ['Python 3.3', 'Python 3.4']
@pitrou
Copy link
Member Author

pitrou commented Aug 18, 2008

In py3k, there should be explicit tests for byte string input (in
addition to unicode input) to elementtree's parser, including non-UTF8
encodings and non-ASCII chars.

@pitrou pitrou added tests Tests in the Lib/test dir topic-XML type-bug An unexpected behavior, bug, or error labels Aug 18, 2008
@BreamoreBoy
Copy link
Mannequin

BreamoreBoy mannequin commented Jul 9, 2010

Have the tests been incorporated into py3k so this can be closed, or is it still valid?

@amauryfa
Copy link
Member

test_xml_etree.py has some tests about bytes input (check_issue6233) but these are only working cases. Tests with wrong encodings should be added.

@elibendersky
Copy link
Mannequin

elibendersky mannequin commented Aug 1, 2013

Quite a bit of encoding-related tests were added recently (by Serhiy, IIRC). Unless there are objections or more specific test suggestions, I will close this issue in a few days.

@elibendersky elibendersky mannequin closed this as completed Aug 3, 2013
@ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tests Tests in the Lib/test dir topic-XML type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@amauryfa @pitrou