Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup some non-consistent API callings #80071

Closed
gongminmin mannequin opened this issue Feb 2, 2019 · 7 comments
Closed

Cleanup some non-consistent API callings #80071

gongminmin mannequin opened this issue Feb 2, 2019 · 7 comments
Labels
3.8 only security fixes OS-windows type-feature A feature request or enhancement

Comments

@gongminmin
Copy link
Mannequin

gongminmin mannequin commented Feb 2, 2019

BPO 35890
Nosy @pfmoore, @tjguk, @zware, @gongminmin, @zooba, @miss-islington
PRs
  • bpo-35890 : Fix some API calling consistency #11742
  • bpo-35890 : Fix some API calling consistency #11742
  • bpo-35890 : Fix some API calling consistency #11742
  • bpo-20596: define a platform dependent Py_WCSTOK in Include/pyport.h,… #10286
  • bpo-35890: Use RegQueryInfoKeyW and CryptAcquireContextW for consistency #19974
  • [3.8] bpo-35890: Use RegQueryInfoKeyW and CryptAcquireContextW explicitly (GH-19974) #20189
  • [3.7] bpo-35890: Use RegQueryInfoKeyW and CryptAcquireContextW explicitly (GH-19974) #20190
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2019-02-03.04:27:23.438>
created_at = <Date 2019-02-02.22:08:35.873>
labels = ['type-feature', '3.8', 'OS-windows']
title = 'Cleanup some non-consistent API callings'
updated_at = <Date 2020-05-18.22:24:44.576>
user = 'https://github.com/gongminmin'

    bugs.python.org fields:

    activity = <Date 2020-05-18.22:24:44.576>
actor = 'steve.dower'
assignee = 'none'
closed = True
closed_date = <Date 2019-02-03.04:27:23.438>
closer = 'steve.dower'
components = ['Windows']
creation = <Date 2019-02-02.22:08:35.873>
creator = 'Minmin.Gong'
dependencies = []
files = []
hgrepos = []
issue_num = 35890
keywords = ['patch', 'patch', 'patch']
message_count = 7.0
messages = ['334771', '334784', '334785', '369268', '369275', '369276', '369302']
nosy_count = 6.0
nosy_names = ['paul.moore', 'tim.golden', 'zach.ware', 'Minmin.Gong', 'steve.dower', 'miss-islington']
pr_nums = ['11742', '11742', '11742', '10286', '19974', '20189', '20190']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue35890'
versions = ['Python 3.8']
    @gongminmin
    Copy link
    Mannequin Author

    gongminmin mannequin commented Feb 2, 2019

    1. Unicode version of Windows APIs are used in places, but not for GetVersionEx in Python/sysmodule.c
    2. The wcstok_s is called on Windows in Modules/main.c and PC/launcher.c, but not in Python/pathconfig.c

    @gongminmin gongminmin mannequin added 3.8 only security fixes OS-windows type-feature A feature request or enhancement labels Feb 2, 2019
    @zooba
    Copy link
    Member

    zooba commented Feb 3, 2019

    New changeset 8ebc645 by Steve Dower (Minmin Gong) in branch 'master':
    bpo-35890 : Fix some API calling consistency (GH-11742)
    8ebc645

    @zooba
    Copy link
    Member

    zooba commented Feb 3, 2019

    Thanks for the contribution!

    @zooba zooba closed this as completed Feb 3, 2019
    @zooba
    Copy link
    Member

    zooba commented May 18, 2020

    Thanks for the additional cleanup. In future, we'd still like a separate issue for new changes (that aren't fixing up something caused by the earlier change).

    @zooba
    Copy link
    Member

    zooba commented May 18, 2020

    New changeset 98e42d1 by Minmin Gong in branch 'master':
    bpo-35890: Use RegQueryInfoKeyW and CryptAcquireContextW explicitly (GH-19974)
    98e42d1

    @miss-islington
    Copy link
    Contributor

    New changeset 460eac2 by Miss Islington (bot) in branch '3.8':
    bpo-35890: Use RegQueryInfoKeyW and CryptAcquireContextW explicitly (GH-19974)
    460eac2

    @zooba
    Copy link
    Member

    zooba commented May 18, 2020

    New changeset 930badd by Steve Dower in branch '3.7':
    bpo-35890: Use RegQueryInfoKeyW and CryptAcquireContextW explicitly (GH-19974)
    930badd

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.8 only security fixes OS-windows type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @zooba @miss-islington