Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Controlling venv from venv no longer works in 3.7.2 #80054

Closed
schlamar mannequin opened this issue Feb 1, 2019 · 4 comments
Closed

Controlling venv from venv no longer works in 3.7.2 #80054

schlamar mannequin opened this issue Feb 1, 2019 · 4 comments
Labels
3.7 (EOL) end of life OS-windows stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error

Comments

@schlamar
Copy link
Mannequin

schlamar mannequin commented Feb 1, 2019

BPO 35873
Nosy @pfmoore, @tjguk, @schlamar, @zware, @zooba
PRs
  • bpo-35872 and bpo-35873: Clears __PYVENV_LAUNCHER__ variable #11745
  • bpo-35872 and bpo-35873: Clears __PYVENV_LAUNCHER__ variable #11745
  • [3.7] bpo-35872 and bpo-35873: Clears __PYVENV_LAUNCHER__ variable (GH-11745) #11753
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2019-02-04.15:23:13.377>
created_at = <Date 2019-02-01.09:03:04.786>
labels = ['3.7', 'type-bug', 'library', 'OS-windows']
title = 'Controlling venv from venv no longer works in 3.7.2'
updated_at = <Date 2019-02-04.15:23:13.377>
user = 'https://github.com/schlamar'

    bugs.python.org fields:

    activity = <Date 2019-02-04.15:23:13.377>
actor = 'steve.dower'
assignee = 'none'
closed = True
closed_date = <Date 2019-02-04.15:23:13.377>
closer = 'steve.dower'
components = ['Library (Lib)', 'Windows']
creation = <Date 2019-02-01.09:03:04.786>
creator = 'schlamar'
dependencies = []
files = []
hgrepos = []
issue_num = 35873
keywords = ['patch', 'patch']
message_count = 4.0
messages = ['334659', '334774', '334813', '334829']
nosy_count = 5.0
nosy_names = ['paul.moore', 'tim.golden', 'schlamar', 'zach.ware', 'steve.dower']
pr_nums = ['11745', '11745', '11753']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue35873'
versions = ['Python 3.7']
    @schlamar
    Copy link
    Mannequin Author

    schlamar mannequin commented Feb 1, 2019

    Controlling a venv from the python.exe from another venv does not work since 3.7.2 on Windows. This is probably related to the change

    bpo-34977: venv on Windows will now use a python.exe redirector rather than copying the actual binaries from the base environment.

    This is obviously related to bpo-35872, but this could be a different bug.

    When a Python script in a venv wants to control another venv by running commands like another-venv\python.exe -m pip with subprocess, python.exe is not referencing the other venv. It is referencing to the venv the script currently running from. This is probably because os.environ contains a 'PYVENV_LAUNCHER' which is pointing to the venv from the script.

    This can be reproduced with pipx (https://github.com/pipxproject/pipx-app) by running

    pipx install --python "C:\Program Files (x86)\Python37-32\python.exe" --verbose tox

    This results in pip installing to venvs\pipx-app and not in venvs\tox.

    I assume a simpler reproduction might be (but I cannot check this anymore as I'm back on 3.7.1 right now):

    C:\Program Files (x86)\Python37-32\python.exe -m venv C:\Users\$USER\.local\pipx\venvs\tox
c:\users\$USER\.local\pipx\venvs\pipx-app\scripts\python.exe -c "import subprocess; subprocess.run(['C:\Users\$USER\.local\pipx\venvs\tox\Scripts\python.exe', '-m', 'pip', 'install', 'tox'])"

    Downstream bugreport in pipx is pypa/pipx#81.

    @schlamar schlamar mannequin added 3.7 (EOL) end of life stdlib Python modules in the Lib dir OS-windows type-bug An unexpected behavior, bug, or error labels Feb 1, 2019
    @zooba
    Copy link
    Member

    zooba commented Feb 2, 2019

    So with the fix for multiprocessing, we currently rely on __PYVENV_LAUNCHER__ remaining set throughout the process.

    However, it may be better to add a "sys.base_executable" property instead and clear the __PYVENV_LAUNCHER__ variable once we've read it. Then we can set it again in multiprocessing and launch the base executable, and otherwise default to launching the redirector.

    @zooba
    Copy link
    Member

    zooba commented Feb 4, 2019

    New changeset a8474d0 by Steve Dower in branch 'master':
    bpo-35872 and bpo-35873: Clears __PYVENV_LAUNCHER__ variable (GH-11745)
    a8474d0

    @zooba
    Copy link
    Member

    zooba commented Feb 4, 2019

    New changeset 44467e8 by Steve Dower in branch '3.7':
    bpo-35872 and bpo-35873: Clears __PYVENV_LAUNCHER__ variable (GH-11745)
    44467e8

    @zooba zooba closed this as completed Feb 4, 2019
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.7 (EOL) end of life OS-windows stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    1 participant
    @zooba