Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove smtpd.MailmanProxy #79981

Closed
samuelcolvin mannequin opened this issue Jan 21, 2019 · 6 comments
Closed

remove smtpd.MailmanProxy #79981

samuelcolvin mannequin opened this issue Jan 21, 2019 · 6 comments
Labels
3.7 (EOL) end of life 3.8 only security fixes topic-email

Comments

@samuelcolvin
Copy link
Mannequin

samuelcolvin mannequin commented Jan 21, 2019

BPO 35800
Nosy @warsaw, @bitdancer, @samuelcolvin, @corona10, @miss-islington
PRs
  • bpo-35800: Deprecate smtpd.MailmanProxy #11675
  • bpo-35800: Deprecate smtpd.MailmanProxy #11675
  • bpo-35800: Deprecate smtpd.MailmanProxy #11675
  • bpo-35800: Remove smtpd.MailmanProxy since 3.11 #26617
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2021-06-10.00:00:46.877>
created_at = <Date 2019-01-21.17:27:10.828>
labels = ['3.7', '3.8', 'expert-email']
title = 'remove smtpd.MailmanProxy'
updated_at = <Date 2021-06-10.00:00:46.877>
user = 'https://github.com/samuelcolvin'

    bugs.python.org fields:

    activity = <Date 2021-06-10.00:00:46.877>
actor = 'corona10'
assignee = 'none'
closed = True
closed_date = <Date 2021-06-10.00:00:46.877>
closer = 'corona10'
components = ['email']
creation = <Date 2019-01-21.17:27:10.828>
creator = 'samuelcolvin'
dependencies = []
files = []
hgrepos = []
issue_num = 35800
keywords = ['patch', 'patch', 'patch']
message_count = 6.0
messages = ['334157', '334189', '334214', '334216', '354542', '395492']
nosy_count = 5.0
nosy_names = ['barry', 'r.david.murray', 'samuelcolvin', 'corona10', 'miss-islington']
pr_nums = ['11675', '11675', '11675', '26617']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue35800'
versions = ['Python 3.5', 'Python 3.6', 'Python 3.7', 'Python 3.8']
    @samuelcolvin
    Copy link
    Mannequin Author

    samuelcolvin mannequin commented Jan 21, 2019

    smtpd.MailmanProxy is completely broken, it takes the wrong arguments but also assumes the existence of a "Mailman" module which doesn't exist.

    It should be removed in 3.8 or 3.9.

    Created from https://bugs.python.org/issue35788

    Happy to create a PR if this is agreed.

    @samuelcolvin samuelcolvin mannequin added 3.7 (EOL) end of life 3.8 only security fixes topic-email labels Jan 21, 2019
    @warsaw
    Copy link
    Member

    warsaw commented Jan 21, 2019

    Yes, it should be deprecated and removed. TBH, IMHO smtpd.py should be entirely deprecated. aiosmtpd (3rd party) is a much more modern approach.

    @samuelcolvin
    Copy link
    Mannequin Author

    samuelcolvin mannequin commented Jan 22, 2019

    Ok, if I create a PR, should it just remove MailmanProxy completely or mark it as deprecated in the docs to be removed in 3.9?

    Personally, I think it should be ok to remove it completely since it hasn't been working at all for the last 4 minor versions.

    @warsaw
    Copy link
    Member

    warsaw commented Jan 22, 2019

    On Jan 22, 2019, at 07:16, Samuel Colvin <report@bugs.python.org> wrote:

    Ok, if I create a PR, should it just remove MailmanProxy completely or mark it as deprecated in the docs to be removed in 3.9?

    Personally, I think it should be ok to remove it completely since it hasn't been working at all for the last 4 minor versions.

    True, but I think we should stick to the normal deprecation process, just to be safe.

    @miss-islington
    Copy link
    Contributor

    New changeset 822922a by Miss Islington (bot) (Samuel Colvin) in branch 'master':
    bpo-35800: Deprecate smtpd.MailmanProxy (GH-11675)
    822922a

    @corona10
    Copy link
    Member

    corona10 commented Jun 9, 2021

    New changeset 309ab61 by Dong-hee Na in branch 'main':
    bpo-35800: Remove smtpd.MailmanProxy since 3.11 (GH-26617)
    309ab61

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.7 (EOL) end of life 3.8 only security fixes topic-email
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    3 participants
    @warsaw @corona10 @miss-islington