Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IDLE hangs when passing invalid command line args (directory(ies) instead of file(s)) #47823

Closed
gpolo mannequin opened this issue Aug 16, 2008 · 13 comments
Closed

IDLE hangs when passing invalid command line args (directory(ies) instead of file(s)) #47823

gpolo mannequin opened this issue Aug 16, 2008 · 13 comments
Assignees
@asvetlov
Labels
stdlib Python modules in the Lib dir topic-IDLE type-bug An unexpected behavior, bug, or error

Comments

@gpolo
Copy link
Mannequin

gpolo mannequin commented Aug 16, 2008

BPO 3573
Nosy @terryjreedy, @serwy, @merwok, @asvetlov
Files
  • fix_idle_startup_hang.diff
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/asvetlov'
closed_at = <Date 2012-03-20.21:06:26.593>
created_at = <Date 2008-08-16.23:32:25.454>
labels = ['expert-IDLE', 'type-bug', 'library']
title = 'IDLE hangs when passing invalid command line args (directory(ies) instead of file(s))'
updated_at = <Date 2012-03-21.23:27:41.000>
user = 'https://bugs.python.org/gpolo'

    bugs.python.org fields:

    activity = <Date 2012-03-21.23:27:41.000>
actor = 'eric.araujo'
assignee = 'asvetlov'
closed = True
closed_date = <Date 2012-03-20.21:06:26.593>
closer = 'asvetlov'
components = ['IDLE', 'Library (Lib)']
creation = <Date 2008-08-16.23:32:25.454>
creator = 'gpolo'
dependencies = []
files = ['11129']
hgrepos = []
issue_num = 3573
keywords = ['patch', 'needs review']
message_count = 13.0
messages = ['71249', '89022', '110682', '148593', '156464', '156465', '156488', '156489', '156490', '156496', '156497', '156523', '156524']
nosy_count = 7.0
nosy_names = ['terry.reedy', 'gpolo', 'roger.serwy', 'eric.araujo', 'asvetlov', 'BreamoreBoy', 'python-dev']
pr_nums = []
priority = 'high'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue3573'
versions = ['Python 2.7', 'Python 3.2', 'Python 3.3']
    @gpolo
    Copy link
    Mannequin Author

    gpolo mannequin commented Aug 16, 2008

    Passing a single directory as a command line argument can make IDLE hang.
    To achieve this the user needs to configure IDLE to open an editor
    window by default.

    The attached patch discards filenames that failed to load, so in the end
    it may open an empty editor window instead of hanging.

    @gpolo gpolo mannequin added the stdlib Python modules in the Lib dir label Aug 16, 2008
    @devdanzin devdanzin mannequin added topic-IDLE type-bug An unexpected behavior, bug, or error labels Apr 26, 2009
    @gpolo
    Copy link
    Mannequin Author

    gpolo mannequin commented Jun 6, 2009

    Idle has changed a bit since the initial message, so it no longer hangs
    when it is configured to open an edit window by default, but now it
    hangs when running it as: idle -e <somedirnamehere> (which the patch fixes).

    @BreamoreBoy
    Copy link
    Mannequin

    BreamoreBoy mannequin commented Jul 18, 2010

    Please refer to msg89022.

    @serwy
    Copy link
    Mannequin

    serwy mannequin commented Nov 29, 2011

    I can confirm that using "idle -e <dir>" still causes a hang on Windows using 3.2.2 and on Ubuntu using 2.7.1 and 3.2

    The given patch fixes the problem on those platforms.

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Mar 20, 2012

    New changeset 01404295138d by Andrew Svetlov in branch 'default':
    bpo-3573: idle now doesn't hungs if launched as: idle -e <directory>
    http://hg.python.org/cpython/rev/01404295138d

    @asvetlov
    Copy link
    Contributor

    Fixed. Thanks to Guilherme Polo and Roger Serwy.

    @asvetlov asvetlov self-assigned this Mar 20, 2012
    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Mar 21, 2012

    New changeset a95b19b3b4cd by Andrew Svetlov in branch '3.2':
    bpo-3573: idle now doesn't hungs if launched as: idle -e <directory>
    http://hg.python.org/cpython/rev/a95b19b3b4cd

    New changeset cdcd1f7f0882 by Andrew Svetlov in branch 'default':
    Merge from 3.2 for issue bpo-3573, fix Misc/NEWS as Ned Deily guess.
    http://hg.python.org/cpython/rev/cdcd1f7f0882

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Mar 21, 2012

    New changeset a9be863e5734 by Andrew Svetlov in branch '2.7':
    bpo-3573: idle now doesn't hungs if launched as: idle -e <directory>
    http://hg.python.org/cpython/rev/a9be863e5734

    @asvetlov
    Copy link
    Contributor

    Backported to 3.2 and 2.7

    @terryjreedy
    Copy link
    Member

    Thanks for applying.
    Just note that unlike with svn, with hg it is stronly recommended to apply to 3.2 first and forward port to 3.3. Something about the DAGs working better.

    @asvetlov
    Copy link
    Contributor

    Will do in next time.
    Thank you for instructions.

    @merwok
    Copy link
    Member

    merwok commented Mar 21, 2012

    3-22 00:26

    with hg it is stronly recommended to apply to 3.2 first and forward port to 3.3.
    Something about the DAGs working better.

    The default branch (3.3) is a superset of 3.2: all bug fixes are in both branches, and new features are in 3.3 only. We’ve chosen the simplest way to achieve that with Mercurial: we commit to 3.2 and merge into default. This ensures that no fix committed to one version is forgotten in the other, and also automates the file merging. That’s just it.

    @merwok
    Copy link
    Member

    merwok commented Mar 21, 2012

    (Edited for typos, ignore the “3-22 00:26” that comes from I don’t know where)

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @asvetlov asvetlov

    Labels
    stdlib Python modules in the Lib dir topic-IDLE type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    3 participants
    @asvetlov @merwok @terryjreedy