Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IDLE: Fix and test debugger. #79871

Closed
terryjreedy opened this issue Jan 9, 2019 · 3 comments
Closed

IDLE: Fix and test debugger. #79871

terryjreedy opened this issue Jan 9, 2019 · 3 comments
Assignees
@terryjreedy
Labels
tests Tests in the Lib/test dir topic-IDLE type-bug An unexpected behavior, bug, or error

Comments

@terryjreedy
Copy link
Member

terryjreedy commented Jan 9, 2019 •
edited by bedevere-app bot

BPO 35690
Nosy @terryjreedy
PRs
  • gh-79871: IDLE - Fix and test debugger module #11451
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/terryjreedy'
closed_at = None
created_at = <Date 2019-01-09.00:07:08.597>
labels = ['3.8', 'expert-IDLE', 'type-bug', '3.7']
title = 'IDLE: Fix and test debugger.'
updated_at = <Date 2019-01-09.00:08:05.421>
user = 'https://github.com/terryjreedy'

    bugs.python.org fields:

    activity = <Date 2019-01-09.00:08:05.421>
actor = 'anthonypjshaw'
assignee = 'terry.reedy'
closed = False
closed_date = None
closer = None
components = ['IDLE']
creation = <Date 2019-01-09.00:07:08.597>
creator = 'terry.reedy'
dependencies = []
files = []
hgrepos = []
issue_num = 35690
keywords = ['patch']
message_count = 1.0
messages = ['333267']
nosy_count = 1.0
nosy_names = ['terry.reedy']
pr_nums = ['11451']
priority = 'normal'
resolution = None
stage = 'patch review'
status = 'open'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue35690'
versions = ['Python 3.7', 'Python 3.8']

    Linked PRs
    @terryjreedy
    Copy link
    Member Author

    terryjreedy commented Jan 9, 2019 •
    edited

    Move PR 11451 from #79849.

    • Remove use of blank comments to make blank lines.
    • Greatly expand test_debugger.
    • Fix a couple of issues discovered while writing tests. (It is possible that one of these caused one of the reported debugger bugs, but we don't need to determine that now.)

    @terryjreedy terryjreedy added 3.7 (EOL) end of life 3.8 only security fixes type-bug An unexpected behavior, bug, or error topic-IDLE labels Jan 9, 2019
    @terryjreedy terryjreedy self-assigned this Jan 9, 2019
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    @bedevere-bot bedevere-bot mentioned this issue Nov 2, 2022
    Merged
    @terryjreedy terryjreedy added tests Tests in the Lib/test dir and removed 3.8 only security fixes 3.7 (EOL) end of life labels May 12, 2023
    terryjreedy pushed a commit that referenced this issue Nov 19, 2023
    @tonybaloney
    gh-79871: IDLE - Fix and test debugger module (#11451)
    adedcfa 
    Add docstrings to the debugger module. Fix two bugs: initialize Idb.botframe (should be in Bdb); In Idb.in_rpc_code, check whether prev_frame is None before trying to use it. Make other code changes.

Expand test_debugger coverage from 19% to 66%.
---------
Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
    miss-islington pushed a commit to miss-islington/cpython that referenced this issue Nov 19, 2023
    @tonybaloney @miss-islington
    pythongh-79871: IDLE - Fix and test debugger module (pythonGH-11451)
    e93be42 
    Add docstrings to the debugger module. Fix two bugs: initialize Idb.botframe (should be in Bdb); In Idb.in_rpc_code, check whether prev_frame is None before trying to use it. Make other code changes.

Expand test_debugger coverage from 19% to 66%.
---------
Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
(cherry picked from commit adedcfa)

Co-authored-by: Anthony Shaw <anthony.p.shaw@gmail.com>
    @bedevere-app bedevere-app bot mentioned this issue Nov 19, 2023
    Merged
    miss-islington pushed a commit to miss-islington/cpython that referenced this issue Nov 19, 2023
    @tonybaloney @miss-islington
    pythongh-79871: IDLE - Fix and test debugger module (pythonGH-11451)
    5e70ce8 
    Add docstrings to the debugger module. Fix two bugs: initialize Idb.botframe (should be in Bdb); In Idb.in_rpc_code, check whether prev_frame is None before trying to use it. Make other code changes.

Expand test_debugger coverage from 19% to 66%.
---------
Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
(cherry picked from commit adedcfa)

Co-authored-by: Anthony Shaw <anthony.p.shaw@gmail.com>
    @bedevere-app bedevere-app bot mentioned this issue Nov 19, 2023
    Merged
    terryjreedy added a commit that referenced this issue Nov 19, 2023
    @miss-islington @tonybaloney @terryjreedy
    [3.11] gh-79871: IDLE - Fix and test debugger module (GH-11451) (#112257
    e19d75d 
    )

Add docstrings to the debugger module. Fix two bugs: initialize Idb.botframe (should be in Bdb); In Idb.in_rpc_code, check whether prev_frame is None before trying to use it. Make other code changes.

Expand test_debugger coverage from 19% to 66%.
---------

(cherry picked from commit adedcfa)

Co-authored-by: Anthony Shaw <anthony.p.shaw@gmail.com>
Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
    terryjreedy added a commit that referenced this issue Nov 19, 2023
    @miss-islington @tonybaloney @terryjreedy
    [3.12] gh-79871: IDLE - Fix and test debugger module (GH-11451) (#112256
    a62dcac 
    )

gh-79871: IDLE - Fix and test debugger module (GH-11451)

Add docstrings to the debugger module. Fix two bugs: initialize Idb.botframe (should be in Bdb); In Idb.in_rpc_code, check whether prev_frame is None before trying to use it. Make other code changes.

Expand test_debugger coverage from 19% to 66%.
---------

(cherry picked from commit adedcfa)

Co-authored-by: Anthony Shaw <anthony.p.shaw@gmail.com>
Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
    @corona10
    Copy link
    Member

    @terryjreedy Did you check the buildbot failure? #11451 (comment)

    This was referenced Nov 19, 2023
    Merged
    Merged
    Merged
    @terryjreedy
    Copy link
    Member Author

    Fix merged and backported

    aisk pushed a commit to aisk/cpython that referenced this issue Feb 11, 2024
    @tonybaloney @aisk
    pythongh-79871: IDLE - Fix and test debugger module (python#11451)
    470aaa2 
    Add docstrings to the debugger module. Fix two bugs: initialize Idb.botframe (should be in Bdb); In Idb.in_rpc_code, check whether prev_frame is None before trying to use it. Make other code changes.

Expand test_debugger coverage from 19% to 66%.
---------
Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @terryjreedy terryjreedy

    Labels
    tests Tests in the Lib/test dir topic-IDLE type-bug An unexpected behavior, bug, or error
    Projects
    IDLE Issues
    Status: Done
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @corona10 @terryjreedy