Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add use_srcentry parameter to shutil.copytree() II #79833

Closed
xxxxxxx mannequin opened this issue Jan 3, 2019 · 3 comments
Closed

Add use_srcentry parameter to shutil.copytree() II #79833

xxxxxxx mannequin opened this issue Jan 3, 2019 · 3 comments
Labels
3.8 only security fixes stdlib Python modules in the Lib dir type-feature A feature request or enhancement

Comments

@xxxxxxx
Copy link
Mannequin

xxxxxxx mannequin commented Jan 3, 2019

BPO 35652
Nosy @giampaolo
PRs
  • bpo-35652 Add use_srcentry parameter to shutil.copytree() II #11425
  • bpo-35652: shutil.copytree(copy_function=...): pass DirEntry instead of path str  #11997
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2019-02-23.16:36:46.970>
created_at = <Date 2019-01-03.18:57:45.110>
labels = ['3.8', 'type-feature', 'library']
title = 'Add use_srcentry parameter to shutil.copytree() II'
updated_at = <Date 2019-02-26.11:04:47.692>
user = 'https://bugs.python.org/xxxxxxx'

    bugs.python.org fields:

    activity = <Date 2019-02-26.11:04:47.692>
actor = 'giampaolo.rodola'
assignee = 'none'
closed = True
closed_date = <Date 2019-02-23.16:36:46.970>
closer = 'giampaolo.rodola'
components = ['Library (Lib)']
creation = <Date 2019-01-03.18:57:45.110>
creator = 'xxxxxxx'
dependencies = []
files = []
hgrepos = []
issue_num = 35652
keywords = ['patch']
message_count = 3.0
messages = ['332941', '336387', '336645']
nosy_count = 2.0
nosy_names = ['giampaolo.rodola', 'xxxxxxx']
pr_nums = ['11425', '11997']
priority = 'normal'
resolution = 'duplicate'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue35652'
versions = ['Python 3.8']
    @xxxxxxx
    Copy link
    Mannequin Author

    xxxxxxx mannequin commented Jan 3, 2019

    Currently it is decided if to use the srcentry in the copy_function by checking if the copy_function is copy() or copy2(). This will fail if the copy_function is a modified copy() or copy2() function. To control if the copy_function gets a srcentry or srcname parameter, added the use_srcentry parameter.

    Successor of https://bugs.python.org/issue35648

    @xxxxxxx xxxxxxx mannequin added 3.8 only security fixes stdlib Python modules in the Lib dir type-feature A feature request or enhancement labels Jan 3, 2019
    @giampaolo
    Copy link
    Contributor

    Not sure why you created 2 identical issues. Closing this one as a duplicate of bpo-35648.

    @giampaolo
    Copy link
    Contributor

    New changeset c606a9c by Giampaolo Rodola in branch 'master':
    bpo-35652: shutil.copytree(copy_function=...) erroneously pass DirEntry instead of path str (GH-11997)
    c606a9c

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.8 only security fixes stdlib Python modules in the Lib dir type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    1 participant
    @giampaolo