Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Segfault in test_bigmem.ListTest.test_sort #79804

Closed
sth mannequin opened this issue Dec 31, 2018 · 4 comments
Closed

Segfault in test_bigmem.ListTest.test_sort #79804

sth mannequin opened this issue Dec 31, 2018 · 4 comments
Labels
3.7 (EOL) end of life 3.8 only security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) type-crash A hard crash of the interpreter, possibly with a core dump

Comments

@sth
Copy link
Mannequin

sth mannequin commented Dec 31, 2018

BPO 35623
Nosy @tim-one, @benjaminp, @sth, @serhiy-storchaka, @miss-islington
PRs
  • bpo-35623: Fix integer overflow when sorting large lists #11380
  • bpo-35623: Fix integer overflow when sorting large lists #11380
  • bpo-35623: Fix integer overflow when sorting large lists #11380
  • [3.7] closes bpo-35623: Fix integer overflow when sorting large lists (GH-11380) #11401
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2019-01-02.02:01:58.737>
created_at = <Date 2018-12-31.01:16:28.768>
labels = ['interpreter-core', '3.7', '3.8', 'type-crash']
title = 'Segfault in test_bigmem.ListTest.test_sort'
updated_at = <Date 2019-01-02.02:25:25.357>
user = 'https://github.com/sth'

    bugs.python.org fields:

    activity = <Date 2019-01-02.02:25:25.357>
actor = 'miss-islington'
assignee = 'none'
closed = True
closed_date = <Date 2019-01-02.02:01:58.737>
closer = 'benjamin.peterson'
components = ['Interpreter Core']
creation = <Date 2018-12-31.01:16:28.768>
creator = 'sth'
dependencies = []
files = []
hgrepos = []
issue_num = 35623
keywords = ['patch', 'patch', 'patch']
message_count = 4.0
messages = ['332780', '332783', '332852', '332856']
nosy_count = 5.0
nosy_names = ['tim.peters', 'benjamin.peterson', 'sth', 'serhiy.storchaka', 'miss-islington']
pr_nums = ['11380', '11380', '11380', '11401']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'crash'
url = 'https://bugs.python.org/issue35623'
versions = ['Python 3.7', 'Python 3.8']
    @sth
    Copy link
    Mannequin Author

    sth mannequin commented Dec 31, 2018

    When running test_bigmem with -M 30G the interpreter crashes in list_sort_impl() in Objects/listobject.c:2290 due to an integer overflow in i.

    @sth sth mannequin added 3.7 (EOL) end of life 3.8 only security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) type-crash A hard crash of the interpreter, possibly with a core dump labels Dec 31, 2018
    @sth
    Copy link
    Mannequin Author

    sth mannequin commented Dec 31, 2018

    Actually the segfault is in Objects/listobject.c:2301 in that test since it doesn't use tuples. But the takeaway is the same: i overflows to a negative number and causes an invalid memory access.

    @benjaminp
    Copy link
    Contributor

    New changeset f8b5344 by Benjamin Peterson (sth) in branch 'master':
    closes bpo-35623: Fix integer overflow when sorting large lists (GH-11380)
    f8b5344

    @miss-islington
    Copy link
    Contributor

    New changeset a5955b0 by Miss Islington (bot) in branch '3.7':
    closes bpo-35623: Fix integer overflow when sorting large lists (GH-11380)
    a5955b0

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.7 (EOL) end of life 3.8 only security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) type-crash A hard crash of the interpreter, possibly with a core dump
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @benjaminp @miss-islington