Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_future4 ran no test #79593

Closed
vstinner opened this issue Dec 4, 2018 · 10 comments
Closed

test_future4 ran no test #79593

vstinner opened this issue Dec 4, 2018 · 10 comments
Labels
3.8 only security fixes

Comments

@vstinner
Copy link
Member

vstinner commented Dec 4, 2018

BPO 35412
Nosy @vstinner, @pablogsal, @miss-islington
PRs
  • bpo-35412: Skip test_multiprocessing_fork and test_multiprocessing_forkserver on Windows #11086
  • [3.6] bpo-35412: Skip test_multiprocessing_fork and test_multiprocessing_forkserver on Windows (GH-11086) #11115
  • [3.7] bpo-35412: Skip test_multiprocessing_fork and test_multiprocessing_forkserver on Windows (GH-11086) #11116
  • bpo-35412: Add testcase to test_future4 #11131
  • bpo-34279: regrtest consider that skipped tests are ran #11132
  • [3.7] bpo-34279: regrtest consider that skipped tests are ran (GH-11132) #11155
  • [3.6] bpo-34279: regrtest consider that skipped tests are ran (GH-11132) #11156
  • [2.7] bpo-34279: regrtest consider that skipped tests are ran (GH-11132) #11158
  • [3.7] bpo-35412: Add testcase to test_future4 (GH-11131) #11183
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2018-12-14.17:05:48.846>
    created_at = <Date 2018-12-04.22:37:17.097>
    labels = ['3.8']
    title = 'test_future4 ran no test'
    updated_at = <Date 2018-12-17.08:34:13.101>
    user = 'https://github.com/vstinner'

    bugs.python.org fields:

    activity = <Date 2018-12-17.08:34:13.101>
    actor = 'vstinner'
    assignee = 'none'
    closed = True
    closed_date = <Date 2018-12-14.17:05:48.846>
    closer = 'vstinner'
    components = []
    creation = <Date 2018-12-04.22:37:17.097>
    creator = 'vstinner'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 35412
    keywords = ['patch']
    message_count = 10.0
    messages = ['331080', '331131', '331612', '331616', '331617', '331712', '331809', '331819', '331825', '331950']
    nosy_count = 3.0
    nosy_names = ['vstinner', 'pablogsal', 'miss-islington']
    pr_nums = ['11086', '11115', '11116', '11131', '11132', '11155', '11156', '11158', '11183']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = None
    url = 'https://bugs.python.org/issue35412'
    versions = ['Python 3.8']

    @vstinner
    Copy link
    Member Author

    vstinner commented Dec 4, 2018

    Since bpo-34279 has been fixed, regrtest now logs a message when a test runs no test. I noticed that test_future4 logs such message:

    ...
    0:05:23 load avg: 0.56 [152/412] test_future4
    0:05:24 load avg: 0.56 [153/412] test_future5 -- test_future4 run no tests
    ...
    2 tests run no tests:
    test_dtrace test_future4

    I can reproduce the issue:

    $ ./python -m test test_future4
    (...)
    test_future4 run no tests
    (...)
    Tests result: NO TEST RUN

    The test has been added by:
    commit 62e2c7e
    Author: Jeremy Hylton <jeremy@alum.mit.edu>
    Date: Wed Feb 28 17:48:06 2001 +0000

    Add regression test for future statements.  This adds eight files, but
    seven are not tests in their own right; these files are mentioned in
    regrtest.
    
    diff --git a/Lib/test/test_future4.py b/Lib/test/test_future4.py
    new file mode 100644
    index 0000000000..805263be89
    --- /dev/null
    +++ b/Lib/test/test_future4.py
    @@ -0,0 +1,10 @@
    +"""This is a test"""
    +import __future__
    +from __future__ import nested_scopes
    +
    +def f(x):
    +    def g(y):
    +        return x + y
    +    return g
    +
    +print f(2)(4)

    ... test removed by commit 3090694.

    A file recreated by:

    commit fa50bad
    Author: Christian Heimes <christian@cheimes.de>
    Date: Wed Mar 26 22:55:31 2008 +0000

    I forgot to svn add the future test
    

    ... I guess that it's related to:

    commit 3c60833
    Author: Christian Heimes <christian@cheimes.de>
    Date: Wed Mar 26 22:01:37 2008 +0000

    Patch bpo-2477: Added from __future__ import unicode_literals
    
    The new PyParser_*Ex() functions are based on Neal's suggestion and initial patch. The new __future__ feature makes all '' and r'' unicode strings. b'' and br'' stay (byte) strings.
    

    (Other candidates: commit 342212c and commit 7f23d86.)

    @vstinner vstinner added the 3.8 only security fixes label Dec 4, 2018
    @vstinner
    Copy link
    Member Author

    vstinner commented Dec 5, 2018

    There are a few more on Windows:

    4 tests run no tests:
    test_dtrace test_future4 test_multiprocessing_fork
    test_multiprocessing_forkserver

    test_multiprocessing_fork and test_multiprocessing_forkserver should raise SkipTest on Windows.

    @pablogsal
    Copy link
    Member

    New changeset a932d0b by Pablo Galindo in branch 'master':
    bpo-35412: Skip test_multiprocessing_fork and test_multiprocessing_forkserver on Windows (GH-11086)
    a932d0b

    @miss-islington
    Copy link
    Contributor

    New changeset d55a896 by Miss Islington (bot) in branch '3.7':
    bpo-35412: Skip test_multiprocessing_fork and test_multiprocessing_forkserver on Windows (GH-11086)
    d55a896

    @miss-islington
    Copy link
    Contributor

    New changeset 9756876 by Miss Islington (bot) in branch '3.6':
    bpo-35412: Skip test_multiprocessing_fork and test_multiprocessing_forkserver on Windows (GH-11086)
    9756876

    @vstinner
    Copy link
    Member Author

    New changeset 502fe19 by Victor Stinner in branch 'master':
    bpo-35412: Add testcase to test_future4 (GH-11131)
    502fe19

    @vstinner
    Copy link
    Member Author

    New changeset 3a8f4fe by Victor Stinner in branch 'master':
    bpo-34279: regrtest consider that skipped tests are ran (GH-11132)
    3a8f4fe

    @miss-islington
    Copy link
    Contributor

    New changeset 5f252e1 by Miss Islington (bot) in branch '3.7':
    bpo-34279: regrtest consider that skipped tests are ran (GH-11132)
    5f252e1

    @vstinner
    Copy link
    Member Author

    New changeset 34b7c43 by Victor Stinner in branch '2.7':
    bpo-34279: regrtest consider that skipped tests are ran (GH-11132) (GH-11158)
    34b7c43

    @vstinner
    Copy link
    Member Author

    New changeset 2d91a13 by Victor Stinner (Miss Islington (bot)) in branch '3.7':
    bpo-35412: Add testcase to test_future4 (GH-11131) (GH-11183)
    2d91a13

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.8 only security fixes
    Projects
    None yet
    Development

    No branches or pull requests

    3 participants