Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade macOS and Windows installers to Tcl 8.6.9 and Tk 8.6.9.1 #79583

Closed
ned-deily opened this issue Dec 4, 2018 · 21 comments
Closed

Upgrade macOS and Windows installers to Tcl 8.6.9 and Tk 8.6.9.1 #79583

ned-deily opened this issue Dec 4, 2018 · 21 comments
Labels
3.7 (EOL) end of life 3.8 only security fixes OS-mac OS-windows

Comments

@ned-deily
Copy link
Member

BPO 35402
Nosy @terryjreedy, @pfmoore, @ronaldoussoren, @tjguk, @ned-deily, @zware, @serhiy-storchaka, @zooba, @miss-islington
PRs
  • bpo-35402: Update macOS installer to use Tcl 8.6.9 / Tk 8.6.9.1 #11101
  • [3.7] bpo-35402: Update macOS installer to use Tcl 8.6.9 / Tk 8.6.9.1 (GH-11101) #11102
  • [3.6] bpo-35402: Update macOS installer to use Tcl 8.6.9 / Tk 8.6.9.1 (GH-11101) #11103
  • [2.7] bpo-35402: Update macOS installer to use Tcl 8.6.9 / Tk 8.6.9.1 (GH-11101) #11104
  • bpo-35402: Update Windows build to use Tcl and Tk 8.6.9 #11146
  • [3.7] bpo-35402: Update Windows build to use Tcl and Tk 8.6.9 (GH-11146) #11163
  • Revert "bpo-35402: Update macOS installer to use Tcl 8.6.9 / Tk 8.6.9.1 (GH-11101)" #11332
    		•
    Superseder
  • bpo-35485: tkinter windows turn black while resized using Tk 8.6.9.1 on macOS
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2018-12-28.00:50:33.817>
created_at = <Date 2018-12-04.07:22:40.002>
labels = ['OS-mac', '3.7', '3.8', 'OS-windows']
title = 'Upgrade macOS and Windows installers to Tcl 8.6.9 and Tk 8.6.9.1'
updated_at = <Date 2018-12-28.00:50:33.815>
user = 'https://github.com/ned-deily'

    bugs.python.org fields:

    activity = <Date 2018-12-28.00:50:33.815>
actor = 'ned.deily'
assignee = 'none'
closed = True
closed_date = <Date 2018-12-28.00:50:33.817>
closer = 'ned.deily'
components = ['macOS', 'Windows']
creation = <Date 2018-12-04.07:22:40.002>
creator = 'ned.deily'
dependencies = []
files = []
hgrepos = []
issue_num = 35402
keywords = ['patch']
message_count = 21.0
messages = ['331011', '331360', '331578', '331581', '331582', '331586', '331587', '331643', '331656', '331657', '331667', '331771', '331842', '331844', '331884', '332482', '332483', '332487', '332613', '332620', '332629']
nosy_count = 9.0
nosy_names = ['terry.reedy', 'paul.moore', 'ronaldoussoren', 'tim.golden', 'ned.deily', 'zach.ware', 'serhiy.storchaka', 'steve.dower', 'miss-islington']
pr_nums = ['11101', '11102', '11103', '11104', '11146', '11163', '11332']
priority = 'normal'
resolution = 'duplicate'
stage = 'resolved'
status = 'closed'
superseder = '35485'
type = None
url = 'https://bugs.python.org/issue35402'
versions = ['Python 2.7', 'Python 3.7', 'Python 3.8']
    @ned-deily
    Copy link
    Member Author

    Tcl/Tk 8.6.9 (followed by Tk 8.6.9.1) was released recently. Among other things, they contain fixes for various issues on macOS, some of which have been seen by macOS users of IDLE and other tkinter apps, so the macOS installer should definitely be updated for 3.7.2, 3.6.8, and 2.7.16.

    @ned-deily ned-deily added 3.8 only security fixes 3.7 (EOL) end of life OS-mac OS-windows labels Dec 4, 2018
    @terryjreedy
    Copy link
    Member

    ... and master.

    I believe for Windows the policy has been to stick with one tcl/tk version for a Python version. But I don't know that this is written on stone. If not too much trouble, I would like master updated occasionally during the a1 period rather than just once around b1. I am not sure about backports.

    @ned-deily
    Copy link
    Member Author

    New changeset 7cf3d8e by Ned Deily in branch 'master':
    bpo-35402: Update macOS installer to use Tcl 8.6.9 / Tk 8.6.9.1 (GH-11101)
    7cf3d8e

    @miss-islington
    Copy link
    Contributor

    New changeset 3b9a018 by Miss Islington (bot) in branch '3.7':
    bpo-35402: Update macOS installer to use Tcl 8.6.9 / Tk 8.6.9.1 (GH-11101)
    3b9a018

    @miss-islington
    Copy link
    Contributor

    New changeset 37607f2 by Miss Islington (bot) in branch '3.6':
    bpo-35402: Update macOS installer to use Tcl 8.6.9 / Tk 8.6.9.1 (GH-11101)
    37607f2

    @miss-islington
    Copy link
    Contributor

    New changeset aa58050 by Miss Islington (bot) in branch '2.7':
    bpo-35402: Update macOS installer to use Tcl 8.6.9 / Tk 8.6.9.1 (GH-11101)
    aa58050

    @ned-deily
    Copy link
    Member Author

    The macOS installers will use Tcl 8.6.9 and Tk 8.6.9.1 starting with 3.7.2rc1 and 3.6.8rc1. Due to time constraints, the Windows builds will get updated later.

    @ned-deily ned-deily changed the title Upgrade macOS (and Windows?) installer to Tcl/Tk 8.6.9.1 Upgrade macOS and Windows installers to Tcl 8.6.9 and Tk 8.6.9.1 Dec 11, 2018
    @zooba
    Copy link
    Member

    zooba commented Dec 11, 2018

    I pushed the raw Tcl and Tk sources for 8.6.9.0 to cpython-source-deps, but it looks like we need some patches to be able to build on Windows (the X11 headers #define some names that the Windows headers want to use as struct members).

    So far I've needed to #undef and redefine None and ControlMask around #include <Windows.h> in winmain.c and tkWin.h, but I think that will be enough.

    @zooba
    Copy link
    Member

    zooba commented Dec 11, 2018

    Looks like Tix needs similar updates, since it imports the Tk headers. Perhaps it'll be easier to undef immediately after the X11\X.h include? Assuming the values aren't actually being used anywhere.

    @ned-deily
    Copy link
    Member Author

    Should the problems be reported upstream?

    @zooba
    Copy link
    Member

    zooba commented Dec 11, 2018

    Probably. I'm 99% sure it's a problem with the latest build tools, and nothing to do with Python. Though I haven't checked out whether we're injecting any compile time flags that may be causing extra things to be included - I have no idea why X11 is necessary, for example.

    @zooba
    Copy link
    Member

    zooba commented Dec 13, 2018

    Setting DefaultWindowsSdkVersion to 10.0.15063.0 seems to work for the Python 3.7 and 3.8 builds.

    Unless there's a security reason (which I don't believe there is), there's no need to worry about 3.6.

    @zooba
    Copy link
    Member

    zooba commented Dec 14, 2018

    New changeset f8e9bd5 by Steve Dower in branch 'master':
    bpo-35402: Update Windows build to use Tcl and Tk 8.6.9 (GH-11146)
    f8e9bd5

    @zooba
    Copy link
    Member

    zooba commented Dec 14, 2018

    New changeset 77824ef by Steve Dower (Miss Islington (bot)) in branch '3.7':
    bpo-35402: Update Windows build to use Tcl and Tk 8.6.9 (GH-11146)
    77824ef

    @terryjreedy
    Copy link
    Member

    Thank you both for the updates. After I wrote my previous message, I realized that there is a difference between updating tcl/tk to take advantage of bug fixes (after testing for regressions), and enhancing tkinter to give directly access to new tk features from Python. The latter can still be deferred to the next version.

    @ned-deily
    Copy link
    Member Author

    New changeset e5fdab2 by Ned Deily in branch '3.6':
    Revert "bpo-35402: Update macOS installer to use Tcl 8.6.9 / Tk 8.6.9.1 (GH-11101)"
    e5fdab2

    1 similar comment
    @ned-deily
    Copy link
    Member Author

    New changeset e5fdab2 by Ned Deily in branch '3.6':
    Revert "bpo-35402: Update macOS installer to use Tcl 8.6.9 / Tk 8.6.9.1 (GH-11101)"
    e5fdab2

    @ned-deily
    Copy link
    Member Author

    New changeset 986a9ab by Ned Deily in branch '3.7':
    Revert "bpo-35402: Update macOS installer to use Tcl 8.6.9 / Tk 8.6.9.1 (GH-11101)"
    986a9ab

    @ned-deily
    Copy link
    Member Author

    New changeset c540c4e by Ned Deily in branch '2.7':
    Revert "bpo-35402: Update macOS installer to use Tcl 8.6.9 / Tk 8.6.9.1 (GH-11101)"
    c540c4e

    @miss-islington
    Copy link
    Contributor

    New changeset a936639 by Miss Islington (bot) (Ned Deily) in branch 'master':
    Revert "bpo-35402: Update macOS installer to use Tcl 8.6.9 / Tk 8.6.9.1 (GH-11101)" (GH-11332)
    a936639

    @ned-deily
    Copy link
    Member Author

    See discussion in bpo-35485. Regressions were found on macOS with Tk 8.6.9.1 and with the more recent Tk 8.6 maintenance branch top of trunk. So for python.org macOS installers, we have reverted to Tcl/Tk 8.6.8. Windows builds will continue to use 8.6.9 unless problems are found.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.7 (EOL) end of life 3.8 only security fixes OS-mac OS-windows
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    4 participants
    @zooba @ned-deily @terryjreedy @miss-islington