Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add __slots__ = () to asyncio protocols #79575

Closed
asvetlov opened this issue Dec 3, 2018 · 2 comments
Closed

Add __slots__ = () to asyncio protocols #79575

asvetlov opened this issue Dec 3, 2018 · 2 comments
Labels
3.8 only security fixes topic-asyncio

Comments

@asvetlov
Copy link
Contributor

asvetlov commented Dec 3, 2018

BPO 35394
Nosy @asvetlov, @1st1
PRs
  • bpo-35394: Add empty slots to abstract asyncio protocols #10889
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2018-12-18.21:59:58.322>
created_at = <Date 2018-12-03.21:59:26.910>
labels = ['3.8', 'expert-asyncio']
title = 'Add __slots__ = () to asyncio protocols'
updated_at = <Date 2018-12-18.21:59:58.321>
user = 'https://github.com/asvetlov'

    bugs.python.org fields:

    activity = <Date 2018-12-18.21:59:58.321>
actor = 'asvetlov'
assignee = 'none'
closed = True
closed_date = <Date 2018-12-18.21:59:58.322>
closer = 'asvetlov'
components = ['asyncio']
creation = <Date 2018-12-03.21:59:26.910>
creator = 'asvetlov'
dependencies = []
files = []
hgrepos = []
issue_num = 35394
keywords = ['patch']
message_count = 2.0
messages = ['330986', '331641']
nosy_count = 2.0
nosy_names = ['asvetlov', 'yselivanov']
pr_nums = ['10889']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue35394'
versions = ['Python 3.8']
    @asvetlov
    Copy link
    Contributor Author

    asvetlov commented Dec 3, 2018

    Protocols have no members.

    Adding empty slots doesn't harm any existing code but it allows to write proper protocol implementation with slot-based class.

    @asvetlov asvetlov added 3.8 only security fixes topic-asyncio labels Dec 3, 2018
    @asvetlov
    Copy link
    Contributor Author

    New changeset 5344501 by Andrew Svetlov in branch 'master':
    bpo-35394: Add empty slots to abstract asyncio protocols (bpo-10889)
    5344501

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.8 only security fixes topic-asyncio
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    1 participant
    @asvetlov