Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix undefined behavior in os.utime() on Windows #79552

Closed
serhiy-storchaka opened this issue Dec 1, 2018 · 4 comments
Closed

Fix undefined behavior in os.utime() on Windows #79552

serhiy-storchaka opened this issue Dec 1, 2018 · 4 comments
Assignees
Labels
3.7 (EOL) end of life 3.8 only security fixes extension-modules C modules in the Modules dir type-crash A hard crash of the interpreter, possibly with a core dump

Comments

@serhiy-storchaka
Copy link
Member

BPO 35371
Nosy @serhiy-storchaka, @miss-islington
PRs
  • bpo-35371: Fix possible crash in os.utime() on Windows. #10844
  • [3.7] bpo-35371: Fix possible crash in os.utime() on Windows. (GH-10844) #10845
  • [3.6] bpo-35371: Fix possible crash in os.utime() on Windows. (GH-10844) #10846
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/serhiy-storchaka'
    closed_at = <Date 2018-12-01.18:10:31.219>
    created_at = <Date 2018-12-01.11:42:07.960>
    labels = ['extension-modules', '3.7', '3.8', 'type-crash']
    title = 'Fix undefined behavior in os.utime() on Windows'
    updated_at = <Date 2018-12-01.18:10:31.218>
    user = 'https://github.com/serhiy-storchaka'

    bugs.python.org fields:

    activity = <Date 2018-12-01.18:10:31.218>
    actor = 'serhiy.storchaka'
    assignee = 'serhiy.storchaka'
    closed = True
    closed_date = <Date 2018-12-01.18:10:31.219>
    closer = 'serhiy.storchaka'
    components = ['Extension Modules']
    creation = <Date 2018-12-01.11:42:07.960>
    creator = 'serhiy.storchaka'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 35371
    keywords = ['patch']
    message_count = 4.0
    messages = ['330850', '330851', '330852', '330853']
    nosy_count = 2.0
    nosy_names = ['serhiy.storchaka', 'miss-islington']
    pr_nums = ['10844', '10845', '10846']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'crash'
    url = 'https://bugs.python.org/issue35371'
    versions = ['Python 3.6', 'Python 3.7', 'Python 3.8']

    @serhiy-storchaka
    Copy link
    Member Author

    The hFile variable is used uninitialized in os.utime() on Windows when an error is raised in arguments parsing. This is an undefined behavior, and can cause a crash.

    @serhiy-storchaka serhiy-storchaka added 3.7 (EOL) end of life 3.8 only security fixes labels Dec 1, 2018
    @serhiy-storchaka serhiy-storchaka self-assigned this Dec 1, 2018
    @serhiy-storchaka serhiy-storchaka added extension-modules C modules in the Modules dir type-crash A hard crash of the interpreter, possibly with a core dump labels Dec 1, 2018
    @serhiy-storchaka
    Copy link
    Member Author

    New changeset 32bc11c by Serhiy Storchaka in branch 'master':
    bpo-35371: Fix possible crash in os.utime() on Windows. (GH-10844)
    32bc11c

    @miss-islington
    Copy link
    Contributor

    New changeset 265b419 by Miss Islington (bot) in branch '3.7':
    bpo-35371: Fix possible crash in os.utime() on Windows. (GH-10844)
    265b419

    @miss-islington
    Copy link
    Contributor

    New changeset 013832f by Miss Islington (bot) in branch '3.6':
    bpo-35371: Fix possible crash in os.utime() on Windows. (GH-10844)
    013832f

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.7 (EOL) end of life 3.8 only security fixes extension-modules C modules in the Modules dir type-crash A hard crash of the interpreter, possibly with a core dump
    Projects
    None yet
    Development

    No branches or pull requests

    2 participants