Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_eintr: test_open() hangs randomly on x86-64 El Capitan 3.x buildbot #79544

Closed
vstinner opened this issue Nov 30, 2018 · 14 comments
Closed

test_eintr: test_open() hangs randomly on x86-64 El Capitan 3.x buildbot #79544

vstinner opened this issue Nov 30, 2018 · 14 comments
Labels
3.8 only security fixes tests Tests in the Lib/test dir

Comments

@vstinner
Copy link
Member

BPO 35363
Nosy @vstinner, @pablogsal, @miss-islington
PRs
  • bpo-35363: test_eintr: skip test_open() on macOS #10896
  • [3.7] bpo-35363, test_eintr: skip test_open() on macOS (GH-10896) #10898
  • [3.6] bpo-35363, test_eintr: skip test_open() on macOS (GH-10896) #10899
  • [3.7] bpo-35363, test_eintr: skip test_open() on macOS (GH-10896) #10911
  • [3.6] bpo-35363, test_eintr: skip test_open() on macOS (GH-10896) #10912
  • bpo-35363: test_eintr runs eintr_tester.py in verbose mode #10965
  • [3.7] bpo-35363: test_eintr runs eintr_tester.py in verbose mode (GH-10965) #10966
  • [3.6] bpo-35363: test_eintr runs eintr_tester.py in verbose mode (GH-10965) #10967
  • bpo-35363: test_eintr uses print(flush=True) #10990
  • [3.7] bpo-35363: test_eintr uses print(flush=True) (GH-10990) #10992
  • [3.6] bpo-35363: test_eintr uses print(flush=True) (GH-10990) #10993
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2018-12-05.02:04:14.097>
created_at = <Date 2018-11-30.15:54:17.027>
labels = ['3.8', 'tests']
title = 'test_eintr: test_open() hangs randomly on x86-64 El Capitan 3.x buildbot'
updated_at = <Date 2019-05-21.22:34:15.897>
user = 'https://github.com/vstinner'

    bugs.python.org fields:

    activity = <Date 2019-05-21.22:34:15.897>
actor = 'vstinner'
assignee = 'none'
closed = True
closed_date = <Date 2018-12-05.02:04:14.097>
closer = 'vstinner'
components = ['Tests']
creation = <Date 2018-11-30.15:54:17.027>
creator = 'vstinner'
dependencies = []
files = []
hgrepos = []
issue_num = 35363
keywords = ['patch']
message_count = 14.0
messages = ['330795', '330796', '330801', '331055', '331059', '331088', '331089', '331192', '331193', '331194', '331234', '331235', '331236', '331237']
nosy_count = 3.0
nosy_names = ['vstinner', 'pablogsal', 'miss-islington']
pr_nums = ['10896', '10898', '10899', '10911', '10912', '10965', '10966', '10967', '10990', '10992', '10993']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue35363'
versions = ['Python 3.8']
    @vstinner
    Copy link
    Member Author

    test_open() of test_eintr hangs randomly on x86-64 El Capitan 3.x buildbot. test_eintr failed but then passed when run again.

    pythoninfo:

    platform.platform: Darwin-15.6.0-x86_64-i386-64bit # macOS 10.11 (El Capitan)

    https://buildbot.python.org/all/#/builders/93/builds/1574

    test_all (test.test_eintr.EINTRTests) ... FAIL

    ======================================================================
    FAIL: test_all (test.test_eintr.EINTRTests)
    ----------------------------------------------------------------------

    Traceback (most recent call last):
  File "/Users/buildbot/buildarea/3.x.billenstein-elcapitan/build/Lib/test/test_eintr.py", line 18, in test_all
    script_helper.assert_python_ok("-u", tester)
  File "/Users/buildbot/buildarea/3.x.billenstein-elcapitan/build/Lib/test/support/script_helper.py", line 157, in assert_python_ok
    return _assert_python(True, *args, **env_vars)
  File "/Users/buildbot/buildarea/3.x.billenstein-elcapitan/build/Lib/test/support/script_helper.py", line 143, in _assert_python
    res.fail(cmd_line)
  File "/Users/buildbot/buildarea/3.x.billenstein-elcapitan/build/Lib/test/support/script_helper.py", line 70, in fail
    raise AssertionError("Process return code is %d\n"
AssertionError: Process return code is 1
command line: ['/Users/buildbot/buildarea/3.x.billenstein-elcapitan/build/python.exe', '-X', 'faulthandler', '-I', '-u', '/Users/buildbot/buildarea/3.x.billenstein-elcapitan/build/Lib/test/eintrdata/eintr_tester.py']

    stdout:
    ---

    ---

    stderr:
    ---
    ........ss.s.ss.Timeout (0:10:00)!
    Thread 0x00007fff7c082000 (most recent call first):
    File "/Users/buildbot/buildarea/3.x.billenstein-elcapitan/build/Lib/test/eintrdata/eintr_tester.py", line 349 in python_open
    File "/Users/buildbot/buildarea/3.x.billenstein-elcapitan/build/Lib/test/eintrdata/eintr_tester.py", line 345 in _test_open
    File "/Users/buildbot/buildarea/3.x.billenstein-elcapitan/build/Lib/test/support/init.py", line 596 in wrapper
    File "/Users/buildbot/buildarea/3.x.billenstein-elcapitan/build/Lib/test/eintrdata/eintr_tester.py", line 353 in test_open
    File "/Users/buildbot/buildarea/3.x.billenstein-elcapitan/build/Lib/unittest/case.py", line 642 in run
    File "/Users/buildbot/buildarea/3.x.billenstein-elcapitan/build/Lib/unittest/case.py", line 702 in __call__
    File "/Users/buildbot/buildarea/3.x.billenstein-elcapitan/build/Lib/unittest/suite.py", line 122 in run
    File "/Users/buildbot/buildarea/3.x.billenstein-elcapitan/build/Lib/unittest/suite.py", line 84 in __call__
    File "/Users/buildbot/buildarea/3.x.billenstein-elcapitan/build/Lib/unittest/suite.py", line 122 in run
    File "/Users/buildbot/buildarea/3.x.billenstein-elcapitan/build/Lib/unittest/suite.py", line 84 in __call__
    File "/Users/buildbot/buildarea/3.x.billenstein-elcapitan/build/Lib/unittest/runner.py", line 176 in run
    File "/Users/buildbot/buildarea/3.x.billenstein-elcapitan/build/Lib/unittest/main.py", line 271 in runTests
    File "/Users/buildbot/buildarea/3.x.billenstein-elcapitan/build/Lib/unittest/main.py", line 101 in __init__
    File "/Users/buildbot/buildarea/3.x.billenstein-elcapitan/build/Lib/test/eintrdata/eintr_tester.py", line 527 in <module>
    ---

    ----------------------------------------------------------------------

    Ran 1 test in 605.488s

    FAILED (failures=1)
    Warning -- files was modified by test_eintr
    Before: []
    After: ['@test_57532_tmp']
    test test_eintr failed

    @vstinner vstinner added 3.8 only security fixes tests Tests in the Lib/test dir labels Nov 30, 2018
    @vstinner
    Copy link
    Member Author

    I'm unable to reproduce the bug on macOS 10.13.6 using:

    ./python.exe -m test -F test_eintr --timeout=60

    I modified the test to display immediately result into stdout:

    diff --git a/Lib/test/test_eintr.py b/Lib/test/test_eintr.py
index 25f86d3..47b89d3 100644
--- a/Lib/test/test_eintr.py
+++ b/Lib/test/test_eintr.py
@@ -1,6 +1,8 @@
 import os
+import sys
 import signal
 import unittest
+import subprocess
 
 from test import support
 from test.support import script_helper
@@ -15,7 +17,9 @@ class EINTRTests(unittest.TestCase):
         # thread (for reliable signal delivery).
         tester = support.findfile("eintr_tester.py", subdir="eintrdata")
         # use -u to try to get the full output if the test hangs or crash
-        script_helper.assert_python_ok("-u", tester)
+        proc = subprocess.run([sys.executable, "-u", tester, "-v"])
+        if proc.returncode:
+            self.fail("fail")
 
 
 if __name__ == "__main__":

    @vstinner
    Copy link
    Member Author

    I stopped my manual test after 71 iterations.

    @vstinner
    Copy link
    Member Author

    vstinner commented Dec 4, 2018

    Oh. That's just a variant of the old bpo-25234.

    @vstinner
    Copy link
    Member Author

    vstinner commented Dec 4, 2018

    New changeset 4752e65 by Victor Stinner in branch 'master':
    bpo-35363, test_eintr: skip test_open() on macOS (GH-10896)
    4752e65

    @vstinner
    Copy link
    Member Author

    vstinner commented Dec 5, 2018

    New changeset 93d038c by Victor Stinner in branch '3.6':
    bpo-35363, test_eintr: skip test_open() on macOS (GH-10896) (GH-10912)
    93d038c

    @vstinner
    Copy link
    Member Author

    vstinner commented Dec 5, 2018

    New changeset c93e3b0 by Victor Stinner in branch '3.7':
    bpo-35363, test_eintr: skip test_open() on macOS (GH-10896) (GH-10911)
    c93e3b0

    @vstinner vstinner closed this as completed Dec 5, 2018
    @vstinner
    Copy link
    Member Author

    vstinner commented Dec 5, 2018

    New changeset aa8ae90 by Victor Stinner in branch 'master':
    bpo-35363: test_eintr runs eintr_tester.py in verbose mode (GH-10965)
    aa8ae90

    @miss-islington
    Copy link
    Contributor

    New changeset 0fc3b2f by Miss Islington (bot) in branch '3.7':
    bpo-35363: test_eintr runs eintr_tester.py in verbose mode (GH-10965)
    0fc3b2f

    @miss-islington
    Copy link
    Contributor

    New changeset 4699f2a by Miss Islington (bot) in branch '3.6':
    bpo-35363: test_eintr runs eintr_tester.py in verbose mode (GH-10965)
    4699f2a

    @vstinner
    Copy link
    Member Author

    vstinner commented Dec 6, 2018

    New changeset 0644b33 by Victor Stinner in branch 'master':
    bpo-35363: test_eintr uses print(flush=True) (GH-10990)
    0644b33

    @miss-islington
    Copy link
    Contributor

    New changeset 560fa4d by Miss Islington (bot) in branch '3.7':
    bpo-35363: test_eintr uses print(flush=True) (GH-10990)
    560fa4d

    @miss-islington
    Copy link
    Contributor

    New changeset 3f0e8e2 by Miss Islington (bot) in branch '3.6':
    bpo-35363: test_eintr uses print(flush=True) (GH-10990)
    3f0e8e2

    @vstinner
    Copy link
    Member Author

    vstinner commented Dec 6, 2018

    Follow-up: bpo-35425, "test_eintr fails randomly on AMD64 FreeBSD 10-STABLE Non-Debug 3.7: TypeError: 'int' object is not callable".

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.8 only security fixes tests Tests in the Lib/test dir
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @vstinner @miss-islington