Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LTOFLAGS are passed to BASECFLAGS when using LTO #79532

Closed
stratakis mannequin opened this issue Nov 29, 2018 · 5 comments
Closed

LTOFLAGS are passed to BASECFLAGS when using LTO #79532

stratakis mannequin opened this issue Nov 29, 2018 · 5 comments
Labels
3.7 (EOL) end of life 3.8 only security fixes build The build process and cross-build extension-modules C modules in the Modules dir

Comments

@stratakis
Copy link
Mannequin

stratakis mannequin commented Nov 29, 2018

BPO 35351
Nosy @vstinner, @ned-deily, @stratakis, @miss-islington
PRs
  • bpo-35351: Pass link time optimization flags to CFLAGS_NODIST. #10797
  • [3.7] bpo-35351: Pass link time optimization flags to CFLAGS_NODIST (GH-10797) #10893
  • [3.6] bpo-35351: Pass link time optimization flags to CFLAGS_NODIST (GH-10797) #11046
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2018-12-09.08:43:45.694>
created_at = <Date 2018-11-29.15:29:01.903>
labels = ['extension-modules', '3.8', 'build', '3.7']
title = 'LTOFLAGS are passed to BASECFLAGS when using LTO'
updated_at = <Date 2018-12-09.08:43:45.692>
user = 'https://github.com/stratakis'

    bugs.python.org fields:

    activity = <Date 2018-12-09.08:43:45.692>
actor = 'ned.deily'
assignee = 'none'
closed = True
closed_date = <Date 2018-12-09.08:43:45.694>
closer = 'ned.deily'
components = ['Build', 'Extension Modules']
creation = <Date 2018-11-29.15:29:01.903>
creator = 'cstratak'
dependencies = []
files = []
hgrepos = []
issue_num = 35351
keywords = ['patch']
message_count = 5.0
messages = ['330697', '331049', '331051', '331416', '331417']
nosy_count = 4.0
nosy_names = ['vstinner', 'ned.deily', 'cstratak', 'miss-islington']
pr_nums = ['10797', '10893', '11046']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue35351'
versions = ['Python 3.6', 'Python 3.7', 'Python 3.8']
    @stratakis
    Copy link
    Mannequin Author

    stratakis mannequin commented Nov 29, 2018

    Through configure.ac and this change [0] LTOFLAGS and more specifically -flto is baked into BASECFLAGS when using link time optimizations, which will make this flag propagate to distutils.

    [0] 69a3f15#diff-67e997bcfdac55191033d57a16d1408aL1350

    @stratakis stratakis mannequin added 3.7 (EOL) end of life 3.8 only security fixes build The build process and cross-build extension-modules C modules in the Modules dir labels Nov 29, 2018
    @vstinner
    Copy link
    Member

    vstinner commented Dec 4, 2018

    New changeset f92c7aa by Victor Stinner (stratakis) in branch 'master':
    bpo-35351: Pass link time optimization flags to CFLAGS_NODIST (GH-10797)
    f92c7aa

    @miss-islington
    Copy link
    Contributor

    New changeset 1751423 by Miss Islington (bot) in branch '3.7':
    bpo-35351: Pass link time optimization flags to CFLAGS_NODIST (GH-10797)
    1751423

    @miss-islington
    Copy link
    Contributor

    New changeset f2d2cb1 by Miss Islington (bot) in branch '3.6':
    bpo-35351: Pass link time optimization flags to CFLAGS_NODIST (GH-10797)
    f2d2cb1

    @ned-deily
    Copy link
    Member

    See also bpo-28015, bpo-31354, and bpo-35257.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.7 (EOL) end of life 3.8 only security fixes build The build process and cross-build extension-modules C modules in the Modules dir
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    3 participants
    @vstinner @ned-deily @miss-islington