Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A possible segfault involving a newly-created coroutine #79450

Closed
ZackerySpytz mannequin opened this issue Nov 17, 2018 · 4 comments
Closed

A possible segfault involving a newly-created coroutine #79450

ZackerySpytz mannequin opened this issue Nov 17, 2018 · 4 comments
Labels
3.7 (EOL) end of life 3.8 only security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) topic-asyncio type-crash A hard crash of the interpreter, possibly with a core dump

Comments

@ZackerySpytz
Copy link
Mannequin

ZackerySpytz mannequin commented Nov 17, 2018

BPO 35269
Nosy @njsmith, @asvetlov, @1st1, @ZackerySpytz, @miss-islington
PRs
  • bpo-35269: Fix a possible segfault involving a newly-created coroutine #10585
  • [3.7] bpo-35269: Fix a possible segfault involving a newly-created coroutine (GH-10585) #10590
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2018-11-18.18:12:29.264>
created_at = <Date 2018-11-17.17:15:56.111>
labels = ['interpreter-core', '3.7', '3.8', 'type-crash', 'expert-asyncio']
title = 'A possible segfault involving a newly-created coroutine'
updated_at = <Date 2018-11-18.21:17:38.592>
user = 'https://github.com/ZackerySpytz'

    bugs.python.org fields:

    activity = <Date 2018-11-18.21:17:38.592>
actor = 'asvetlov'
assignee = 'none'
closed = True
closed_date = <Date 2018-11-18.18:12:29.264>
closer = 'asvetlov'
components = ['Interpreter Core', 'asyncio']
creation = <Date 2018-11-17.17:15:56.111>
creator = 'ZackerySpytz'
dependencies = []
files = []
hgrepos = []
issue_num = 35269
keywords = ['patch']
message_count = 4.0
messages = ['330031', '330051', '330052', '330062']
nosy_count = 5.0
nosy_names = ['njs', 'asvetlov', 'yselivanov', 'ZackerySpytz', 'miss-islington']
pr_nums = ['10585', '10590']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'crash'
url = 'https://bugs.python.org/issue35269'
versions = ['Python 3.7', 'Python 3.8']
    @ZackerySpytz
    Copy link
    Mannequin Author

    ZackerySpytz mannequin commented Nov 17, 2018

    If compute_cr_origin() fails in PyCoro_New(), coro->cr_origin won't be initialized. This will cause a crash during the coroutine's deallocation.

    I'll create a PR for this issue.

    @ZackerySpytz ZackerySpytz mannequin added 3.7 (EOL) end of life 3.8 only security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) topic-asyncio type-crash A hard crash of the interpreter, possibly with a core dump labels Nov 17, 2018
    @miss-islington
    Copy link
    Contributor

    New changeset 062a57b by Miss Islington (bot) (Zackery Spytz) in branch 'master':
    bpo-35269: Fix a possible segfault involving a newly-created coroutine (GH-10585)
    062a57b

    @miss-islington
    Copy link
    Contributor

    New changeset ae02a92 by Miss Islington (bot) in branch '3.7':
    bpo-35269: Fix a possible segfault involving a newly-created coroutine (GH-10585)
    ae02a92

    @asvetlov
    Copy link
    Contributor

    Thanks, Zackery!

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.7 (EOL) end of life 3.8 only security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) topic-asyncio type-crash A hard crash of the interpreter, possibly with a core dump
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @asvetlov @miss-islington