Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IDLE: use 'macOS' where appropriate. #79394

Closed
terryjreedy opened this issue Nov 12, 2018 · 11 comments
Closed

IDLE: use 'macOS' where appropriate. #79394

terryjreedy opened this issue Nov 12, 2018 · 11 comments
Assignees
Labels
3.7 (EOL) end of life 3.8 only security fixes topic-IDLE type-feature A feature request or enhancement

Comments

@terryjreedy
Copy link
Member

BPO 35213
Nosy @terryjreedy, @ned-deily, @matrixise, @miss-islington
PRs
  • bpo-35213: Where appropriate, use 'macOS' in idlelib. #10478
  • [3.7] bpo-35213: Where appropriate, use 'macOS' in idlelib. (GH-10478) #10559
  • [3.6] bpo-35213: Where appropriate, use 'macOS' in idlelib. (GH-10478) #10560
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/terryjreedy'
    closed_at = <Date 2018-12-11.21:13:21.616>
    created_at = <Date 2018-11-12.05:06:14.715>
    labels = ['3.8', 'expert-IDLE', 'type-feature', '3.7']
    title = "IDLE: use 'macOS' where appropriate."
    updated_at = <Date 2018-12-11.21:13:21.615>
    user = 'https://github.com/terryjreedy'

    bugs.python.org fields:

    activity = <Date 2018-12-11.21:13:21.615>
    actor = 'terry.reedy'
    assignee = 'terry.reedy'
    closed = True
    closed_date = <Date 2018-12-11.21:13:21.616>
    closer = 'terry.reedy'
    components = ['IDLE']
    creation = <Date 2018-11-12.05:06:14.715>
    creator = 'terry.reedy'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 35213
    keywords = ['patch']
    message_count = 11.0
    messages = ['329713', '329715', '329724', '329741', '329742', '329748', '329749', '329957', '329961', '329962', '331651']
    nosy_count = 4.0
    nosy_names = ['terry.reedy', 'ned.deily', 'matrixise', 'miss-islington']
    pr_nums = ['10478', '10559', '10560']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'enhancement'
    url = 'https://bugs.python.org/issue35213'
    versions = ['Python 3.6', 'Python 3.7', 'Python 3.8']

    @terryjreedy
    Copy link
    Member Author

    'maxOS' is Apple's current name for the Mac operating system. See https://en.wikipedia.org/wiki/MacOS, Contents, Release History.

    The module name macosx.py is currently left as is. Within that, 'Mac OS X' is correct for 10.6 for 10.8.

    @terryjreedy terryjreedy added 3.7 (EOL) end of life 3.8 only security fixes labels Nov 12, 2018
    @terryjreedy terryjreedy self-assigned this Nov 12, 2018
    @terryjreedy terryjreedy added topic-IDLE type-feature A feature request or enhancement labels Nov 12, 2018
    @terryjreedy
    Copy link
    Member Author

    This issue is a spinoff of bpo-34864.

    @matrixise
    Copy link
    Member

    @terry, I suppose you wanted to say "macOs" and not "maxOs"

    @terryjreedy
    Copy link
    Member Author

    Whoops, 'macOS', as in the title and PR.

    @matrixise
    Copy link
    Member

    ;-) just a joke.

    I have reviewed your PR, but do you count with the occurences of "OS X", it's the abbreviation of "MacOS X"?

    @terryjreedy
    Copy link
    Member Author

    The history of names for 10.X, from the reference above (which also has nicknames, like 'Mavericks' and 'Mohave', which I believe we do not use).

    10.0 to 10.7: Mac OS X (space or spaces sometime left out, as in macosx)
    10.8 to 10.13: OS X (2012, ditto)
    10.14 to (current) 10.16 (2016)

    AFAIK, the current Mac installers support either 10.6+ or 10.9+. The macosx references to 'Mac OS X 10.6' and 'OS X 10.7 and 10.8' are properly not changed.

    'OS X' in pyshell.py is removed in PR 10464.

    The most recent item in NEWS.txt using 'OS X' is for bpo-27310, June 2016, by Ned, who used 'OS X'. So no changes to NEWS.txt or NEWS2.txt.

    ** Ned **
    Should 'OS X Aqua Tk' be changed to 'macOS Aqua Tk' or 'macOS (OS X) Aqua Tk'? In other words, is 'OS X' here a replaceable noun adjective or an integral part of a proper name? The PR did the 2nd replacement in config.py, since the comment is about the 'IDLE Classic OSX' keyset, but I deferred the change in mainmenu.py.

    Same issue with 'OS X Cocoa Tk 8.5' in editor.py.

    Editor.py also has "Some OS X systems have only one mouse button". It seems to me that 'Mac' would be a better replacement that 'macOS' as the mouse is part of the hardware system, not the OS software.

    @terryjreedy
    Copy link
    Member Author

    The 4th line above should include 'macOS'.

    10.14 to current 10.16: macOS (2016)

    @terryjreedy
    Copy link
    Member Author

    New changeset b65413b by Terry Jan Reedy in branch 'master':
    bpo-35213: Where appropriate, use 'macOS' in idlelib. (bpo-10478)
    b65413b

    @miss-islington
    Copy link
    Contributor

    New changeset 579c417 by Miss Islington (bot) in branch '3.7':
    bpo-35213: Where appropriate, use 'macOS' in idlelib. (GH-10478)
    579c417

    @miss-islington
    Copy link
    Contributor

    New changeset be657c1 by Miss Islington (bot) in branch '3.6':
    bpo-35213: Where appropriate, use 'macOS' in idlelib. (GH-10478)
    be657c1

    @terryjreedy
    Copy link
    Member Author

    Any more changes can be a future issue.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.7 (EOL) end of life 3.8 only security fixes topic-IDLE type-feature A feature request or enhancement
    Projects
    None yet
    Development

    No branches or pull requests

    3 participants