Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

asyncio shield: remove inner callback on outer cancellation #79306

Closed
MainRo mannequin opened this issue Oct 31, 2018 · 3 comments
Closed

asyncio shield: remove inner callback on outer cancellation #79306

MainRo mannequin opened this issue Oct 31, 2018 · 3 comments
Labels
3.7 (EOL) end of life 3.8 only security fixes topic-asyncio type-bug An unexpected behavior, bug, or error

Comments

@MainRo
Copy link
Mannequin

MainRo mannequin commented Oct 31, 2018

BPO 35125
Nosy @asvetlov, @1st1, @miss-islington, @MainRo
PRs
  • bpo-35125: remove inner callback on outer cancellation in asyncio shield #10340
  • [3.7] bpo-35125: remove inner callback on outer cancellation in asyncio shield (GH-10340) #13167
    		•
    Files
  • shield_cancel.patch: shield cancellation patch
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2019-05-07.19:05:59.639>
created_at = <Date 2018-10-31.15:18:41.298>
labels = ['3.8', 'type-bug', '3.7', 'expert-asyncio']
title = 'asyncio shield: remove inner callback on outer cancellation'
updated_at = <Date 2019-05-07.19:38:02.985>
user = 'https://github.com/mainro'

    bugs.python.org fields:

    activity = <Date 2019-05-07.19:38:02.985>
actor = 'miss-islington'
assignee = 'none'
closed = True
closed_date = <Date 2019-05-07.19:05:59.639>
closer = 'asvetlov'
components = ['asyncio']
creation = <Date 2018-10-31.15:18:41.298>
creator = 'mainro'
dependencies = []
files = ['47897']
hgrepos = []
issue_num = 35125
keywords = ['patch']
message_count = 3.0
messages = ['328997', '341798', '341807']
nosy_count = 4.0
nosy_names = ['asvetlov', 'yselivanov', 'miss-islington', 'mainro']
pr_nums = ['10340', '13167']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue35125'
versions = ['Python 3.7', 'Python 3.8']
    @MainRo
    Copy link
    Mannequin Author

    MainRo mannequin commented Oct 31, 2018

    When the future returned by shield is cancelled, its completion callback of the inner future is not removed. This makes the callback list of inner inner future grow each time a shield is created.

    @MainRo MainRo mannequin added 3.7 (EOL) end of life topic-asyncio type-bug An unexpected behavior, bug, or error labels Oct 31, 2018
    @miss-islington
    Copy link
    Contributor

    New changeset b35acc5 by Miss Islington (bot) (Romain Picard) in branch 'master':
    bpo-35125: remove inner callback on outer cancellation in asyncio shield (GH-10340)
    b35acc5

    @asvetlov asvetlov added the 3.8 only security fixes label May 7, 2019
    @asvetlov asvetlov closed this as completed May 7, 2019
    @miss-islington
    Copy link
    Contributor

    New changeset 299f69c by Miss Islington (bot) in branch '3.7':
    bpo-35125: remove inner callback on outer cancellation in asyncio shield (GH-10340)
    299f69c

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.7 (EOL) end of life 3.8 only security fixes topic-asyncio type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @asvetlov @miss-islington