Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect charset range handling with ignore case flag? #47761

Closed
mrabarnett mannequin opened this issue Aug 6, 2008 · 7 comments
Closed

Incorrect charset range handling with ignore case flag? #47761

mrabarnett mannequin opened this issue Aug 6, 2008 · 7 comments
Labels
topic-regex type-bug An unexpected behavior, bug, or error

Comments

@mrabarnett
Copy link
Mannequin

mrabarnett mannequin commented Aug 6, 2008

BPO 3511
Nosy @terryjreedy, @pitrou, @ezio-melotti, @serhiy-storchaka
Superseder
  • bpo-17381: IGNORECASE breaks unicode literal range matching
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2010-08-03.18:56:03.567>
    created_at = <Date 2008-08-06.19:41:11.563>
    labels = ['expert-regex', 'type-bug']
    title = 'Incorrect charset range handling with ignore case flag?'
    updated_at = <Date 2014-11-08.12:14:26.587>
    user = 'https://bugs.python.org/mrabarnett'

    bugs.python.org fields:

    activity = <Date 2014-11-08.12:14:26.587>
    actor = 'serhiy.storchaka'
    assignee = 'none'
    closed = True
    closed_date = <Date 2010-08-03.18:56:03.567>
    closer = 'terry.reedy'
    components = ['Regular Expressions']
    creation = <Date 2008-08-06.19:41:11.563>
    creator = 'mrabarnett'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 3511
    keywords = []
    message_count = 7.0
    messages = ['70799', '73711', '82515', '82537', '82541', '112652', '230848']
    nosy_count = 6.0
    nosy_names = ['terry.reedy', 'pitrou', 'timehorse', 'ezio.melotti', 'mrabarnett', 'serhiy.storchaka']
    pr_nums = []
    priority = 'normal'
    resolution = 'duplicate'
    stage = None
    status = 'closed'
    superseder = '17381'
    type = 'behavior'
    url = 'https://bugs.python.org/issue3511'
    versions = ['Python 2.6', 'Python 2.5', 'Python 3.0']

    @mrabarnett
    Copy link
    Mannequin Author

    mrabarnett mannequin commented Aug 6, 2008

    While working on the regex code in sre_compile.py I came across the
    following code in the handling of charset ranges in _optimize_charset:

        for i in range(fixup(av[0]), fixup(av[1])+1):
            charmap[i] = 1

    The function fixup converts the ends of the range to lower case if the
    ignore-case flag is present. The problem with this approach is
    illustrated below:

    >>> import re
    >>> print re.match(r'[9-A]', 'A')
    <_sre.SRE_Match object at 0x00A78058>
    >>> print re.match(r'[9-A]', 'a')
    None
    >>> print re.match(r'[9-A]', '_')
    None
    >>> print re.match(r'[9-A]', 'A', re.IGNORECASE)
    <_sre.SRE_Match object at 0x00D0BFA8>
    >>> print re.match(r'[9-A]', 'a', re.IGNORECASE)
    <_sre.SRE_Match object at 0x00A78058>
    >>> print re.match(r'[9-A]', '_', re.IGNORECASE)
    <_sre.SRE_Match object at 0x00D0BFA8>
    >>> 

    '_' doesn't lie between '9' and 'A', but it does lie between '9' and 'a'.

    Surely the ignore-case flag should not affect whether non-letters are
    matched or not?

    @mrabarnett mrabarnett mannequin added topic-regex type-bug An unexpected behavior, bug, or error labels Aug 6, 2008
    @timehorse
    Copy link
    Mannequin

    timehorse mannequin commented Sep 24, 2008

    I think this is even more complicated when you consider that
    localization my be an issue. Consider "Á": is this grammatically before
    "A" or after "a"? From a character set point of view, it is typically
    after "a" but when Locale is taken into account, all that is done is
    there is a change to relative ordering, so Á appears somewhere before A
    and B. But when this is done, does that mean that [9-Á] is going to
    cover ALL uppercase and ALL lowercase and ALL characters with ord from
    91 to 96 and 123 to 127 and all kinds of other UNICODE symbols? And how
    will this effect case-insensitivity.

    In a sense, I think it may only be safe to say that character class
    ranges are ONLY appropriate over Alphabetic character ranges or numeric
    character ranges, since the order of the ASCII symbols between 0 and 47,
    56 and 64, 91 adn 96 and 123 and 127, though well-defined, are none the
    less implementation dependent. When we bring UNICODE into this, things
    get even more befuddled with some Latin characters in Latin-1, some in
    Latin-2, Cyrillic, Hebrew, Arabic, Chinese, Japanese and Korean
    character sets just to name a few of the most common! And how does a
    total ordering of characters apply to them?

    In the end, I think it's just dangerous to define character group ranges
    that span the gap BETWEEN numbers and alphabetics. Instead, I think a
    better solution is simply to implement Emacs / Perl style named
    character classes as in bpo-2636 sub-item 8.

    I do agree this is a problem, but as I see it, the solution may not be
    that simple, especially in a UNICODE world.

    @ezio-melotti
    Copy link
    Member

    I'd close this as "won't fix", because (IMHO) ranges like [9-A]
    shouldn't be used at all, so I won't expect it to work properly.

    FWIW Perl doesn't seem to match the '_', even with the 'i' flag. Tested
    with: perl -e '$s = ("_" =~ /[9-A]/); print $s' and perl -e '$s = ("_"
    =~ /[9-A]/i); print $s'. It matches ":" with [9-A] and "_" with [9-a]
    though (both without the 'i' flag).

    @mrabarnett
    Copy link
    Mannequin Author

    mrabarnett mannequin commented Feb 20, 2009

    "[9-A]" is equivalent to "[9:;<=>?@A]", or should be.

    It'll be fixed in issue bpo-2636.

    @ezio-melotti
    Copy link
    Member

    If there's already a patch, then it's fine (and useful for ranges of
    Unicode chars), but I wouldn't like to find a range like [9-A] around ;)

    @terryjreedy
    Copy link
    Member

    EM and MB seemed to agree on closing this.

    @serhiy-storchaka
    Copy link
    Member

    Fixed in bpo-17381 (which has more realistic example than [9-A]).

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    topic-regex type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Development

    No branches or pull requests

    3 participants