Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow customization of CSS class name of a month in calendar module #79259

Closed
srinivasreddy mannequin opened this issue Oct 26, 2018 · 6 comments
Closed

Allow customization of CSS class name of a month in calendar module #79259

srinivasreddy mannequin opened this issue Oct 26, 2018 · 6 comments
Labels
3.8 only security fixes stdlib Python modules in the Lib dir type-feature A feature request or enhancement

Comments

@srinivasreddy
Copy link
Mannequin

srinivasreddy mannequin commented Oct 26, 2018

BPO 35078
Nosy @doerwalter, @rhettinger, @serhiy-storchaka, @srinivasreddy, @csabella, @tirkarthi
PRs
  • bpo-35078:Allow customization of CSS class name of a month in calendar module #10137
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2020-06-02.17:19:33.857>
created_at = <Date 2018-10-26.17:26:56.571>
labels = ['3.8', 'type-feature', 'library']
title = 'Allow customization of CSS class name of a month in calendar module'
updated_at = <Date 2020-06-02.17:19:33.856>
user = 'https://github.com/srinivasreddy'

    bugs.python.org fields:

    activity = <Date 2020-06-02.17:19:33.856>
actor = 'doerwalter'
assignee = 'none'
closed = True
closed_date = <Date 2020-06-02.17:19:33.857>
closer = 'doerwalter'
components = ['Library (Lib)']
creation = <Date 2018-10-26.17:26:56.571>
creator = 'thatiparthy'
dependencies = []
files = []
hgrepos = []
issue_num = 35078
keywords = ['patch']
message_count = 6.0
messages = ['328651', '328653', '328654', '328655', '335576', '370604']
nosy_count = 6.0
nosy_names = ['doerwalter', 'rhettinger', 'serhiy.storchaka', 'thatiparthy', 'cheryl.sabella', 'xtreak']
pr_nums = ['10137']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue35078'
versions = ['Python 3.8']
    @srinivasreddy srinivasreddy mannequin added 3.8 only security fixes stdlib Python modules in the Lib dir labels Oct 26, 2018
    @srinivasreddy srinivasreddy mannequin changed the title Allow customization of css class name of a month in calendar module Refactor code in calendar.py module Oct 27, 2018
    @serhiy-storchaka
    Copy link
    Member

    We don't usually do pure refactoring changes.

    @tirkarthi
    Copy link
    Member

    Serhiy, this adds a change where month's name CSS class is now customizable in LocaleHTMLCalendar. It's currently hard-coded as "month" though HTMLCalendar is customizable. I suggested method reuse since LocaleHTMLCalendar from HTMLCalendar that would fix this instead of duplicating the code. I think this can be reopened.

    @serhiy-storchaka
    Copy link
    Member

    Sorry, I was fooled by misleading titles and news entry. Please change them.

    @tirkarthi
    Copy link
    Member

    No problem, I have left a PR comment [0] to add the actual enhancement in the NEWS entry so that it's visible. The original issue title was "Allow customization of css class name of a month in calendar module" and @thatiparthy changed the issue title and PR to "Refactor code in calendar.py module" maybe due to my solution causing little confusion.

    @thatiparthy I am changing the issue title to "Allow customization of CSS class name of a month in calendar module"

    [0] #10137 (review)

    Thanks

    @tirkarthi tirkarthi changed the title Refactor code in calendar.py module Allow customization of CSS class name of a month in calendar module Oct 27, 2018
    @tirkarthi tirkarthi added the type-feature A feature request or enhancement label Oct 27, 2018
    @csabella
    Copy link
    Contributor

    bpo-30095 enhanced the HTMLCalendar code to allow easier customization of the CSS classes. This PR extends that to the existing LocaleHTMLCalendar.

    Adding @doerwalter to the nosy list as he merged bpo-30095.

    @doerwalter
    Copy link
    Contributor

    New changeset 85339f5 by Srinivas Reddy Thatiparthy (శ్రీనివాస్ రెడ్డి తాటిపర్తి) in branch 'master':
    bpo-35078: Allow customization of CSS class name of a month in calendar module (gh-10137)
    85339f5

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.8 only security fixes stdlib Python modules in the Lib dir type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    4 participants
    @doerwalter @serhiy-storchaka @tirkarthi @csabella