Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use vswhere instead of _distutils_findvs #79248

Closed
zooba opened this issue Oct 25, 2018 · 3 comments
Closed

Use vswhere instead of _distutils_findvs #79248

zooba opened this issue Oct 25, 2018 · 3 comments
Assignees
Labels
3.7 (EOL) end of life 3.8 only security fixes OS-windows stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error

Comments

@zooba
Copy link
Member

zooba commented Oct 25, 2018

BPO 35067
Nosy @pfmoore, @tjguk, @merwok, @zware, @zooba, @dstufft, @miss-islington
PRs
  • bpo-35067: Remove _distutils_findvs and use vswhere.exe instead. #10095
  • [3.7] bpo-35067: Remove _distutils_findvs and use vswhere.exe instead. (GH-10095) #10158
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/zooba'
    closed_at = <Date 2018-10-27.22:05:23.507>
    created_at = <Date 2018-10-25.15:28:59.662>
    labels = ['3.7', '3.8', 'type-bug', 'library', 'OS-windows']
    title = 'Use vswhere instead of _distutils_findvs'
    updated_at = <Date 2018-10-27.22:05:23.506>
    user = 'https://github.com/zooba'

    bugs.python.org fields:

    activity = <Date 2018-10-27.22:05:23.506>
    actor = 'steve.dower'
    assignee = 'steve.dower'
    closed = True
    closed_date = <Date 2018-10-27.22:05:23.507>
    closer = 'steve.dower'
    components = ['Distutils', 'Windows']
    creation = <Date 2018-10-25.15:28:59.662>
    creator = 'steve.dower'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 35067
    keywords = ['patch']
    message_count = 3.0
    messages = ['328451', '328660', '328661']
    nosy_count = 7.0
    nosy_names = ['paul.moore', 'tim.golden', 'eric.araujo', 'zach.ware', 'steve.dower', 'dstufft', 'miss-islington']
    pr_nums = ['10095', '10158']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'behavior'
    url = 'https://bugs.python.org/issue35067'
    versions = ['Python 3.7', 'Python 3.8']

    @zooba
    Copy link
    Member Author

    zooba commented Oct 25, 2018

    We have much simpler needs for distutils that don't require the more complex build/dependencies we currently have.

    We should remove the extra native module and just shell out to vswhere.exe, which is always included in the VS installer in a known location.

    @zooba zooba added 3.7 (EOL) end of life 3.8 only security fixes labels Oct 25, 2018
    @zooba zooba self-assigned this Oct 25, 2018
    @zooba zooba added stdlib Python modules in the Lib dir OS-windows type-bug An unexpected behavior, bug, or error labels Oct 25, 2018
    @zooba
    Copy link
    Member Author

    zooba commented Oct 27, 2018

    New changeset 53125a5 by Steve Dower in branch 'master':
    bpo-35067: Remove _distutils_findvs and use vswhere.exe instead. (GH-10095)
    53125a5

    @miss-islington
    Copy link
    Contributor

    New changeset e2cf819 by Miss Islington (bot) in branch '3.7':
    bpo-35067: Remove _distutils_findvs and use vswhere.exe instead. (GH-10095)
    e2cf819

    @zooba zooba closed this as completed Oct 27, 2018
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.7 (EOL) end of life 3.8 only security fixes OS-windows stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Development

    No branches or pull requests

    2 participants