Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add mtime argument to gzip.compress #79079

Closed
guoci mannequin opened this issue Oct 4, 2018 · 4 comments
Closed

add mtime argument to gzip.compress #79079

guoci mannequin opened this issue Oct 4, 2018 · 4 comments
Labels
3.8 only security fixes stdlib Python modules in the Lib dir type-feature A feature request or enhancement

Comments

@guoci
Copy link
Mannequin

guoci mannequin commented Oct 4, 2018

BPO 34898
Nosy @serhiy-storchaka, @guoci, @dhimmel, @sir-sigurd, @tirkarthi
PRs
  • bpo-34898: Add mtime argument to gzip.compress #9704
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2018-11-07.09:51:40.852>
created_at = <Date 2018-10-04.21:22:04.656>
labels = ['3.8', 'type-feature', 'library']
title = 'add mtime argument to gzip.compress'
updated_at = <Date 2019-08-23.15:19:25.401>
user = 'https://github.com/guoci'

    bugs.python.org fields:

    activity = <Date 2019-08-23.15:19:25.401>
actor = 'dhimmel'
assignee = 'none'
closed = True
closed_date = <Date 2018-11-07.09:51:40.852>
closer = 'serhiy.storchaka'
components = ['Library (Lib)']
creation = <Date 2018-10-04.21:22:04.656>
creator = 'guoci'
dependencies = []
files = []
hgrepos = []
issue_num = 34898
keywords = ['patch']
message_count = 4.0
messages = ['327088', '329408', '329409', '350307']
nosy_count = 5.0
nosy_names = ['serhiy.storchaka', 'guoci', 'dhimmel', 'sir-sigurd', 'xtreak']
pr_nums = ['9704']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue34898'
versions = ['Python 3.8']
    @guoci
    Copy link
    Mannequin Author

    guoci mannequin commented Oct 4, 2018

    With the mtime argument, the output from gzip.compress can be reproducible.

    @guoci guoci mannequin added 3.7 (EOL) end of life 3.8 only security fixes stdlib Python modules in the Lib dir labels Oct 4, 2018
    @serhiy-storchaka
    Copy link
    Member

    New changeset 0e7497c by Serhiy Storchaka (guoci) in branch 'master':
    bpo-34898: Add mtime parameter to gzip.compress(). (GH-9704)
    0e7497c

    @serhiy-storchaka
    Copy link
    Member

    Thank you for your contribution!

    @serhiy-storchaka serhiy-storchaka removed the 3.7 (EOL) end of life label Nov 7, 2018
    @serhiy-storchaka serhiy-storchaka added the type-feature A feature request or enhancement label Nov 7, 2018
    @dhimmel
    Copy link
    Mannequin

    dhimmel mannequin commented Aug 23, 2019

    Any reason not to also expose mtime in the gzip.open API?

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.8 only security fixes stdlib Python modules in the Lib dir type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    1 participant
    @serhiy-storchaka