Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove support for "with (await asyncio.lock):" #78974

Closed
1st1 opened this issue Sep 24, 2018 · 6 comments
Closed

Remove support for "with (await asyncio.lock):" #78974

1st1 opened this issue Sep 24, 2018 · 6 comments
Labels
3.9 only security fixes topic-asyncio

Comments

@1st1
Copy link
Member

1st1 commented Sep 24, 2018

BPO 34793
Nosy @asvetlov, @1st1, @eamanu, @tirkarthi
PRs
  • bpo-34793: Drop old-style context managers in asyncio.locks #17533
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2020-02-01.11:14:45.410>
created_at = <Date 2018-09-24.18:57:32.199>
labels = ['3.9', 'expert-asyncio']
title = 'Remove support for "with (await asyncio.lock):"'
updated_at = <Date 2020-02-01.11:14:45.409>
user = 'https://github.com/1st1'

    bugs.python.org fields:

    activity = <Date 2020-02-01.11:14:45.409>
actor = 'asvetlov'
assignee = 'none'
closed = True
closed_date = <Date 2020-02-01.11:14:45.410>
closer = 'asvetlov'
components = ['asyncio']
creation = <Date 2018-09-24.18:57:32.199>
creator = 'yselivanov'
dependencies = []
files = []
hgrepos = []
issue_num = 34793
keywords = ['patch']
message_count = 6.0
messages = ['326282', '326315', '326317', '326425', '343866', '361160']
nosy_count = 4.0
nosy_names = ['asvetlov', 'yselivanov', 'eamanu', 'xtreak']
pr_nums = ['17533']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue34793'
versions = ['Python 3.9']
    @1st1 1st1 added 3.8 only security fixes topic-asyncio labels Sep 24, 2018
    @1st1
    Copy link
    Member Author

    1st1 commented Sep 24, 2018

    Never mind, we do this already. The question is then should we just remove the support for this syntax entirely in 3.8, or we should wait until 3.9?

    @1st1 1st1 changed the title Raise DeprecationWarning for "with (await lock):" Remove support for "with (await asyncio.lock):" Sep 24, 2018
    @tirkarthi
    Copy link
    Member

    I can see only around 3 results on GitHub with "with await asyncio.lock" and just wanted to add it as a data point : https://github.com/search?utf8=%E2%9C%93&q=%22with+await+asyncio.lock%22&type=Code

    @tirkarthi
    Copy link
    Member

    Another discussion : https://github.com/python/cpython/pull/4753/files#r155656583

    @asvetlov
    Copy link
    Contributor

    I don't care too much.
    Maybe removal is just fine.
    with await ... looks awkward anyway

    @asvetlov
    Copy link
    Contributor

    Let's postpone to 3.9
    I recall at least reports for aioredis, aiomysql and aiokafka for these deprecation warnings.
    Sure, fix is trivial (and will be applied to next release of libs) but I pretty sure there are many other usages.

    @asvetlov asvetlov added 3.9 only security fixes and removed 3.8 only security fixes labels May 29, 2019
    @asvetlov
    Copy link
    Contributor

    asvetlov commented Feb 1, 2020

    New changeset 90d9ba6 by Andrew Svetlov in branch 'master':
    bpo-34793: Drop old-style context managers in asyncio.locks (GH-17533)
    90d9ba6

    @asvetlov asvetlov closed this as completed Feb 1, 2020
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.9 only security fixes topic-asyncio
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    3 participants
    @1st1 @asvetlov @tirkarthi